From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FE1ECE58D for ; Wed, 9 Oct 2019 12:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3033C21848 for ; Wed, 9 Oct 2019 12:18:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nAz6Fdi2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729686AbfJIMST (ORCPT ); Wed, 9 Oct 2019 08:18:19 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:42540 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729699AbfJIMST (ORCPT ); Wed, 9 Oct 2019 08:18:19 -0400 Received: by mail-qk1-f193.google.com with SMTP id f16so1944192qkl.9 for ; Wed, 09 Oct 2019 05:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=W0eFvkxC6/6v6MGd/x6emnhmXUqGXpfFvPc0fr695gI=; b=nAz6Fdi2dhW3cQpy72UZ2Ed+BztZuCu7D3ldtxo3tDn3TZK6+A3HPBEFye8+Ynfrw8 nLuvsgdeP/rP+wVGHGDMjFHZzzTMvP8l7R0Hvk6eUf/N9HJUmZSgz7Gpq+iI9dvKNemg Fo8ctp5jSdqrM2XQoFcgNwtO0ps05sOSYIfTC6Bbe1uSDjthSyRVK5KTS9cWkVKD6fCG sKwHMW7qhSb0YKVcrGx19xZbJin+sRGCQTZcb3A65qEh35/fTHTQLpHWzFiApofiJZCw E4f0KTOMvh+ScMmaX3UkAZc7AOUpTRx5oXHfzpfcfX1LR6O1KiXeL5MfQg9wFstEKWil m2+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=W0eFvkxC6/6v6MGd/x6emnhmXUqGXpfFvPc0fr695gI=; b=GI7PECqj3H40NIahjmcQfe5NdaMu7SUOSsB6uCFpyxmL94U5sUfTps3m4bA3goLHMe QBxKnz7dcKQ5cm+enwvarIwcdQ78PBi5E1xEQ7BQEY2i4OfySSnTxmYh6Tt+WY8TNhfa UJlB0PHaDQcbUcJBp/cAT0Tqrp8lBlTvSDmuUyecRR94/CnQrNVrDXLBNNrPVlqTTIf3 oCQWVmZP49RZW3Lv+fSwub82X4IlbkGbE76MtmsheaBoN7x5JAAIsp7DnIDuLGahix2E WhljP/aZqxVocVKcDdY52glHFM108CpMtstvUJEu/TE2KlL0V2w12GdGToqS/YEfvnM8 i7/Q== X-Gm-Message-State: APjAAAUBLgPrNJ1TQg3P5CMbeQ+XMXNUmx60OMfevAlh3xP6hJUq3tA3 GXCEQbogL6KCOYhdG/E+4cobug== X-Google-Smtp-Source: APXvYqxn+UAHbLMmArJm7Hi4R0DfzBReb9YubzEEu+CatL2CUv1Gkd7cFDXyBbEHSJS6UT+4dHkKpg== X-Received: by 2002:a37:f61d:: with SMTP id y29mr3184876qkj.338.1570623498260; Wed, 09 Oct 2019 05:18:18 -0700 (PDT) Received: from [192.168.1.169] (pool-71-255-246-27.washdc.fios.verizon.net. [71.255.246.27]) by smtp.gmail.com with ESMTPSA id c8sm806133qko.102.2019.10.09.05.18.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Oct 2019 05:18:17 -0700 (PDT) Subject: Re: [PATCH 3/5] dt-bindings: thermal: Add generic power domain warming device binding To: Rob Herring References: <1568135676-9328-1-git-send-email-thara.gopinath@linaro.org> <1568135676-9328-4-git-send-email-thara.gopinath@linaro.org> <20190930144205.GA11539@bogus> Cc: edubezval@gmail.com, rui.zhang@intel.com, ulf.hansson@linaro.org, daniel.lezcano@linaro.org, bjorn.andersson@linaro.org, agross@kernel.org, amit.kucheria@verdurent.com, mark.rutland@arm.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org From: Thara Gopinath Message-ID: <5D9DD006.8010809@linaro.org> Date: Wed, 9 Oct 2019 08:18:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20190930144205.GA11539@bogus> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Rob, Thanks for the review On 09/30/2019 10:42 AM, Rob Herring wrote: > On Tue, Sep 10, 2019 at 01:14:34PM -0400, Thara Gopinath wrote: >> Add binding to define power domains as thermal warming >> devices. >> >> Signed-off-by: Thara Gopinath >> --- >> .../bindings/thermal/pwr-domain-warming.txt | 32 ++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt >> >> diff --git a/Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt b/Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt >> new file mode 100644 >> index 0000000..25fc568 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt >> @@ -0,0 +1,32 @@ >> +* Generic power domain based thermal warming device. >> + >> +This binding describes the power domains that can be used as a >> +thermal warming device. > > This looks like just a gathering of properties and way to instantiate > some driver. > > I think this all belongs in the power domain provider. Make it a cooling > device and you should know which domains are relevant based on the > compatible (though perhaps we could consider a list in DT). If you want > to instantiate a separate driver to handle this, then make the power > domain driver do that. This sounds fine. A list in DT might be needed though. I have a separate driver. I should be able to get the genpd provider driver call into it. I had asked this to Ulf and he seemed to be fine with it as well > > Rob > > -- Regards Thara