From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC0BC38A2A for ; Mon, 11 May 2020 01:27:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E26A9208CA for ; Mon, 11 May 2020 01:27:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728468AbgEKB1f (ORCPT ); Sun, 10 May 2020 21:27:35 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:51674 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727789AbgEKB1f (ORCPT ); Sun, 10 May 2020 21:27:35 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 7A583C00E6D29BD9751B; Mon, 11 May 2020 09:27:32 +0800 (CST) Received: from [10.63.139.185] (10.63.139.185) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Mon, 11 May 2020 09:27:17 +0800 Subject: Re: [PATCH V3 2/2] thermal: Add HiSilicon Kunpeng thermal driver To: Daniel Lezcano , "shenyang (M)" , , References: <1587455093-33876-1-git-send-email-shenyang39@huawei.com> <1587455093-33876-3-git-send-email-shenyang39@huawei.com> <53ca3883-9155-c023-7916-10ec8cccf977@linaro.org> <0be585d3-1180-7b42-8b51-392a34793f70@huawei.com> <5EB65D33.80105@hisilicon.com> <96c7578e-25cf-d258-6505-8c1c631dbe82@linaro.org> CC: , From: Zhou Wang Message-ID: <5EB8A9DC.9030004@hisilicon.com> Date: Mon, 11 May 2020 09:26:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <96c7578e-25cf-d258-6505-8c1c631dbe82@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.139.185] X-CFilter-Loop: Reflected Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 2020/5/10 13:04, Daniel Lezcano wrote: > On 09/05/2020 09:35, Zhou Wang wrote: >> On 2020/4/28 22:02, Daniel Lezcano wrote: >>> On 28/04/2020 13:58, shenyang (M) wrote: >>>> On 2020/4/27 20:13, Daniel Lezcano wrote: >>>>> On 21/04/2020 09:44, Yang Shen wrote: >>>>>> Support HiSilicon Kunpeng tsensor. the driver will report the max >>>>>> temperature for each core. >>>>> >>>>> As this is a new driver, can you give a bit more details of the hardware >>>>> in this description. >>>>> >>>>> A subsidiary question, why do you want to aggregate the temperatures in >>>>> this driver ? >>>>> >>>> >>>> OK. In fact, there are five temperature sensors distributed in the SOC. >>>> And our strategy is to collect all temperatures and return the max to >>>> the interface. >>> >>> The aggregation should be done in the thermal framework not in the driver. >>> >>> Why not create one sensor per thermal zone, so giving the opportunity to >>> create different configurations with different cooling device ? >> >> Hi Daniel, >> >> In our SoC, we use IMU(Intelligent Management Unit) which is an out of band >> management processor to control cooling device. We use fans to cool CPU, one >> fan is for one SoC. So getting one temperature for one SoC is enough here. >> >> We also want to report temperature of the SoC from kernel thermal subsystem, >> so users get get SoC temperature from sysfs or user space tool, like Im-sensor. >> The goal of this driver is just to do this. > > Are you saying you don't care of any cooling devices from the kernel as > the IMU is taking care of it ? Yes. > > Do you have a pointer to a DT where the thermal zones are defined? These sensors are in an aarch64 server system(Kunpeng920), which is based on ACPI. Best, Zhou > > [ ... ] > >