From: Stephen Boyd <swboyd@chromium.org>
To: Tri Vo <trong@android.com>,
gregkh@linuxfoundation.org, rjw@rjwysocki.net,
viresh.kumar@linaro.org
Cc: rafael@kernel.org, hridya@google.com, sspatil@google.com,
kaleshsingh@google.com, ravisadineni@chromium.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
kernel-team@android.com, Tri Vo <trong@android.com>
Subject: Re: [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs
Date: Wed, 31 Jul 2019 14:59:32 -0700 [thread overview]
Message-ID: <5d420f45.1c69fb81.35877.3d86@mx.google.com> (raw)
In-Reply-To: <20190731215514.212215-1-trong@android.com>
Quoting Tri Vo (2019-07-31 14:55:14)
> +/**
> + * wakeup_source_sysfs_add - Add wakeup_source attributes to sysfs.
> + * @parent: Device given wakeup source is associated with (or NULL if virtual).
> + * @ws: Wakeup source to be added in sysfs.
> + */
> +int wakeup_source_sysfs_add(struct device *parent, struct wakeup_source *ws)
> +{
> + struct device *dev;
> + int id;
> +
> + id = ida_alloc(&wakeup_ida, GFP_KERNEL);
> + if (id < 0)
> + return id;
> + ws->id = id;
> +
> + dev = device_create_with_groups(wakeup_class, parent, MKDEV(0, 0), ws,
> + wakeup_source_groups, "ws%d",
I thought the name was going to still be 'wakeupN'?
> + ws->id);
> + if (IS_ERR(dev)) {
> + ida_free(&wakeup_ida, ws->id);
> + return PTR_ERR(dev);
> + }
> +
> + ws->dev = dev;
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(wakeup_source_sysfs_add);
> +
> +/**
> + * wakeup_source_sysfs_remove - Remove wakeup_source attributes from sysfs.
> + * @ws: Wakeup source to be removed from sysfs.
> + */
> +void wakeup_source_sysfs_remove(struct wakeup_source *ws)
> +{
> + device_unregister(ws->dev);
> + ida_simple_remove(&wakeup_ida, ws->id);
Should be ida_free()?
> +}
> +EXPORT_SYMBOL_GPL(wakeup_source_sysfs_remove);
> +
> +static int __init wakeup_sources_sysfs_init(void)
> +{
> + wakeup_class = class_create(THIS_MODULE, "wakeup");
> +
> + return PTR_ERR_OR_ZERO(wakeup_class);
> +}
> +
> +postcore_initcall(wakeup_sources_sysfs_init);
Style nitpick: Stick the initcall to the function it calls by dropping
the extra newline between them.
next prev parent reply other threads:[~2019-07-31 21:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 21:55 [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs Tri Vo
2019-07-31 21:59 ` Stephen Boyd [this message]
2019-07-31 22:16 ` Tri Vo
2019-07-31 22:17 ` Rafael J. Wysocki
2019-07-31 22:31 ` Tri Vo
2019-07-31 22:42 ` Rafael J. Wysocki
2019-07-31 22:58 ` Tri Vo
2019-07-31 23:10 ` Rafael J. Wysocki
2019-07-31 23:27 ` Tri Vo
2019-07-31 23:45 ` Stephen Boyd
2019-08-01 0:45 ` Stephen Boyd
2019-08-01 8:09 ` Rafael J. Wysocki
2019-08-01 15:31 ` Stephen Boyd
2019-08-01 17:21 ` Rafael J. Wysocki
2019-08-01 19:25 ` Stephen Boyd
2019-08-01 19:36 ` Greg Kroah-Hartman
2019-08-01 19:50 ` Tri Vo
2019-08-01 20:22 ` Stephen Boyd
2019-08-01 21:44 ` Tri Vo
2019-08-01 22:10 ` Rafael J. Wysocki
2019-08-03 22:40 ` Tri Vo
2019-08-05 8:32 ` Rafael J. Wysocki
2019-08-01 22:11 ` Stephen Boyd
2019-08-01 22:44 ` Tri Vo
2019-08-01 23:37 ` Stephen Boyd
2019-08-01 22:46 ` Rafael J. Wysocki
2019-08-01 23:40 ` Stephen Boyd
2019-07-31 23:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d420f45.1c69fb81.35877.3d86@mx.google.com \
--to=swboyd@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ravisadineni@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=sspatil@google.com \
--cc=trong@android.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).