Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Doug Smythies <dsmythies@telus.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Giovanni Gherdovich <ggherdovich@suse.cz>,
	Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2] cpuidle: Use nanoseconds as the unit of time
Date: Sun, 10 Nov 2019 18:24:04 +0100
Message-ID: <6163696.37NBKbymtj@kreacher> (raw)
In-Reply-To: <CAJZ5v0gZDJ2=PiiGw2mcCcVKBM2OyM1G9nRvJ+iWLFUQcXqZuw@mail.gmail.com>

On Sunday, November 10, 2019 5:48:21 PM CET Rafael J. Wysocki wrote:
> On Fri, Nov 8, 2019 at 6:04 PM Doug Smythies <dsmythies@telus.net> wrote:
> >
> > On 2019.11.08 01:45 Rafael J. Wysocki wrote:
> > > On Fri, Nov 8, 2019 at 9:45 AM Doug Smythies <dsmythies@telus.net> wrote:
> > >
> > ...
> > >> I have been running this v2 today, with both menu and teo
> > >> governors. Acquiring some baseline reference data to compare
> > >> to now. The menu governor response seems different (Supporting
> > >> information/graphs will come later).
> > >
> > > That may be good or bad, depending in what way it is different. :-)
> >
> > My thinking was that the differences should be minimal between
> > the baseline (linux-next as of 2019.11.07) and plus your two patches.
> > Because this was a change of units, but not functionality.
> > Such is the case with the teo governor, but not the menu governor.
> > I have not tried the ladder or haltpoll governors, and don't intend to.
> >
> > Now to attempt to isolate the issue in the code, which might take
> > considerable time.
> 
> Thanks!
> 
> It looks like I have overlooked a unit conversion in menu or done a
> unit conversion twice somewhere.

I have found a bug, which should be addressed by the patch below.

If it still doesn't reduce the discrepancy, we'll need to look further.

---
 drivers/cpuidle/governors/menu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/cpuidle/governors/menu.c
===================================================================
--- linux-pm.orig/drivers/cpuidle/governors/menu.c
+++ linux-pm/drivers/cpuidle/governors/menu.c
@@ -516,8 +516,8 @@ static void menu_update(struct cpuidle_d
 	new_factor -= new_factor / DECAY;
 
 	if (data->next_timer_ns > 0 && measured_ns < MAX_INTERESTING)
-		new_factor += RESOLUTION * div64_u64(measured_ns,
-						     data->next_timer_ns);
+		new_factor += div64_u64(RESOLUTION * measured_ns,
+					data->next_timer_ns);
 	else
 		/*
 		 * we were idle so long that we count it as a perfect




  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 10:30 [PATCH] " Rafael J. Wysocki
2019-11-07 14:25 ` [PATCH v2] " Rafael J. Wysocki
2019-11-08  1:44   ` Rafael J. Wysocki
2019-11-08  8:45     ` Doug Smythies
2019-11-08  9:45       ` Rafael J. Wysocki
2019-11-08 17:04         ` Doug Smythies
2019-11-10 16:48           ` Rafael J. Wysocki
2019-11-10 17:24             ` Rafael J. Wysocki [this message]
2019-11-10 18:09               ` Doug Smythies
2019-11-10 22:12                 ` Doug Smythies
2019-11-11 21:29                   ` Rafael J. Wysocki
2019-11-08  9:39     ` Peter Zijlstra

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6163696.37NBKbymtj@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=dsmythies@telus.net \
    --cc=ggherdovich@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git