From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C4DC43467 for ; Mon, 19 Oct 2020 18:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA8AE22365 for ; Mon, 19 Oct 2020 18:43:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WpwKycO2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730807AbgJSSnI (ORCPT ); Mon, 19 Oct 2020 14:43:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22812 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730464AbgJSSnI (ORCPT ); Mon, 19 Oct 2020 14:43:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603132986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AQQ/b9d7tZqO6GOijh8WddiJi4O517TeURbfqd1GNew=; b=WpwKycO2zeMWjWEPLeKvgsKPyXpO/t/JTgwFUml7KoK4Ra5NXyuhEu+IBZsRAnFl7gqwMX UEZo4xxbTkIw7dfCgLDayuV34LvnVvV9KdEeNgL7Fsxx/v1ZbNWFr5e+8KFaSeKvT2ayqh rnKJ6kE0FUtPGRS3i3/67Php3AH0ff8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-SsDw4ozOOuCgnBt_1n1CLg-1; Mon, 19 Oct 2020 14:43:04 -0400 X-MC-Unique: SsDw4ozOOuCgnBt_1n1CLg-1 Received: by mail-ej1-f69.google.com with SMTP id c11so229245ejp.9 for ; Mon, 19 Oct 2020 11:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AQQ/b9d7tZqO6GOijh8WddiJi4O517TeURbfqd1GNew=; b=VI9kuvt2gY6FBdZ3Yq1xpoGePrkv6QOEExMA5c6Nzdbsd9TvKul3hWKfYI/vUAzZYi NAQIRlk3MRGBnXvpaMWvgss9i9/bCuFv1eIGrZJtS0469l4YrL8g+P1YdfZz0941jaqz nbS+FTOWz3ckLCbYIwPvYi18ERkyXEtEIBffzPvI/aOI4OVBt/ZZMLLiLpcdAhQnUL/G ggdzyzdtXnip8UEQUOciTn3LqCp80LNHyFAbaQZ27/TxapZScCGjcgBgABdwxIxw1gUL OE+EakqHH3QnYAMy08QIim9wNjjAR7R72TXZRuCLmSBvfryAA/NG9m5197k+pymFyFxE O1ww== X-Gm-Message-State: AOAM5307RSJPwhwOxOEfZ3Uy+Rle7Fv36by5EEwraJguhbujfay6YIec Ywu+NWWwtoLgv4N2r2JkaQA6UCbXvBO/QMmkQIXlULmHM04tkQFQjOMatkdqMF0wY1adu0giReG x+44aOsmB040wB59j99Q= X-Received: by 2002:a17:906:8349:: with SMTP id b9mr1345623ejy.88.1603132983120; Mon, 19 Oct 2020 11:43:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2RYRkpUJLfaW0sZ5MlI4xMt/nfAxsXhCkRJDCLs7ZOkpypG4yuuYWUXP2NQNlNJQ1c4s9Iw== X-Received: by 2002:a17:906:8349:: with SMTP id b9mr1345597ejy.88.1603132982803; Mon, 19 Oct 2020 11:43:02 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id h4sm1075820ejk.71.2020.10.19.11.43.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2020 11:43:02 -0700 (PDT) Subject: Re: [RFC] Documentation: Add documentation for new performance_profile sysfs class (Also Re: [PATCH 0/4] powercap/dtpm: Add the DTPM framework) To: "Rafael J. Wysocki" Cc: Daniel Lezcano , Srinivas Pandruvada , Lukasz Luba , Linux Kernel Mailing List , Linux PM , "Zhang, Rui" , Bastien Nocera , Mark Pearson , "Limonciello, Mario" , Darren Hart , Andy Shevchenko , Mark Gross , Elia Devito , Benjamin Berg , "linux-acpi@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" References: <20201006122024.14539-1-daniel.lezcano@linaro.org> <8be66efd-7833-2c8a-427d-b0055c2f6ec1@linaro.org> <97e5368b-228d-eca1-85a5-b918dfcfd336@redhat.com> <63dfa6a1-0424-7985-7803-756c0c5cc4a5@redhat.com> <87d9a808-39d6-4949-c4f9-6a80d14a3768@redhat.com> <943531a7-74d6-7c7f-67bc-2645b3ba7b8a@redhat.com> <25d000cc-0c00-3b17-50f7-ca8de8b7a65b@redhat.com> From: Hans de Goede Message-ID: <64de7cf0-5d52-f8b3-426a-431fb3a6a6ec@redhat.com> Date: Mon, 19 Oct 2020 20:43:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On 10/18/20 2:31 PM, Rafael J. Wysocki wrote: > On Sun, Oct 18, 2020 at 11:41 AM Hans de Goede wrote: >> >> Hi, >> >> On 10/16/20 4:51 PM, Rafael J. Wysocki wrote: >>> On Fri, Oct 16, 2020 at 1:11 PM Hans de Goede wrote: >>>> >>>> >>>> >>>> Hi, >>>> >>>> On 10/14/20 5:42 PM, Rafael J. Wysocki wrote: >>>>> On Wed, Oct 14, 2020 at 4:06 PM Hans de Goede wrote: >>>>>> On 10/14/20 3:33 PM, Rafael J. Wysocki wrote: >>>> >>>> >>>> >>>>>>> First, a common place to register a DPTF system profile seems to be >>>>>>> needed and, as I said above, I wouldn't expect more than one such >>>>>>> thing to be present in the system at any given time, so it may be >>>>>>> registered along with the list of supported profiles and user space >>>>>>> will have to understand what they mean. >>>>>> >>>>>> Mostly Ack, I would still like to have an enum for DPTF system >>>>>> profiles in the kernel and have a single piece of code map that >>>>>> enum to profile names. This enum can then be extended as >>>>>> necessary, but I want to avoid having one driver use >>>>>> "Performance" and the other "performance" or one using >>>>>> "performance-balanced" and the other "balanced-performance", etc. >>>>>> >>>>>> With the goal being that new drivers use existing values from >>>>>> the enum as much as possible, but we extend it where necessary. >>>>> >>>>> IOW, just a table of known profile names with specific indices assigned to them. >>>> >>>> Yes. >>>> >>>>> This sounds reasonable. >>>>> >>>>>>> Second, irrespective of the above, it may be useful to have a >>>>>>> consistent way to pass performance-vs-power preference information >>>>>>> from user space to different parts of the kernel so as to allow them >>>>>>> to adjust their operation and this could be done with a system-wide >>>>>>> power profile attribute IMO. >>>>>> >>>>>> I agree, which is why I tried to tackle both things in one go, >>>>>> but as you said doing both in 1 API is probably not the best idea. >>>>>> So I believe we should park this second issue for now and revisit it >>>>>> when we find a need for it. >>>>> >>>>> Agreed. >>>>> >>>>>> Do you have any specific userspace API in mind for the >>>>>> DPTF system profile selection? >>>>> >>>>> Not really. >>>> >>>> So before /sys/power/profile was mentioned, but that seems more like >>>> a thing which should have a set of fixed possible values, iow that is >>>> out of scope for this discussion. >>> >>> Yes. >>> >>>> Since we all seem to agree that this is something which we need >>>> specifically for DPTF profiles maybe just add: >>>> >>>> /sys/power/dptf_current_profile (rw) >>>> /sys/power/dptf_available_profiles (ro) >>>> >>>> (which will only be visible if a dptf-profile handler >>>> has been registered) ? >>>> >>>> Or more generic and thus better (in case other platforms >>>> later need something similar) I think, mirror the: >>>> >>>> /sys/bus/cpu/devices/cpu#/cpufreq/energy_performance_* bits >>>> for a system-wide energy-performance setting, so we get: >>>> >>>> /sys/power/energy_performance_preference >>>> /sys/power/energy_performance_available_preferences >>> >>> But this is not about energy vs performance only in general, is it? >>> >>>> (again only visible when applicable) ? >>>> >>>> I personally like the second option best. >>> >>> But I would put it under /sys/firmware/ instead of /sys/power/ and I >>> would call it something like platform_profile (and >>> platform_profile_choices or similar). >> >> Currently we only have dirs under /sys/firmware: >> >> [hans@x1 ~]$ ls /sys/firmware >> acpi dmi efi memmap >> >> But we do have /sys/firmware/apci/pm_profile: >> >> Documentation/ABI/stable/sysfs-acpi-pmprofile >> >> What: /sys/firmware/acpi/pm_profile >> Date: 03-Nov-2011 >> KernelVersion: v3.2 >> Contact: linux-acpi@vger.kernel.org >> Description: The ACPI pm_profile sysfs interface exports the platform >> power management (and performance) requirement expectations >> as provided by BIOS. The integer value is directly passed as >> retrieved from the FADT ACPI table. >> Values: For possible values see ACPI specification: >> 5.2.9 Fixed ACPI Description Table (FADT) >> Field: Preferred_PM_Profile >> >> Currently these values are defined by spec: >> 0 Unspecified >> 1 Desktop >> 2 Mobile >> 3 Workstation >> 4 Enterprise Server >> ... >> >> Since all platforms which we need this for are ACPI based >> (and the involved interfaces are also all ACPI interfaces) >> how about: >> >> /sys/firmware/acpi/platform_profile >> /sys/firmware/acpi/platform_profile_choices >> >> ? >> >> I think this goes nice together with /sys/firmware/acpi/pm_profile >> although that is read-only and this is a read/write setting. >> >> Rafel, would: >> >> /sys/firmware/acpi/platform_profile >> /sys/firmware/acpi/platform_profile_choices >> >> work for you ? > > Yes, it would. Great. So I think hat means that we have the most important part for moving forward with this. So I guess the plan for this now looks something like this. 1. Rewrite my API docs RFC to update it for the new /sys/firmware/acpi/platform_profile[_choices] plan (should be easy and a bunch of stuff like the "type" bit can just be dropped) 2. Add code somewhere under drivers/acpi which allows code from else where to register itself as platform_profile handler/provider. Rafael, any suggestions / preference for where this should be added under drivers/acpi ? In a new .c file perhaps ? 3.1 Use the code from 2 to add support for platform-profile selection in thinkpad_acpi (something for me or Mark Pearson) to do 3.2 Use the code from 2 to add support for platform-profile selection to hp-wmi 3.3 (and to other drivers in the future). An open question is who will take care of 1. and 2. Mark (Pearson) do you feel up to this? or do you want me to take care of this? Regards, Hans