From: Keerthy <j-keerthy@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <rui.zhang@intel.com>, <robh+dt@kernel.org>,
<daniel.lezcano@linaro.org>, <amit.kucheria@verdurent.com>,
<t-kristo@ti.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>, <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: thermal: k3: Add VTM bindings documentation
Date: Wed, 19 Feb 2020 13:10:13 +0530 [thread overview]
Message-ID: <6895cf5e-9195-c914-f4ce-a83f36027dbf@ti.com> (raw)
In-Reply-To: <20200218202048.GA32279@bogus>
On 19/02/20 1:50 am, Rob Herring wrote:
> On Fri, 14 Feb 2020 12:04:40 +0530, Keerthy wrote:
>> Add VTM bindings documentation. In the Voltage Thermal
>> Management Module(VTM), K3 AM654 supplies a voltage
>> reference and a temperature sensor feature that are gathered in the band
>> gap voltage and temperature sensor (VBGAPTS) module. The band
>> gap provides current and voltage reference for its internal
>> circuits and other analog IP blocks. The analog-to-digital
>> converter (ADC) produces an output value that is proportional
>> to the silicon temperature.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>
>> Changes in v2:
>>
>> * Fixed make dt_binding_check errors.
>>
>> .../bindings/thermal/ti,am654-thermal.yaml | 57 +++++++++++++++++++
>> 1 file changed, 57 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
> Error: Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dts:21.41-42 syntax error
> FATAL ERROR: Unable to parse input tree
> scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dt.yaml' failed
> make[1]: *** [Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dt.yaml] Error 1
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1237882
> Please check and re-submit.
Rob,
I am using:
Tree: https//github.com/devicetree-org/dt-schema.git
branch: master
I have make dt_binding_check working for
Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dt.yaml
Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dts
is created without any errors :
https://pastebin.ubuntu.com/p/6MkMbKPpbY/
I did not see any errors as the other files erred out.
Today i tried with DT_SCHEMA_FILES option and then finally reproduced
the errors. It is a bit confusing for the first time users.
Now i have it compiled without any errors.
Posting v3 in a bit.
- Keerthy
>
next prev parent reply other threads:[~2020-02-19 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 6:34 [PATCH v2 0/4] thermal: k3: Add support for bandgap sensors Keerthy
2020-02-14 6:34 ` [PATCH v2 1/4] dt-bindings: thermal: k3: Add VTM bindings documentation Keerthy
2020-02-18 20:20 ` Rob Herring
2020-02-19 7:40 ` Keerthy [this message]
2020-02-20 20:28 ` Rob Herring
2020-02-24 1:12 ` J, KEERTHY
2020-02-14 6:34 ` [PATCH v2 2/4] thermal: k3: Add support for bandgap sensors Keerthy
2020-02-14 6:34 ` [PATCH v2 3/4] arm64: dts: ti: am654: Add thermal zones Keerthy
2020-02-14 6:34 ` [PATCH v2 4/4] arm64: dts: ti: am6: Add VTM node Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6895cf5e-9195-c914-f4ce-a83f36027dbf@ti.com \
--to=j-keerthy@ti.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).