Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm MSM8939 DT bindings

[Georgi Djakov <georgi.djakov@linaro.org>]

Hi Jun,

Thank you for the patch!

On 8/31/20 10:53, Jun Nie wrote:
> The Qualcomm MSM8939 platform has several bus fabrics that could be
> controlled and tuned dynamically according to the bandwidth demand.
> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
>  .../bindings/interconnect/qcom,msm8939.yaml   |  87 +++++++++++++++
>  .../dt-bindings/interconnect/qcom,msm8939.h   | 105 ++++++++++++++++++
>  2 files changed, 192 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml
>  create mode 100644 include/dt-bindings/interconnect/qcom,msm8939.h
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml
> new file mode 100644
> index 000000000000..99a827143723
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,msm8939.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm MSM8939 Network-On-Chip interconnect
> +
> +maintainers:
> +  - Jun Nie <jun.nie@linaro.org>
> +
> +description: |
> +   The Qualcomm MSM8939 interconnect providers support adjusting the
> +   bandwidth requirements between the various NoC fabrics.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,msm8939-bimc
> +      - qcom,msm8939-pcnoc
> +      - qcom,msm8939-snoc
> +      - qcom,msm8939-snoc-mm
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#interconnect-cells':
> +    const: 1
> +
> +  clock-names:
> +    items:
> +      - const: bus
> +      - const: bus_a
> +
> +  clocks:
> +    items:
> +      - description: Bus Clock
> +      - description: Bus A Clock
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#interconnect-cells'
> +  - clock-names
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +      #include <dt-bindings/clock/qcom,rpmcc.h>
> +
> +      bimc: interconnect@400000 {
> +              compatible = "qcom,msm8939-bimc";
> +              reg = <0x00400000 0x62000>;
> +              #interconnect-cells = <1>;
> +              clock-names = "bus", "bus_a";
> +              clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> +                       <&rpmcc RPM_SMD_BIMC_A_CLK>;
> +      };
> +
> +      pcnoc: interconnect@500000 {
> +              compatible = "qcom,msm8939-pcnoc";
> +              reg = <0x00500000 0x11000>;
> +              #interconnect-cells = <1>;
> +              clock-names = "bus", "bus_a";
> +              clocks = <&rpmcc RPM_SMD_PCNOC_CLK>,
> +                       <&rpmcc RPM_SMD_PCNOC_A_CLK>;
> +      };
> +
> +      snoc: interconnect@580000 {
> +              compatible = "qcom,msm8939-snoc";
> +              reg = <0x00580000 0x14000>;
> +              #interconnect-cells = <1>;
> +              clock-names = "bus", "bus_a";
> +              clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> +                       <&rpmcc RPM_SMD_SNOC_A_CLK>;
> +      };
> +
> +      snoc_mm: interconnect@580000 {
> +              compatible = "qcom,msm8939-snoc-mm";
> +              reg = <0x00580000 0x14000>;
> +              #interconnect-cells = <1>;
> +              clock-names = "bus", "bus_a";
> +	      clocks = <&rpmcc RPM_SMD_MMSSNOC_AHB_CLK>,
> +		       <&rpmcc RPM_SMD_MMSSNOC_AHB_A_CLK>;
> +      };

The above looks almost identical to what we already have in qcom,msm8916.yaml.
Recently Jonathan sent a patch to merge all rpmh platforms into a single file,
can we do the same thing here and have a common file for all SMD_RPM platforms?

Also don't forget to CC the devicetree mailing list in order to get the binding
reviewed.

Thanks,
Georgi