From: Sumit Gupta <sumitg@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: <rjw@rjwysocki.net>, <viresh.kumar@linaro.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<thierry.reding@gmail.com>, <mirq-linux@rere.qmqm.pl>,
<devicetree@vger.kernel.org>, <jonathanh@nvidia.com>,
<talho@nvidia.com>, <linux-pm@vger.kernel.org>,
<linux-tegra@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <bbasu@nvidia.com>,
<mperttunen@nvidia.com>, Sumit Gupta <sumitg@nvidia.com>
Subject: Re: [TEGRA194_CPUFREQ PATCH v5 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property
Date: Tue, 14 Jul 2020 17:13:47 +0530 [thread overview]
Message-ID: <70a0a8ee-b79a-2a05-5150-2ee0faaf2730@nvidia.com> (raw)
In-Reply-To: <20200713164214.GA341271@bogus>
> On Mon, Jul 13, 2020 at 07:36:46PM +0530, Sumit Gupta wrote:
>> To do frequency scaling on all CPUs within T194 CPU Complex, we need
>> to query BPMP for data on valid operating points. Document a compatible
>> string under 'cpus' node to represent the CPU Complex for binding drivers
>> like cpufreq which don't have their node or CPU Complex node to bind to.
>> Also, document a property to point to the BPMP device that can be queried
>> for all CPUs.
>
> The cpus.yaml binding documents what's in 'cpu' nodes, not 'cpus'
> node. AIUI, the latter is what you want. You should do your own schema
> file here.
>
Do you mean to change existing file name from 'cpus.yaml' to 'cpu.yaml'
and create new 'cpus.yaml' file?
I think it's better to incorporate the change in existing 'cpus.yaml'
file to keep both cpu@X and cpus node details together. Please suggest.
>>
>> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
>> ---
>> Documentation/devicetree/bindings/arm/cpus.yaml | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
>> index a018147..9b328e3 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
>> @@ -162,6 +162,7 @@ properties:
>> - nvidia,tegra132-denver
>> - nvidia,tegra186-denver
>> - nvidia,tegra194-carmel
>> + - nvidia,tegra194-ccplex
>
> Tegra194 has 2 different CPUs?
>
No, T194 SOC has homogeneous architecture with four clusters where each
cluster has two symmetric cores. 'nvidia,tegra194-carmel' compatible
string represents each cpu. 'nvidia,tegra194-ccplex' string represents
the CPU Complex to bind cpufreq driver. The change was done as per
discussion [1]
>> - qcom,krait
>> - qcom,kryo
>> - qcom,kryo260
>> @@ -255,6 +256,15 @@ properties:
>>
>> where voltage is in V, frequency is in MHz.
>>
>> + nvidia,bpmp:
>> + $ref: '/schemas/types.yaml#/definitions/phandle'
>> + description: |
>> + Specifies the bpmp node that needs to be queried to get
>> + operating point data for all CPUs.
>> +
>> + Optional for systems that have a "compatible"
>> + property value of "nvidia,tegra194-ccplex".
>> +
>> power-domains:
>> $ref: '/schemas/types.yaml#/definitions/phandle-array'
>> description:
>> @@ -340,6 +350,7 @@ required:
>>
>> dependencies:
>> rockchip,pmu: [enable-method]
>> + nvidia,bpmp: [compatible]
>>
>> examples:
>> - |
>> --
>> 2.7.4
>>
[1] https://marc.info/?l=linux-arm-kernel&m=158999171528418&w=2
next prev parent reply other threads:[~2020-07-14 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 14:06 [TEGRA194_CPUFREQ PATCH v5 0/4] Add cpufreq driver for Tegra194 Sumit Gupta
2020-07-13 14:06 ` [TEGRA194_CPUFREQ PATCH v5 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property Sumit Gupta
2020-07-13 16:42 ` Rob Herring
2020-07-14 11:43 ` Sumit Gupta [this message]
2020-07-14 13:46 ` Rob Herring
2020-07-14 16:07 ` [TEGRA194_CPUFREQ PATCH v6 1/4] dt-bindings: arm: Add NVIDIA Tegra194 CPU Complex binding Sumit Gupta
2020-07-14 20:47 ` Rob Herring
2020-07-15 10:22 ` Sumit Gupta
2020-07-14 16:14 ` [TEGRA194_CPUFREQ PATCH v5 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property Sumit Gupta
2020-07-13 14:06 ` [TEGRA194_CPUFREQ PATCH v5 2/4] arm64: tegra: " Sumit Gupta
2020-07-13 14:06 ` [TEGRA194_CPUFREQ PATCH v5 3/4] cpufreq: Add Tegra194 cpufreq driver Sumit Gupta
2020-07-15 11:16 ` Viresh Kumar
2020-07-15 12:31 ` Sumit Gupta
2020-07-13 14:06 ` [TEGRA194_CPUFREQ PATCH v5 4/4] soc/tegra: cpufreq: select cpufreq for Tegra194 Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70a0a8ee-b79a-2a05-5150-2ee0faaf2730@nvidia.com \
--to=sumitg@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).