From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nikita Travkin <nikita@trvn.ru>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: supply: Add Acer Aspire 1 EC
Date: Thu, 7 Dec 2023 17:56:42 +0100 [thread overview]
Message-ID: <75c9fe9f-a014-4ad9-a773-91555309c883@linaro.org> (raw)
In-Reply-To: <20231207-aspire1-ec-v1-1-ba9e1c227007@trvn.ru>
On 07/12/2023 12:20, Nikita Travkin wrote:
> Add binding for the EC found in the Acer Aspire 1 laptop.
>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
> .../bindings/power/supply/acer,aspire1-ec.yaml | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> +
> + acer,media-keys-on-top:
> + description: Configure the keyboard layout to use media features of
> + the fn row when the fn key is not pressed. The firmware may choose
> + to add this property when user selects the fn mode in the firmware
> + setup utility.
> + type: boolean
> +
> + connector:
> + $ref: /schemas/connector/usb-connector.yaml#
> +
> + properties:
> + reg:
> + maxItems: 1
You cannot have it... Add it to the example and see the results.
> +
> + unevaluatedProperties: false
It should be fine to drop this as well, so you don't need anything else
than $ref.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-07 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 11:20 [PATCH 0/3] power: supply: Acer Aspire 1 embedded controller Nikita Travkin
2023-12-07 11:20 ` [PATCH 1/3] dt-bindings: power: supply: Add Acer Aspire 1 EC Nikita Travkin
2023-12-07 16:56 ` Krzysztof Kozlowski [this message]
2023-12-07 17:21 ` Nikita Travkin
2023-12-07 11:20 ` [PATCH 2/3] power: supply: Add Acer Aspire 1 embedded controller driver Nikita Travkin
2023-12-07 19:24 ` Konrad Dybcio
2023-12-08 10:31 ` Nikita Travkin
2023-12-07 11:20 ` [PATCH 3/3] arm64: dts: qcom: acer-aspire1: Add embedded controller Nikita Travkin
2023-12-07 19:25 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75c9fe9f-a014-4ad9-a773-91555309c883@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).