From: Pratik Sampat <psampat@linux.ibm.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
rjw@rjwysocki.net, daniel.lezcano@linaro.org, mpe@ellerman.id.au,
benh@kernel.crashing.org, paulus@samba.org,
srivatsa@csail.mit.edu, shuah@kernel.org, ego@linux.vnet.ibm.com,
svaidy@linux.ibm.com, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] selftest/cpuidle: Add support for cpuidle latency measurement
Date: Tue, 7 Jul 2020 21:23:46 +0530 [thread overview]
Message-ID: <77f3c7a1-bfb0-d6ff-67e1-1854e390016e@linux.ibm.com> (raw)
In-Reply-To: <bf016b30-18e6-69fd-afc5-5319ebd6a890@linuxfoundation.org>
[..snip..]
>> +
>> +ins_mod()
>> +{
>> + if [ ! -f "$MODULE" ]; then
>> + printf "$MODULE module does not exist. Exitting\n"
>> + exit 2
>
> Please use ksft_skip code to indicate the test is being skipped.
>
Sure thing I'll use ksft_skip exit code instead.
>> + fi
>> + printf "Inserting $MODULE module\n\n"
>> + insmod $MODULE
>> + if [ $? != 0 ]; then
>> + printf "Insmod $MODULE failed\n"
>> + exit 2
>
> This is fine since you expect to be able to load the module.
>
Thanks for the review.
Pratik
[..snip..]
>>
>
> thanks,
> -- Shuah
prev parent reply other threads:[~2020-07-07 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 15:29 [PATCH 0/2] Selftest for cpuidle latency measurement Pratik Rajesh Sampat
2020-07-07 15:29 ` [PATCH 1/2] cpuidle: Trace IPI based and timer based wakeup latency from idle states Pratik Rajesh Sampat
2020-07-07 15:29 ` [PATCH 2/2] selftest/cpuidle: Add support for cpuidle latency measurement Pratik Rajesh Sampat
2020-07-07 15:40 ` Shuah Khan
2020-07-07 15:53 ` Pratik Sampat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77f3c7a1-bfb0-d6ff-67e1-1854e390016e@linux.ibm.com \
--to=psampat@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=daniel.lezcano@linaro.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rjw@rjwysocki.net \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=srivatsa@csail.mit.edu \
--cc=svaidy@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).