From: Chanwoo Choi <cw00.choi@samsung.com>
To: Leonard Crestez <leonard.crestez@nxp.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Matthias Kaehlcke" <mka@chromium.org>,
"Adam Ford" <aford173@gmail.com>,
"Artur Świgoń" <a.swigon@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Viresh Kumar" <vireshk@kernel.org>,
linux-imx@nxp.com, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PM / devfreq: Fix handling dev_pm_qos_remove_request result
Date: Thu, 12 Mar 2020 12:30:42 +0900 [thread overview]
Message-ID: <780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com> (raw)
In-Reply-To: <ea4c8b53f2a045116a5f70e24374ce62c85f0b81.1583982882.git.leonard.crestez@nxp.com>
On 3/12/20 12:15 PM, Leonard Crestez wrote:
> The dev_pm_qos_remove_request function can return 1 if
> "aggregated constraint value has changed" so only negative values should
> be reported as errors.
>
> Fixes: 27dbc542f651 ("PM / devfreq: Use PM QoS for sysfs min/max_freq")
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> drivers/devfreq/devfreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 5c481ad1cfc7..6fecd11dafdd 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -703,17 +703,17 @@ static void devfreq_dev_release(struct device *dev)
> dev_warn(dev->parent,
> "Failed to remove min_freq notifier: %d\n", err);
>
> if (dev_pm_qos_request_active(&devfreq->user_max_freq_req)) {
> err = dev_pm_qos_remove_request(&devfreq->user_max_freq_req);
> - if (err)
> + if (err < 0)
> dev_warn(dev->parent,
> "Failed to remove max_freq request: %d\n", err);
> }
> if (dev_pm_qos_request_active(&devfreq->user_min_freq_req)) {
> err = dev_pm_qos_remove_request(&devfreq->user_min_freq_req);
> - if (err)
> + if (err < 0)
> dev_warn(dev->parent,
> "Failed to remove min_freq request: %d\n", err);
> }
>
> if (devfreq->profile->exit)
>
Looks good to me.
But, It doesn't contain the stable mailing list.
Please add stable mailing list to Cc and resend it.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2020-03-12 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200312031520epcas1p3ae8085a7d85da5b41776136f61ad40a3@epcas1p3.samsung.com>
2020-03-12 3:15 ` [PATCH] PM / devfreq: Fix handling dev_pm_qos_remove_request result Leonard Crestez
2020-03-12 3:30 ` Chanwoo Choi [this message]
2020-03-12 6:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.swigon@samsung.com \
--cc=aford173@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).