From: Dmitry Osipenko <digetx@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH] power: supply: smb347-charger: Drop unused include
Date: Sat, 29 May 2021 18:28:30 +0300 [thread overview]
Message-ID: <7ee3cac3-490d-74b2-00c0-8db5e4ad246a@gmail.com> (raw)
In-Reply-To: <20210529001902.468060-1-linus.walleij@linaro.org>
29.05.2021 03:19, Linus Walleij пишет:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but not using any symbols from it. Delete the include.
>
> Cc: David Heidelberg <david@ixit.cz>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/power/supply/smb347-charger.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c
> index 3376f42d46c3..df240420f2de 100644
> --- a/drivers/power/supply/smb347-charger.c
> +++ b/drivers/power/supply/smb347-charger.c
> @@ -10,7 +10,6 @@
>
> #include <linux/delay.h>
> #include <linux/err.h>
> -#include <linux/gpio.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/init.h>
>
Good catch, GPIO usage was gone with the removal of legacy platform data
from the driver, which Sebastian did not so long time ago.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2021-05-29 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 0:19 [PATCH] power: supply: smb347-charger: Drop unused include Linus Walleij
2021-05-29 15:28 ` Dmitry Osipenko [this message]
2021-05-29 18:34 ` David Heidelberg
2021-06-03 17:05 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee3cac3-490d-74b2-00c0-8db5e4ad246a@gmail.com \
--to=digetx@gmail.com \
--cc=david@ixit.cz \
--cc=linus.walleij@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).