From: Kevin Hilman <khilman@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/6] Add support of New Amlogic temperature sensor for G12 SoCs
Date: Wed, 21 Aug 2019 14:30:17 -0700 [thread overview]
Message-ID: <7himqq9pg6.fsf@baylibre.com> (raw)
In-Reply-To: <7hd0hd3mme.fsf@baylibre.com>
Kevin Hilman <khilman@baylibre.com> writes:
> Guillaume La Roque <glaroque@baylibre.com> writes:
>
>> This patchs series add support of New Amlogic temperature sensor and minimal
>> thermal zone for SEI510 and ODROID-N2 boards.
>>
>> First implementation was doing on IIO[1] but after comments i move on thermal framework.
>> Formulas and calibration values come from amlogic.
>>
>> Changes since v2:
>> - fix yaml documention
>> - remove unneeded status variable for temperature-sensor node
>> - rework driver after Martin review
>> - add some information in commit message
>>
>> Changes since v1:
>> - fix enum vs const in documentation
>> - fix error with thermal-sensor-cells value set to 1 instead of 0
>> - add some dependencies needed to add cooling-maps
>>
>> Dependencies :
>> - patch 3,4 & 5: depends on Neil's patch and series :
>> - missing dwc2 phy-names[2]
>> - patchsets to add DVFS on G12a[3] which have deps on [4] and [5]
>>
>> [1] https://lore.kernel.org/linux-amlogic/20190604144714.2009-1-glaroque@baylibre.com/
>> [2] https://lore.kernel.org/linux-amlogic/20190625123647.26117-1-narmstrong@baylibre.com/
>> [3] https://lore.kernel.org/linux-amlogic/20190729132622.7566-1-narmstrong@baylibre.com/
>> [4] https://lore.kernel.org/linux-amlogic/20190731084019.8451-5-narmstrong@baylibre.com/
>> [5] https://lore.kernel.org/linux-amlogic/20190729132622.7566-3-narmstrong@baylibre.com/
>
> Thank you for the detailed list of dependencies! Much appreciated.
>
> With all the deps, I tested this on sei510 and odroid-n2, and basic
> functionality seems to work.
>
> As discussed off-list: it would be nice to have an example of how
> cpufreq could be used as a cooling device for hot temperatures. The
> vendor kernel has some trip points that could be included as examples,
> or even included as extra patches.
>
> Also the driver patch is missing the two main thermal maintainers, so
> please resend at least the driver and bindings including them.
Forgot to add...
Tested-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2019-08-21 21:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 13:05 [PATCH v3 0/6] Add support of New Amlogic temperature sensor for G12 SoCs Guillaume La Roque
2019-08-06 13:05 ` [PATCH v3 1/6] dt-bindings: thermal: Add DT bindings documentation for Amlogic Thermal Guillaume La Roque
2019-08-21 19:31 ` Rob Herring
2019-08-06 13:05 ` [PATCH v3 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs Guillaume La Roque
2019-08-11 15:43 ` Martin Blumenstingl
2019-08-06 13:05 ` [PATCH v3 3/6] arm64: dts: amlogic: g12: add temperature sensor Guillaume La Roque
2019-08-06 13:05 ` [PATCH v3 4/6] arm64: dts: meson: sei510: Add minimal thermal zone Guillaume La Roque
2019-08-06 19:24 ` Martin Blumenstingl
2019-08-06 13:05 ` [PATCH v3 5/6] arm64: dts: amlogic: odroid-n2: add " Guillaume La Roque
2019-08-06 19:25 ` Martin Blumenstingl
2019-08-06 13:05 ` [PATCH v3 6/6] MAINTAINERS: add entry for Amlogic Thermal driver Guillaume La Roque
2019-08-10 0:11 ` [PATCH v3 0/6] Add support of New Amlogic temperature sensor for G12 SoCs Kevin Hilman
2019-08-21 21:30 ` Kevin Hilman [this message]
2019-08-14 12:24 ` Christian Hewitt
2019-08-21 21:19 ` guillaume La Roque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7himqq9pg6.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).