From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Mark Brown <broonie@kernel.org>
Cc: matti.vaittinen@fi.rohmeurope.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
arm-soc <linux-arm-kernel@lists.infradead.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: regulator: BD71837 PMIC resume during noirq phase?
Date: Tue, 14 Jun 2022 11:57:18 +0200 [thread overview]
Message-ID: <8024d9e3b885941084740cb0fb2fc9117acdd069.camel@puri.sm> (raw)
In-Reply-To: <YqhSXuHMR6kuFu/A@sirena.org.uk>
Am Dienstag, dem 14.06.2022 um 10:18 +0100 schrieb Mark Brown:
> On Tue, Jun 14, 2022 at 11:06:06AM +0200, Martin Kepplinger wrote:
>
> > and regulator_enable() in imx-pgc is called from
> > genpd_resume_noirq().
> >
> > At this point, does any workaround or fix come to your mind I could
> > test? I guess i2c needs to be resumed too...
> >
> > Why does power domain only implement resume_noirq? How could I
> > untangle
> > this?
>
> Indeed - if a power domain is controlling regulators then I'd not
> expect
> things to go well if it tries to resume without interrupts, there
> will
> be some things that can be done purely with GPIOs but that's
> depending
> on the hardware having wired things up that way and the operations
> needed by the power domain mapping well onto what can be done with
> GPIOs.
and what's the danger when resuming power domains later?:
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2062,8 +2062,8 @@ int pm_genpd_init(struct generic_pm_domain
*genpd,
genpd->domain.ops.runtime_suspend = genpd_runtime_suspend;
genpd->domain.ops.runtime_resume = genpd_runtime_resume;
genpd->domain.ops.prepare = genpd_prepare;
- genpd->domain.ops.suspend_noirq = genpd_suspend_noirq;
- genpd->domain.ops.resume_noirq = genpd_resume_noirq;
+ genpd->domain.ops.suspend = genpd_suspend_noirq;
+ genpd->domain.ops.resume = genpd_resume_noirq;
genpd->domain.ops.freeze_noirq = genpd_freeze_noirq;
genpd->domain.ops.thaw_noirq = genpd_thaw_noirq;
genpd->domain.ops.poweroff_noirq = genpd_poweroff_noirq;
thanks for taking the time,
martin
next prev parent reply other threads:[~2022-06-14 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:06 regulator: BD71837 PMIC resume during noirq phase? Martin Kepplinger
2022-06-14 9:18 ` Mark Brown
2022-06-14 9:47 ` Vaittinen, Matti
2022-06-14 9:57 ` Martin Kepplinger [this message]
2022-06-14 10:16 ` Mark Brown
2022-07-11 9:52 ` Martin Kepplinger
2022-06-14 9:38 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8024d9e3b885941084740cb0fb2fc9117acdd069.camel@puri.sm \
--to=martin.kepplinger@puri.sm \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).