From: Ezequiel Garcia <ezequiel@collabora.com>
To: cwchoi00@gmail.com
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
kernel@collabora.com, Linux PM list <linux-pm@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v2] PM / devfreq: Fix kernel oops on governor module load
Date: Wed, 10 Jul 2019 15:30:23 -0300 [thread overview]
Message-ID: <85fb2cb764961845a32b8af51e8c6ccebf60c703.camel@collabora.com> (raw)
In-Reply-To: <CAGTfZH3WenT=t6bFWy7sZCKhcPaMBrzTs=00DeSFU-0Sm-qS=A@mail.gmail.com>
Hello Chanwoo,
On Sat, 2019-06-22 at 19:46 +0900, Chanwoo Choi wrote:
> Hi,
>
> 2019년 6월 22일 (토) 오전 6:42, Ezequiel Garcia <ezequiel@collabora.com>님이 작성:
> > A bit unexpectedly (but still documented), request_module may
> > return a positive value, in case of a modprobe error.
> > This is currently causing issues in the devfreq framework.
> >
> > When a request_module exits with a positive value, we currently
> > return that via ERR_PTR. However, because the value is positive,
> > it's not a ERR_VALUE proper, and is therefore treated as a
> > valid struct devfreq_governor pointer, leading to a kernel oops.
> >
> > Fix this by returning -EINVAL if request_module returns a positive
> > value.
> >
> > Fixes: b53b0128052ff ("PM / devfreq: Fix static checker warning in try_then_request_governor")
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> > Changes from v1:
> > * Rework the fix as suggested by Enric and Chanwoo,
> > handling the return vaue.
> > ---
> > drivers/devfreq/devfreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index 6b6991f0e873..258f70c1e48f 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -257,7 +257,7 @@ static struct devfreq_governor *try_then_request_governor(const char *name)
> > /* Restore previous state before return */
> > mutex_lock(&devfreq_list_lock);
> > if (err)
> > - return ERR_PTR(err);
> > + return (err < 0) ? ERR_PTR(err) : ERR_PTR(-EINVAL);
> >
> > governor = find_devfreq_governor(name);
> > }
>
> Thanks you for fix-up.
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> But, you are missing the stable mailing list. In order to apply this
> fix-up patch,\
> you have to send it to stable mailing list. Please send it.
>
>
If I understand correctly, you or any of the devfreq maintainer
can simply add a Cc: stable@vger.kernel.org tag.
This is documented as Option 1 in stable-kernel-rules.rst.
The Acked-by and Reviewed-by tags need to be collected anyway :-)
Thanks!
Eze
next prev parent reply other threads:[~2019-07-10 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 21:39 [PATCH v2] PM / devfreq: Fix kernel oops on governor module load Ezequiel Garcia
2019-06-22 10:46 ` Chanwoo Choi
2019-07-10 18:30 ` Ezequiel Garcia [this message]
2019-07-11 2:49 ` Chanwoo Choi
[not found] ` <CGME20190621214003epcas5p4682d7d258b3ec2ae92521111fe8864ab@epcms1p2>
2019-06-24 7:37 ` MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85fb2cb764961845a32b8af51e8c6ccebf60c703.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=kernel@collabora.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).