From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F48C6FD1F for ; Wed, 22 Mar 2023 08:33:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230222AbjCVIdW (ORCPT ); Wed, 22 Mar 2023 04:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbjCVIdS (ORCPT ); Wed, 22 Mar 2023 04:33:18 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC122C646 for ; Wed, 22 Mar 2023 01:33:13 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id eg48so69440173edb.13 for ; Wed, 22 Mar 2023 01:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679473991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ivtJ17SntBidQVkbcFjsY9yFoBVm7miDvhKcewrMLjc=; b=tcV0JQhU7AvOb77j4GXs7g7T2t/Rfg5n/93Am0kLkPiZishIGYx+7eDt7cNSsK5UlZ UhkXDQ4Bk5uA1ZXMFxe/xcY5VY4n03jUazDpfNUCCdu5O+GJ3xlpKxHS03+qCK14TKf4 qrTOyVf8ddJah+gkUXs/K+HUJ3e/3SH13WXOFCW2EgOGYn2KwgR45mIHz1O8Xro7Lot6 aiuJaj4uosmTdK4KGl6IkPgIocQ8syBMrpfsdLn6I4bOE6Xd4ikFmb1xTMWXCFyso2qy 0bOKb+ayZ/8jWELoOLSRnVxkNoP7BzxxXVECy2R73MBwExTDblRZLEfxOIItiush8hwQ rw0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679473991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ivtJ17SntBidQVkbcFjsY9yFoBVm7miDvhKcewrMLjc=; b=yDWht9tkHOzMDjI649J94AAxt/HD+JSz0LUIAhojwDCZP0LzeT63I+VBW2M8YjvInt NGL/mZb5OIvdxnxAZByKBud4vLgr8YrxjkgpCvyb0belBojP2CJTGE9BiJxmsuOauk6V 03iYUdL4gAraMJSLhu1jguBag8qq3L9UE9p5m3E5NiFME+t7T5FPs8xIA3tZ32PglzU8 NzwqzGjaxWoQZqn5k54KQBhHW67X3/YgkfgXc1ZH9YjMu+dYYntSsJpEkcJS2qQ/9D6k PYUpCc5NxsM7wdJoKo7sWTNWZso23fBJwYbfxEl+xScl8ngwRIj+vzhUHnhG9rpNfV3J COgQ== X-Gm-Message-State: AO0yUKUBoeT4WNjTX1OLp1bfsh/hXebaZ/cV0TrjMTWEE8fTdaHNiGHd 6D6W5D76y/s2+J+llOSVxDIUUw== X-Google-Smtp-Source: AK7set8iZr+rJsRD1W2LuqUuGK3/1SRsoc0lc7QCOzTHtqZ2RaPZ0AERgD8nfqF4UPk2ssYZKZU3bg== X-Received: by 2002:a05:6402:c2:b0:501:c120:6e90 with SMTP id i2-20020a05640200c200b00501c1206e90mr5809096edu.3.1679473991638; Wed, 22 Mar 2023 01:33:11 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:5050:151b:e755:1c6? ([2a02:810d:15c0:828:5050:151b:e755:1c6]) by smtp.gmail.com with ESMTPSA id e23-20020a50d4d7000000b004bf28bfc9absm7198839edj.11.2023.03.22.01.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 01:33:11 -0700 (PDT) Message-ID: <86d56386-fe9e-320d-edd3-5b288520e92a@linaro.org> Date: Wed, 22 Mar 2023 09:33:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 7/8] dt-bindings: mfd: max77658: Add ADI MAX77658 Content-Language: en-US To: Zeynep Arslanbenzer , lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sre@kernel.org, lgirdwood@gmail.com, broonie@kernel.org Cc: Nurettin.Bolucu@analog.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <20230322055628.4441-1-Zeynep.Arslanbenzer@analog.com> <20230322055628.4441-8-Zeynep.Arslanbenzer@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20230322055628.4441-8-Zeynep.Arslanbenzer@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 22/03/2023 06:56, Zeynep Arslanbenzer wrote: > Add ADI MAX77658 devicetree document. > > Signed-off-by: Nurettin Bolucu > Signed-off-by: Zeynep Arslanbenzer > --- > .../devicetree/bindings/mfd/adi,max77658.yaml | 199 ++++++++++++++++++ > 1 file changed, 199 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77658.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/adi,max77658.yaml b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml > new file mode 100644 > index 000000000000..6edb59e8f446 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml > @@ -0,0 +1,199 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,max77658.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77643/MAX77654/MAX77658/MAX77659 PMIC from ADI > + > +maintainers: > + - Nurettin Bolucu > + - Zeynep Arslanbenzer > + > +description: | > + MAX77643, MAX77654, MAX77658 and MAX77659 devices are a family of ADI PMICs > + providing battery charging and power supply solutions for > + low-power applications. > + > + MAX77643 is a Power Management IC with 1 LDO regulator. > + > + MAX77654 is a Power Management IC with 2 LDO regulators and 1 charger. > + > + MAX77658 is a Power Management IC with 2 LDO regulators, 1 charger > + and 1 fuel gauge. > + > + MAX77659 is a Power Management IC with 1 LDO regulator and 1 charger. > + > +properties: > + compatible: > + enum: > + - adi,max77643 > + - adi,max77654 > + - adi,max77658 > + - adi,max77659 > + > + reg: > + description: I2C address of the PMIC > + items: > + - enum: [0x40, 0x48] > + > + interrupts: > + maxItems: 1 > + > + charger: > + $ref: /schemas/power/supply/adi,max77658-charger.yaml > + > + fuel-gauge: > + $ref: /schemas/power/supply/adi,max77658-battery.yaml > + > + regulators: > + $ref: /schemas/regulator/adi,max77658-regulator.yaml > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - adi,max77643 > + - adi,max77654 > + - adi,max77658 > + > + then: > + properties: > + reg: > + items: > + - const: 0x48 > + > + else: > + properties: > + reg: > + items: > + - const: 0x40 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + battery: battery-cell { > + compatible = "simple-battery"; > + alert-celsius = <0 100>; > + constant-charge-current-max-microamp = <15000>; > + }; > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic@48 { > + compatible = "adi,max77643"; > + reg = <0x48>; > + interrupt-parent = <&gpio>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + regulators { > + LDO0 { > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + }; > + }; Four examples is too much. Keep only some relevant one or two. Best regards, Krzysztof