From: Chanwoo Choi <cw00.choi@samsung.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: kernel@collabora.com, linux-pm@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH 2/2] PM / devfreq: Sanitize prints
Date: Fri, 21 Jun 2019 11:53:39 +0900 [thread overview]
Message-ID: <8b6d523e-7bb3-c705-7393-64d9b5fde900@samsung.com> (raw)
In-Reply-To: <c6bc6c42a29d9cf996dc82880ee01b806b0705c2.camel@collabora.com>
Hi,
On 19. 6. 20. 오후 11:41, Ezequiel Garcia wrote:
> On Thu, 2019-06-20 at 16:23 +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> Frankly, I don't like the existing 'DEVFREQ: ' prefix
>> because it is not used on all error log and it is not necessary.
>>
>> Instead of this patch, I just prefer to delete the 'DEVFREQ: ' prefix
>>
>
> Hm, I have to disagree. Having naked pr_{} with just the __func__
> reducess logging consistency.
Actually, it is minor clean-up and there are no any benefits.
As I said, 'DEVFREQ: ' prefix was not used on all devfreq log.
If you don't agree to remove 'DEVFREQ: ', no problem.
IMO, just better to keep the current style without
any addition changes.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-06-21 2:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190605190147epcas1p3e74fba524dfcfc87f7ce3c9569ffaa3f@epcas1p3.samsung.com>
2019-06-05 19:00 ` [PATCH 1/2] PM / devfreq: Fix governor module load failure Ezequiel Garcia
2019-06-05 19:00 ` [PATCH 2/2] PM / devfreq: Sanitize prints Ezequiel Garcia
2019-06-20 7:23 ` Chanwoo Choi
2019-06-20 14:41 ` Ezequiel Garcia
2019-06-21 2:53 ` Chanwoo Choi [this message]
2019-06-05 21:46 ` [PATCH 1/2] PM / devfreq: Fix governor module load failure Enric Balletbo Serra
2019-06-06 13:42 ` Ezequiel Garcia
2019-06-06 13:48 ` Enric Balletbo i Serra
2019-06-20 7:59 ` Chanwoo Choi
2019-06-20 8:04 ` Chanwoo Choi
2019-06-20 15:31 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6d523e-7bb3-c705-7393-64d9b5fde900@samsung.com \
--to=cw00.choi@samsung.com \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=kernel@collabora.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).