From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] cpufreq: Panic if policy is active in cpufreq_policy_free()
Date: Thu, 26 May 2022 17:21:20 +0530 [thread overview]
Message-ID: <8c3d50faf8811e86136fb3f9c459e43fc3c50bc0.1653565641.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1653565641.git.viresh.kumar@linaro.org>
With the new design in place, show/store callbacks check if the policy
is active or not before proceeding further and cpufreq_policy_free()
must be called after emptying policy->cpus mask, i.e. inactive policy.
Lets make sure we don't get a bug around this later and catch this early
by putting a BUG_ON() within cpufreq_policy_free().
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index e24aa5d4bca5..53d163a84e06 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1284,6 +1284,12 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy)
unsigned long flags;
int cpu;
+ /*
+ * The callers must ensure the policy is inactive by now, to avoid any
+ * races with show()/store() callbacks.
+ */
+ BUG_ON(!policy_is_inactive(policy));
+
/* Remove policy from list */
write_lock_irqsave(&cpufreq_driver_lock, flags);
list_del(&policy->policy_list);
--
2.31.1.272.g89b43f80a514
next prev parent reply other threads:[~2022-05-26 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 11:51 [PATCH 0/3] cpufreq: Minor cleanups Viresh Kumar
2022-05-26 11:51 ` [PATCH 1/3] cpufreq: Optimize cpufreq_show_cpus() Viresh Kumar
2022-05-26 11:51 ` Viresh Kumar [this message]
2022-05-27 3:53 ` [PATCH V2 2/3] cpufreq: Panic if policy is active in cpufreq_policy_free() Viresh Kumar
2022-06-14 13:59 ` Rafael J. Wysocki
2022-06-15 4:59 ` Viresh Kumar
2022-07-06 13:49 ` Rafael J. Wysocki
2022-07-06 15:23 ` Viresh Kumar
2022-07-06 15:34 ` Rafael J. Wysocki
[not found] ` <20220527031320.GA10419@xsang-OptiPlex-9020>
2022-05-27 3:54 ` [cpufreq] a6cb305191: kernel_BUG_at_drivers/cpufreq/cpufreq.c Viresh Kumar
2022-05-26 11:51 ` [PATCH 3/3] cpufreq: Drop unnecessary cpus locking from store() Viresh Kumar
2022-06-14 13:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c3d50faf8811e86136fb3f9c459e43fc3c50bc0.1653565641.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).