From: ChiaEn Wu <peterwu.pub@gmail.com>
To: Ren Zhijie <renzhijie2@huawei.com>,
sre@kernel.org, andy.shevchenko@gmail.com, chiaen_wu@richtek.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency
Date: Thu, 22 Sep 2022 17:58:12 +0800 [thread overview]
Message-ID: <904af4cb-147f-a7ba-63e3-c27cad0350f2@gmail.com> (raw)
In-Reply-To: <20220922023337.15609-1-renzhijie2@huawei.com>
On 9/22/2022 10:33 AM, Ren Zhijie wrote:
> If CONFIG_IIO is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
> will be failed, like this:
>
> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_mivr_dwork_func':
> mt6370-charger.c:(.text+0x670): undefined reference to `iio_read_channel_processed'
> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_probe':
> mt6370-charger.c:(.text+0xb43): undefined reference to `devm_iio_channel_get_all'
> make: *** [vmlinux] Error 1
>
> To fix this build error, add depends on IIO to config CHARGER_MT6370 dependency.
>
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
> drivers/power/supply/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 591deb82e2c6..62111f4bb093 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -623,6 +623,7 @@ config CHARGER_MT6370
> tristate "MediaTek MT6370 Charger Driver"
> depends on MFD_MT6370
> depends on REGULATOR
> + depends on IIO
> select LINEAR_RANGES
> help
> Say Y here to enable MT6370 Charger Part.
Hi Ren,
Thanks for catching this!
Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
--
Best Regards,
ChiaEn Wu
next prev parent reply other threads:[~2022-09-22 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 2:33 [PATCH -next] power: supply: mt6370: Fix Kconfig dependency Ren Zhijie
2022-09-22 9:58 ` ChiaEn Wu [this message]
2022-10-09 13:34 ` Ren Zhijie
2022-10-11 2:02 ` ChiaEn Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=904af4cb-147f-a7ba-63e3-c27cad0350f2@gmail.com \
--to=peterwu.pub@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=chiaen_wu@richtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=renzhijie2@huawei.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).