Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Ricardo Rivera-Matos <r-rivera-matos@ti.com>, <sre@kernel.org>,
	<pali@kernel.org>, <robh@kernel.org>
Cc: <afd@ti.com>, <linux-pm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<sspatil@android.com>, Guru Das Srinagesh <gurus@codeaurora.org>
Subject: Re: [PATCH v14 1/4] power_supply: Add additional health properties to the header
Date: Wed, 1 Jul 2020 11:39:33 -0500
Message-ID: <938bd51f-0551-38f0-c17c-19c7b42ec411@ti.com> (raw)
In-Reply-To: <20200630215426.26450-2-r-rivera-matos@ti.com>

Sebastian

On 6/30/20 4:54 PM, Ricardo Rivera-Matos wrote:
> From: Dan Murphy <dmurphy@ti.com>
>
> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
>
> HEALTH_WARM, HEALTH_COOL, and HEALTH_HOT properties are taken
> from JEITA specification JISC8712:2015
>
> Acked-by: Andrew F. Davis <afd@ti.com>
> Tested-by: Guru Das Srinagesh <gurus@codeaurora.org>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>   Documentation/ABI/testing/sysfs-class-power | 3 ++-
>   drivers/power/supply/power_supply_sysfs.c   | 3 +++
>   include/linux/power_supply.h                | 3 +++
>   3 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 216d61a22f1e..40213c73bc9c 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -205,7 +205,8 @@ Description:
>   		Valid values: "Unknown", "Good", "Overheat", "Dead",
>   			      "Over voltage", "Unspecified failure", "Cold",
>   			      "Watchdog timer expire", "Safety timer expire",
> -			      "Over current", "Calibration required"
> +			      "Over current", "Calibration required", "Warm",
> +			      "Cool", "Hot"
>   
>   What:		/sys/class/power_supply/<supply_name>/precharge_current
>   Date:		June 2017
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index bc79560229b5..4d6e1d5015d6 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -101,6 +101,9 @@ static const char * const POWER_SUPPLY_HEALTH_TEXT[] = {
>   	[POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE]   = "Safety timer expire",
>   	[POWER_SUPPLY_HEALTH_OVERCURRENT]	    = "Over current",
>   	[POWER_SUPPLY_HEALTH_CALIBRATION_REQUIRED]  = "Calibration required",
> +	[POWER_SUPPLY_HEALTH_WARM]		    = "Warm",
> +	[POWER_SUPPLY_HEALTH_COOL]		    = "Cool",
> +	[POWER_SUPPLY_HEALTH_HOT]		    = "Hot",
>   };
>   
>   static const char * const POWER_SUPPLY_TECHNOLOGY_TEXT[] = {
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index ac1345a48ad0..b5ee35d3c304 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -62,6 +62,9 @@ enum {
>   	POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
>   	POWER_SUPPLY_HEALTH_OVERCURRENT,
>   	POWER_SUPPLY_HEALTH_CALIBRATION_REQUIRED,
> +	POWER_SUPPLY_HEALTH_WARM,
> +	POWER_SUPPLY_HEALTH_COOL,
> +	POWER_SUPPLY_HEALTH_HOT,
>   };
>   
>   enum {


Can you apply this patch?

We have other charger drivers we want to submit for review but they all 
depend on this single patch.

If you do not want to apply this patch then please let us know how we 
can submit our other drivers so that build bots don't start spamming us 
with build failures

Dan


  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 21:54 [PATCH v14 0/4] Add JEITA properties and introduce the bq2515x charger Ricardo Rivera-Matos
2020-06-30 21:54 ` [PATCH v14 1/4] power_supply: Add additional health properties to the header Ricardo Rivera-Matos
2020-07-01 16:39   ` Dan Murphy [this message]
2020-06-30 21:54 ` [PATCH v14 2/4] dt-bindings: power: Convert battery.txt to battery.yaml Ricardo Rivera-Matos
2020-06-30 22:32   ` Joe Perches
2020-07-01 16:22     ` Dan Murphy
2020-06-30 21:54 ` [PATCH v14 3/4] dt-bindings: power: Add the bindings for the bq2515x family of chargers Ricardo Rivera-Matos
2020-06-30 21:54 ` [PATCH v14 4/4] power: supply: bq25150 introduce the bq25150 Ricardo Rivera-Matos
2020-06-30 23:33   ` Sebastian Reichel
2020-07-01  4:17     ` [EXTERNAL] " Ricardo Rivera-Matos
2020-07-01 16:17       ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=938bd51f-0551-38f0-c17c-19c7b42ec411@ti.com \
    --to=dmurphy@ti.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gurus@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=r-rivera-matos@ti.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=sspatil@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git