From: <Mario.Limonciello@dell.com>
To: <kai.heng.feng@canonical.com>, <rjw@rjwysocki.net>
Cc: <linux-acpi@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mika.westerberg@linux.intel.com>, <helgaas@kernel.org>
Subject: RE: [PATCH] ACPI: PM: Fix regression in acpi_device_set_power()
Date: Thu, 1 Aug 2019 19:06:25 +0000 [thread overview]
Message-ID: <9cdfa1cd722e48a789a114a3d805cdfa@AUSX13MPC105.AMER.DELL.COM> (raw)
In-Reply-To: <27715F95-E729-4EF5-B2BA-03BA3C87AE29@canonical.com>
> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Sent: Thursday, August 1, 2019 1:11 AM
> To: Rafael J. Wysocki
> Cc: Linux ACPI; Linux PM; Linux PCI; LKML; Mika Westerberg; Bjorn Helgaas;
> Limonciello, Mario
> Subject: Re: [PATCH] ACPI: PM: Fix regression in acpi_device_set_power()
>
>
> at 07:31, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Commit f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in
> > special cases") overlooked the fact that acpi_power_transition() may
> > change the power.state value for the target device and if that
> > happens, it may confuse acpi_device_set_power() and cause it to
> > omit the _PS0 evaluation which on some systems is necessary to
> > change power states of devices from low-power to D0.
> >
> > Fix that by saving the current value of power.state for the
> > target device before passing it to acpi_power_transition() and
> > using the saved value in a subsequent check.
> >
> > Fixes: f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in
> > special cases")
> > Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> > Reported-by: Mario Limonciello <mario.limonciello@dell.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Tested-by: Mario Limonciello <mario.limonciello@dell.com>
>
> > ---
> > drivers/acpi/device_pm.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > Index: linux-pm/drivers/acpi/device_pm.c
> >
> ==============================================================
> =====
> > --- linux-pm.orig/drivers/acpi/device_pm.c
> > +++ linux-pm/drivers/acpi/device_pm.c
> > @@ -236,13 +236,15 @@ int acpi_device_set_power(struct acpi_de
> > if (device->power.flags.power_resources)
> > result = acpi_power_transition(device, target_state);
> > } else {
> > + int cur_state = device->power.state;
> > +
> > if (device->power.flags.power_resources) {
> > result = acpi_power_transition(device, ACPI_STATE_D0);
> > if (result)
> > goto end;
> > }
> >
> > - if (device->power.state == ACPI_STATE_D0) {
> > + if (cur_state == ACPI_STATE_D0) {
> > int psc;
> >
> > /* Nothing to do here if _PSC is not present. */
>
prev parent reply other threads:[~2019-08-01 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 23:31 [PATCH] ACPI: PM: Fix regression in acpi_device_set_power() Rafael J. Wysocki
2019-08-01 6:11 ` Kai-Heng Feng
2019-08-01 19:06 ` Mario.Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdfa1cd722e48a789a114a3d805cdfa@AUSX13MPC105.AMER.DELL.COM \
--to=mario.limonciello@dell.com \
--cc=helgaas@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).