From: Randy Dunlap <rdunlap@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
bjorn.andersson@linaro.org
Subject: Re: linux-next: Tree for Jun 13 (drivers/soc/qcom/Kconfig)
Date: Thu, 13 Jun 2019 13:13:12 -0700 [thread overview]
Message-ID: <9dd920db-f1c9-d5b7-dc01-aa0e0e70df0e@infradead.org> (raw)
In-Reply-To: <2480052.F5ZUPELBQ8@kreacher>
On 6/13/19 11:27 AM, Rafael J. Wysocki wrote:
> On Thursday, June 13, 2019 6:12:43 PM CEST Randy Dunlap wrote:
>> This is a multi-part message in MIME format.
>> --------------D4992319A3EA7FFA5EF515C6
>> Content-Type: text/plain; charset=windows-1252
>> Content-Transfer-Encoding: 8bit
>>
>> On 6/13/19 2:30 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20190612:
>>>
>>
>>
>> on x86_64:
>>
>> ../drivers/base/power/domain.c: In function �genpd_queue_power_off_work�:
>> ../drivers/base/power/domain.c:485:13: error: �pm_wq� undeclared (first use in this function)
>> queue_work(pm_wq, &genpd->power_off_work);
>> ^
>> ../drivers/base/power/domain.c:485:13: note: each undeclared identifier is reported only once for each function it appears in
>> ../drivers/base/power/domain.c: In function �genpd_dev_pm_qos_notifier�:
>> ../drivers/base/power/domain.c:675:25: error: �struct dev_pm_info� has no member named �ignore_children�
>> if (!dev || dev->power.ignore_children)
>> ^
>> ../drivers/base/power/domain.c: In function �rtpm_status_str�:
>> ../drivers/base/power/domain.c:2754:16: error: �struct dev_pm_info� has no member named �runtime_error�
>> if (dev->power.runtime_error)
>> ^
>> ../drivers/base/power/domain.c:2756:21: error: �struct dev_pm_info� has no member named �disable_depth�
>> else if (dev->power.disable_depth)
>> ^
>> ../drivers/base/power/domain.c:2758:21: error: �struct dev_pm_info� has no member named �runtime_status�
>> else if (dev->power.runtime_status < ARRAY_SIZE(status_lookup))
>> ^
>> ../drivers/base/power/domain.c:2759:31: error: �struct dev_pm_info� has no member named �runtime_status�
>> p = status_lookup[dev->power.runtime_status];
>> ^
>>
>>
>> Full randconfig file is attached.
>
> PM_GENERIC_DOMAINS, which is set, depend on PM, which is not set.
Thanks for that. (I changed the subject to indicate the errant entity.)
> Looks like an impossible configuration to me.
It's what happens when a driver selects PM_GENERIC_DOMAINS when PM is not set/enabled.
From drivers/soc/qcom/Kconfig:
config QCOM_AOSS_QMP
tristate "Qualcomm AOSS Driver"
depends on ARCH_QCOM || COMPILE_TEST
depends on MAILBOX
depends on COMMON_CLK
select PM_GENERIC_DOMAINS
In my test case, COMPILE_TEST=y. ARCH_QCOM is not set.
And kconfig does warn:
WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS
Depends on [n]: PM [=n]
Selected by [m]:
- QCOM_AOSS_QMP [=m] && (ARCH_QCOM || COMPILE_TEST [=y]) && MAILBOX [=y] && COMMON_CLK [=y]
Who is responsible for that Kconfig segment?
Ah, Bjorn. Cc-ed.
--
~Randy
prev parent reply other threads:[~2019-06-13 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190613193054.37bde7fa@canb.auug.org.au>
[not found] ` <00d6da06-1316-6560-5541-0caf8ea5084b@infradead.org>
2019-06-13 18:27 ` linux-next: Tree for Jun 13 (drivers/base/power/domain.c) Rafael J. Wysocki
2019-06-13 20:13 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dd920db-f1c9-d5b7-dc01-aa0e0e70df0e@infradead.org \
--to=rdunlap@infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).