From: Anson Huang <anson.huang@nxp.com>
To: Zhang Rui <rui.zhang@intel.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Eduardo Valentin <edubezval@gmail.com>,
Shawn Guo <shawnguo@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Stephen Boyd <sboyd@kernel.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations
Date: Tue, 27 Aug 2019 03:24:30 +0000 [thread overview]
Message-ID: <AM6PR0402MB39115FEE1E53EC047F54C4F6F5A00@AM6PR0402MB3911.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <57ecab7c3600802d544683fcb968f9455b2b25d8.camel@intel.com>
Hi, Rui
> On Tue, 2019-08-27 at 01:51 +0000, Anson Huang wrote:
> > > On 7/30/2019 5:31 AM, Anson.Huang@nxp.com wrote:
> > > > From: Anson Huang <Anson.Huang@nxp.com>
> > > >
> > > > Some platforms like i.MX8MQ has clock control for this module,
> > > > need to add clock operations to make sure the driver is working
> > > > properly.
> > > >
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > > Reviewed-by: Guido Günther <agx@sigxcpu.org>
> > >
> > > This series looks good, do you think it can be merged in time for
> > > v5.4?
> > > Today was v5.3-rc6.
> >
> > If the question is for me, then I am NOT sure, the thermal patches are
> > pending there for almost half year and I did NOT receive any response,
>
> which patch series you're referring to?
Below i.MX8QXP patch series, I meant I started it from last year, the latest resend
version is 2 months ago:
https://patchwork.kernel.org/patch/11000809/
>
> > looks like no one
> > is maintaining the thermal sub-system?
Below two patch series are also pending there for some time:
https://patchwork.kernel.org/patch/11032777/
https://patchwork.kernel.org/patch/11031297/
> >
>
> Eduardo is maintaining all the thermal-soc driver changes. Thus I usually
> filtered out the soc driver patches in my mailbox.
>
> The last email from Eduardo is that he is offline during this July and will be
> back and taking patches in August.
>
> I will double check with Eduardo anyway.
Thanks, especially our i.MX8QXP thermal driver patch, I started it from last year and
due to some different opinion from different reviewers, this patch series version is
up to v15, but I did NOT receive response since June, appreciated if you guys can take
a look at this, I ping it many times but no feedback. Thanks!
https://patchwork.kernel.org/patch/11000809/
Anson.
>
> thanks,
> rui
>
>
> > >
> > > In an earlier series the CLK_IS_CRITICAL flags was removed from the
> > > TMU clock so if the thermal driver doesn't explicitly enable it the
> > > system will hang on probe. This is what happens in linux-next right
> > > now!
> >
> > The thermal driver should be built with module, so default kernel
> > should can boot up, do you modify the thermal driver as built-in?
> >
> > >
> > > Unless this patches is merged soon we'll end up with a 5.4-rc1 that
> > > doesn't boot on imx8mq. An easy fix would be to drop/revert commit
> > > 951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for
> > > IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted.
> >
> > If the thermal driver is built as module, I think no need to revert
> > the commit, but if by default thermal driver is built-in or mod
> > probed, then yes, it should NOT break kernel boot up.
> >
> > Anson.
> >
> > >
> > > Merging patches out-of-order when they have hard (boot-breaking)
> > > dependencies also breaks bisect.
> > >
> > > --
> > > Regards,
> > > Leonard
next prev parent reply other threads:[~2019-08-27 3:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 2:21 [PATCH V3 1/5] thermal: qoriq: Add clock operations Anson.Huang
2019-07-30 2:21 ` [PATCH V3 2/5] thermal: qoriq: Fix error path of calling qoriq_tmu_register_tmu_zone fail Anson.Huang
2019-08-05 7:01 ` Aisheng Dong
2019-07-30 2:21 ` [PATCH V3 3/5] thermal: qoriq: Use devm_platform_ioremap_resource() instead of of_iomap() Anson.Huang
2019-08-05 7:01 ` Aisheng Dong
2019-07-30 2:21 ` [PATCH V3 4/5] thermal: qoriq: Use __maybe_unused instead of #if CONFIG_PM_SLEEP Anson.Huang
2019-08-05 7:02 ` Aisheng Dong
2019-07-30 2:21 ` [PATCH V3 5/5] dt-bindings: thermal: qoriq: Add optional clocks property Anson.Huang
2019-08-05 7:02 ` Aisheng Dong
2019-08-05 7:00 ` [PATCH V3 1/5] thermal: qoriq: Add clock operations Aisheng Dong
2019-08-26 14:45 ` Leonard Crestez
2019-08-27 1:51 ` Anson Huang
2019-08-27 3:09 ` Zhang Rui
2019-08-27 3:24 ` Anson Huang [this message]
2019-08-27 12:41 ` Leonard Crestez
2019-08-28 8:32 ` Zhang Rui
2019-08-28 8:35 ` Zhang Rui
2019-08-28 8:49 ` Anson Huang
2019-08-28 9:01 ` Zhang Rui
2019-08-28 9:12 ` Anson Huang
2019-08-28 8:51 ` Anson Huang
2019-08-28 9:03 ` Zhang Rui
2019-08-28 9:10 ` Anson Huang
2019-08-29 2:49 ` Anson Huang
2019-08-29 3:01 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR0402MB39115FEE1E53EC047F54C4F6F5A00@AM6PR0402MB3911.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).