From: Zak Hays <zak.hays@lexmark.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] thermal: armada-thermal: clear reset in armadaxp_init
Date: Tue, 3 Dec 2019 16:36:29 +0000 [thread overview]
Message-ID: <BN8PR10MB3379AC7EF5E941B9234B7E628C420@BN8PR10MB3379.namprd10.prod.outlook.com> (raw)
In-Reply-To: <20191127120018.679bf947@xps13>
Hi Miquèl,
>The format of your patch is strange, there are additional empty lines
>which are problematic.
Apologies for the formatting. I'll try to fix that in that next patch set.
>Do you really want to write this register twice? Shouldn't you get rid
>of the first regmap_write() above?
I'm writing the register twice in order to pulse the reset line and ensure the block is reset at init. This is similar to what was done in the driver previously:
/* Reset the sensor */
reg = readl_relaxed(priv->control1);
writel((reg | PMU_TDC0_SW_RST_MASK), priv->control1); <= Set the reset bit
writel(reg, priv->control1); <= Immediately clear the bit
I'm a little unsure that setting then immediately clearing reset is enough time for the block to do a full reset but I can't find anything in AXP's documentation to indicate a correct reset time. As such, I just emulated the original process from earlier kernel versions. If you believe that a udelay should be added, I can add one in the next patch set.
Thanks!
Zak
________________________________________
From: Miquel Raynal <miquel.raynal@bootlin.com>
Sent: Wednesday, November 27, 2019 6:00 AM
To: Zak Hays
Cc: Zhang Rui; Eduardo Valentin; Daniel Lezcano; Amit Kucheria; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal: armada-thermal: clear reset in armadaxp_init
Hi Zak,
Zak Hays <zak.hays@lexmark.com> wrote on Tue, 26 Nov 2019 14:54:11
+0000:
> The reset bit needs to be cleared in the init sequence otherwise it
>
> holds the block in reset.
"thermal: armada: " is the right prefix for your title
Your Signed-off-by should be here (git commit --amend -s)
The format of your patch is strange, there are additional empty lines
which are problematic.
>
> ---
>
> drivers/thermal/armada_thermal.c | 3 +++
>
> 1 file changed, 3 insertions(+)
>
>
>
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
>
> index 88363812033c..8c4d1244ee7a 100644
>
> --- a/drivers/thermal/armada_thermal.c
>
> +++ b/drivers/thermal/armada_thermal.c
>
> @@ -155,6 +155,9 @@ static void armadaxp_init(struct platform_device *pdev,
>
>
>
> regmap_write(priv->syscon, data->syscon_control1_off, reg);
>
>
>
> + reg &= ~PMU_TDC0_SW_RST_MASK;
>
> + regmap_write(priv->syscon, data->syscon_control1_off, reg);
>
> +
Do you really want to write this register twice? Shouldn't you get rid
of the first regmap_write() above?
>
> /* Enable the sensor */
>
> regmap_read(priv->syscon, data->syscon_status_off, ®);
>
> reg &= ~PMU_TM_DISABLE_MASK;
>
In your next iteration, please use the '-v2' option with
git-format-patch to get titles starting with "[PATCH v2 x/2] ..."
automatically. Also write a changelog below the three dots '---'.
Thanks,
Miquèl
prev parent reply other threads:[~2019-12-03 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1574721077-29892-1-git-send-email-zhays@lexmark.com>
2019-11-26 14:53 ` [PATCH 1/2] thermal: armada-thermal: fix register offsets for AXP Zak Hays
[not found] ` <1574721077-29892-2-git-send-email-zhays@lexmark.com>
2019-11-26 14:54 ` [PATCH 2/2] thermal: armada-thermal: clear reset in armadaxp_init Zak Hays
2019-11-27 11:00 ` Miquel Raynal
2019-12-03 16:36 ` Zak Hays [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR10MB3379AC7EF5E941B9234B7E628C420@BN8PR10MB3379.namprd10.prod.outlook.com \
--to=zak.hays@lexmark.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).