From: Brian Norris <briannorris@chromium.org>
To: Michael Nosthoff <committed@heine.so>
Cc: linux-pm <linux-pm@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] power: supply: sbs-battery: only return health when battery present
Date: Thu, 22 Aug 2019 13:32:46 -0700 [thread overview]
Message-ID: <CA+ASDXMETzc72iZq5pN6QfySXGiHQEcsB0A5ZujSyg-YhKNBBw@mail.gmail.com> (raw)
In-Reply-To: <5D5E47B1.70604@heine.so>
On Thu, Aug 22, 2019 at 12:43 AM Michael Nosthoff <committed@heine.so> wrote:
> This done at the end of 'sbs_get_property' if the presence state changed and
> no gpio is used. I suspect it triggers a readout of all the properties
> and leads to this
> endless loop?
Ah, it's not all properties IIUC, but it does lead to
power_supply_update_leds() -> power_supply_update_bat_leds() ->
power_supply_get_property(... POWER_SUPPLY_PROP_STATUS ...). That
would be enough to kick off the loop you're noticing.
Brian
next prev parent reply other threads:[~2019-08-22 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 7:58 [PATCH] power: supply: sbs-battery: only return health when battery present Michael Nosthoff
2019-08-22 1:46 ` Brian Norris
2019-08-22 1:48 ` Brian Norris
2019-08-22 7:43 ` Michael Nosthoff
2019-08-22 20:32 ` Brian Norris [this message]
2019-09-02 7:59 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+ASDXMETzc72iZq5pN6QfySXGiHQEcsB0A5ZujSyg-YhKNBBw@mail.gmail.com \
--to=briannorris@chromium.org \
--cc=committed@heine.so \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).