Linux-PM Archive on
 help / color / Atom feed
From: Brian Norris <>
To: Michael Nosthoff <>
Cc: linux-pm <>
Subject: Re: [PATCH] power: supply: sbs-battery: use correct flags field
Date: Thu, 15 Aug 2019 09:42:06 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Aug 15, 2019 at 9:38 AM Brian Norris <> wrote:
> On Thu, Aug 15, 2019 at 8:53 AM Michael Nosthoff <> wrote:
> > the type flag is stored in the chip->flags field not in the
> > client->flags field. This currently leads to never using the ti
> > specific function but always falling back to the general one.

Also, the key point to why it will "never be used" is that the client
(struct i2c_client) doesn't have a flag for BIT(0). See I2C_CLIENT_*
flags, which start from 0x04.


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 15:53 Michael Nosthoff
2019-08-15 16:38 ` Brian Norris
2019-08-15 16:42   ` Brian Norris [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on

Archives are clonable:
	git clone --mirror linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ \
	public-inbox-index linux-pm

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox