From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Frank Lee <tiny.windzz@gmail.com>
Cc: "Maxime Ripard" <mripard@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Eduardo Valentin" <edubezval@gmail.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amit.kucheria@verdurent.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linux PM" <linux-pm@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
arm-linux <linux-arm-kernel@lists.infradead.org>,
"Ondřej Jirman" <megous@megous.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings
Date: Thu, 28 Nov 2019 08:24:14 -0800 [thread overview]
Message-ID: <CA+E=qVcp9MqFPoU9DCypAw7kK+obeDnES4QSeq7mSUc+rRLutw@mail.gmail.com> (raw)
In-Reply-To: <CAEExFWu4MPxA+Vs1BNzCqeR5EkbVT2SjMf6hRBK6nZ2doJmduA@mail.gmail.com>
On Thu, Nov 28, 2019 at 6:45 AM Frank Lee <tiny.windzz@gmail.com> wrote:
Hey Yangtao,
I've already addressed all the comments and fixed patchset is sitting
in https://github.com/anarsoul/linux-2.6/tree/ths-5.4
I'll rebase and submit new version after merge window is closed (in ~1.5 weeks?)
Regards,
Vasily
> diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml
> b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml
> new file mode 100644
> index 000000000000..1be32f09fcc8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml
> @@ -0,0 +1,160 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner SUN8I Thermal Controller Device Tree Bindings
> +
> +maintainers:
> + - Yangtao Li <tiny.windzz@gmail.com>
> +
> +description: |-
> + This describes the device tree binding for the Allwinner thermal
> + controller which measures the on-SoC temperatures.
> +
> +properties:
> + compatible:
> + enum:
> + - allwinner,sun8i-a83t-ths
> + - allwinner,sun8i-h3-ths
> + - allwinner,sun8i-r40-ths
> + - allwinner,sun50i-a64-ths
> + - allwinner,sun50i-h5-ths
> + - allwinner,sun50i-h6-ths
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> + items:
> + - description: ths bus clock
> + - description: ths mod clock
> +
> + clock-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + - const: bus
> + - const: mod
> +
> + "#thermal-sensor-cells":
> + enum: [ 0, 1 ]
> +
> + nvmem-cells:
> + description: ths calibrate data
> +
> + nvmem-cell-names:
> + const: calibration
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#thermal-sensor-cells"
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - allwinner,sun8i-h3-ths
> + - allwinner,sun8i-r40-ths
> + - allwinner,sun50i-a64-ths
> + - allwinner,sun50i-h5-ths
> + - allwinner,sun50i-h6-ths
> +
> + then:
> + properties:
> + resets:
> + minItems: 1
> + maxItems: 1
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun50i-h6-ths
> +
> + then:
> + properties:
> + clocks:
> + minItems: 1
> + maxItems: 1
> +
> + clock-names:
> + minItems: 1
> + maxItems: 1
> +
> + else:
> + if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - allwinner,sun8i-h3-ths
> + - allwinner,sun8i-r40-ths
> + - allwinner,sun50i-a64-ths
> + - allwinner,sun50i-h5-ths
> +
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> +
> + clock-names:
> + minItems: 2
> + maxItems: 2
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun8i-h3-ths
> +
> + then:
> + properties:
> + "#thermal-sensor-cells":
> + const: 0
> +
> + else:
> + properties:
> + "#thermal-sensor-cells":
> + const: 1
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + ths: ths@5070400 {
> + compatible = "allwinner,sun50i-h6-ths";
> + reg = <0x05070400 0x100>;
> + clocks = <&ccu 89>;
> + clock-names = "bus";
> + resets = <&ccu 36>;
> + interrupts = <0 15 4>;
> + nvmem-cells = <&tsen_calib>;
> + nvmem-cell-names = "calibration";
> + #thermal-sensor-cells = <1>;
> + };
> +
> + sid: sid@3006000 {
> + compatible = "allwinner,sun50i-h6-sid";
> + reg = <0x03006000 0x400>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + tsen_calib: calib@14 {
> + reg = <0x14 6>;
> + };
> + };
> +...
>
> On Thu, Nov 28, 2019 at 10:35 PM Frank Lee <tiny.windzz@gmail.com> wrote:
> >
> > Hi,
> >
> > How about this?
> >
> > Best regards,
> > Yangtao
next prev parent reply other threads:[~2019-11-28 16:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 5:29 [PATCH v6 0/7] add thermal sensor driver for A64, A83T, H3, H5, H6, R40 Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 Vasily Khoruzhick
2019-11-27 11:14 ` Ondřej Jirman
2019-11-27 17:35 ` Maxime Ripard
2019-11-27 19:44 ` Frank Lee
2019-11-27 19:48 ` Vasily Khoruzhick
2019-11-27 22:24 ` Ondřej Jirman
2019-11-28 15:16 ` Frank Lee
2019-11-29 0:53 ` Ondřej Jirman
2019-11-28 7:42 ` Maxime Ripard
2019-11-27 17:27 ` Maxime Ripard
2019-11-28 16:43 ` Frank Lee
2019-11-28 17:06 ` Ondřej Jirman
2019-11-29 11:46 ` Frank Lee
2019-12-02 1:58 ` Ondřej Jirman
2019-12-09 18:04 ` Frank Lee
2019-11-27 5:29 ` [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings Vasily Khoruzhick
2019-11-27 17:44 ` Maxime Ripard
2019-11-27 18:07 ` Ondřej Jirman
2019-11-27 18:52 ` Vasily Khoruzhick
2019-11-27 20:23 ` Vasily Khoruzhick
2019-11-28 7:43 ` Maxime Ripard
2019-11-28 14:35 ` Frank Lee
2019-11-28 14:45 ` Frank Lee
2019-11-28 16:24 ` Vasily Khoruzhick [this message]
2019-11-27 5:29 ` [PATCH v6 3/7] ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 4/7] ARM: dts: sun8i-h3: " Vasily Khoruzhick
2019-11-27 19:40 ` Samuel Holland
2019-11-27 5:29 ` [PATCH v6 5/7] arm64: dts: allwinner: sun50i-h5: " Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 6/7] arm64: dts: allwinner: sun50i-h6: " Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 7/7] arm64: dts: allwinner: a64: Add thermal sensors " Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+E=qVcp9MqFPoU9DCypAw7kK+obeDnES4QSeq7mSUc+rRLutw@mail.gmail.com' \
--to=anarsoul@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).