From: Bartosz Szczepanek <bsz@semihalf.com>
To: Matthew Garrett <mjg59@google.com>,
Zhang Rui <rui.zhang@intel.com>,
Pandruvada Srinivas <srinivas.pandruvada@linux.intel.com>,
linux-pm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Radoslaw Biernacki <rad@semihalf.com>,
Alex Levin <levinale@google.com>
Subject: Re: [PATCH] thermal/int340x_thermal: Prevent page fault on .set_mode() op
Date: Thu, 9 Jul 2020 11:36:18 +0200 [thread overview]
Message-ID: <CABLO=+kwtYKdEHNsYS13+=LgFZ3L7Snym-aBthxe=vOsjiPTbg@mail.gmail.com> (raw)
In-Reply-To: <20200708134613.131555-1-bsz@semihalf.com>
Hi Rui, Matthew,
I think this regression should be corrected still in the 5.8 release
cycle. It may cause kernel panic if .set_mode() is called before
current_uuid_store(), and from what I see both operations can be
triggered from sysfs. What I'm not 100% sure about is if we should
apply the above fix, or rather revert the driver to its default
behaviour of using uuid=0 if it wasn't set from userspace (this is how
it was before Matthew's commit). What do you think?
Best regards,
Bartosz
On Wed, Jul 8, 2020 at 3:46 PM Bartosz Szczepanek <bsz@semihalf.com> wrote:
>
> Starting from commit "thermal/int340x_thermal: Don't require IDSP to
> exist", priv->current_uuid_index is initialized to -1. This value may
> be passed to int3400_thermal_run_osc() from int3400_thermal_set_mode,
> contributing to page fault when accessing int3400_thermal_uuids array
> at index -1.
>
> This commit adds a check on uuid value to int3400_thermal_run_osc.
>
> Signed-off-by: Bartosz Szczepanek <bsz@semihalf.com>
> ---
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index 0b3a62655843..12448ccd27f1 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -216,11 +216,16 @@ static int int3400_thermal_run_osc(acpi_handle handle,
> acpi_status status;
> int result = 0;
> struct acpi_osc_context context = {
> - .uuid_str = int3400_thermal_uuids[uuid],
> + .uuid_str = NULL,
> .rev = 1,
> .cap.length = 8,
> };
>
> + if (uuid < 0 || uuid >= INT3400_THERMAL_MAXIMUM_UUID)
> + return -EINVAL;
> +
> + context.uuid_str = int3400_thermal_uuids[uuid];
> +
> buf[OSC_QUERY_DWORD] = 0;
> buf[OSC_SUPPORT_DWORD] = enable;
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-07-09 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 13:46 [PATCH] thermal/int340x_thermal: Prevent page fault on .set_mode() op Bartosz Szczepanek
2020-07-09 9:36 ` Bartosz Szczepanek [this message]
2020-07-09 17:00 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABLO=+kwtYKdEHNsYS13+=LgFZ3L7Snym-aBthxe=vOsjiPTbg@mail.gmail.com' \
--to=bsz@semihalf.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=levinale@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mjg59@google.com \
--cc=rad@semihalf.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).