From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
linux-hwmon@vger.kernel.org, Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sujith Thomas <sujith.thomas@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 4/8] platform/x86: intel_menlow: switch to use <linux/temperature.h> helpers
Date: Mon, 25 Nov 2019 23:34:50 +0900 [thread overview]
Message-ID: <CAC5umygc95VBWz1L5CTZO9kmkZL2MCEL2_z9d2TJ6Ow5+fKYPw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfOUiN_2bW+o-AqGmAY32mmdNxP54B2f2+gj0NTEr9FTQ@mail.gmail.com>
2019年11月25日(月) 4:58 Andy Shevchenko <andy.shevchenko@gmail.com>:
>
> On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@gmail.com> wrote:
> >
> > This switches the intel_menlow driver to use deci_kelvin_to_celsius() and
> > celsius_to_deci_kelvin() in <linux/temperature.h> instead of helpers in
> > <linux/thermal.h>.
> >
> > This is preparation for centralizing the kelvin to/from Celsius conversion
> > helpers in <linux/temprature.h>.
> >
> > Cc: Sujith Thomas <sujith.thomas@intel.com>
> > Cc: Darren Hart <dvhart@infradead.org>
> > Cc: Andy Shevchenko <andy@infradead.org>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Eduardo Valentin <edubezval@gmail.com>
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Amit Kucheria <amit.kucheria@verdurent.com>
> > Cc: Jean Delvare <jdelvare@suse.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Keith Busch <kbusch@kernel.org>
> > Cc: Jens Axboe <axboe@fb.com>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Sagi Grimberg <sagi@grimberg.me>
> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> > ---
> > drivers/platform/x86/intel_menlow.c | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel_menlow.c
> > index b102f6d..6313591 100644
> > --- a/drivers/platform/x86/intel_menlow.c
> > +++ b/drivers/platform/x86/intel_menlow.c
> > @@ -302,8 +302,10 @@ static ssize_t aux_show(struct device *dev, struct device_attribute *dev_attr,
> > int result;
> >
> > result = sensor_get_auxtrip(attr->handle, idx, &value);
> > + if (result)
> > + return result;
> >
> > - return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO_CELSIUS(value));
> > + return sprintf(buf, "%ld", deci_kelvin_to_celsius(value));
>
> Can you explain the change %lu to %ld?
Isn't it possible for aux values to be lower than 0 degrees Celsius?
> > }
> >
> > static ssize_t aux0_show(struct device *dev,
> > @@ -332,8 +334,8 @@ static ssize_t aux_store(struct device *dev, struct device_attribute *dev_attr,
> > if (value < 0)
> > return -EINVAL;
> >
> > - result = sensor_set_auxtrip(attr->handle, idx,
> > - CELSIUS_TO_DECI_KELVIN(value));
>
> > + result = sensor_set_auxtrip(attr->handle, idx,
> > + celsius_to_deci_kelvin(value));
>
> How come the first line has been changed?
Because the trailing space is removed. I'll mention it in the commit log.
next prev parent reply other threads:[~2019-11-25 14:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 14:08 [PATCH 0/8] add header file for kelvin to/from Celsius conversion helpers Akinobu Mita
2019-11-24 14:08 ` [PATCH 1/8] " Akinobu Mita
2019-11-24 14:57 ` Andy Shevchenko
2019-11-25 14:29 ` Akinobu Mita
2019-11-25 19:05 ` Andy Shevchenko
2019-11-24 14:08 ` [PATCH 2/8] ACPI: thermal: switch to use <linux/temperature.h> helpers Akinobu Mita
2019-11-24 15:17 ` Guenter Roeck
2019-11-25 14:31 ` Akinobu Mita
2019-11-24 14:08 ` [PATCH 3/8] platform/x86: asus-wmi: " Akinobu Mita
2019-11-24 19:54 ` Andy Shevchenko
2019-11-25 14:31 ` Akinobu Mita
2019-11-25 19:06 ` Andy Shevchenko
2019-11-24 14:08 ` [PATCH 4/8] platform/x86: intel_menlow: " Akinobu Mita
2019-11-24 19:57 ` Andy Shevchenko
2019-11-25 14:34 ` Akinobu Mita [this message]
2019-11-25 19:07 ` Andy Shevchenko
2019-11-26 14:34 ` Akinobu Mita
2019-11-24 14:08 ` [PATCH 5/8] thermal: int340x: " Akinobu Mita
2019-11-24 14:08 ` [PATCH 6/8] thermal: intel_pch: " Akinobu Mita
2019-11-24 15:15 ` Guenter Roeck
2019-11-24 14:08 ` [PATCH 7/8] nvme: hwmon: " Akinobu Mita
2019-11-25 6:59 ` Christoph Hellwig
2019-11-24 14:08 ` [PATCH 8/8] thermal: remove kelvin to/from Celsius conversion helpers from <linux/thermal.h> Akinobu Mita
2019-11-24 20:00 ` Andy Shevchenko
2019-11-25 14:39 ` Akinobu Mita
2019-11-25 19:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC5umygc95VBWz1L5CTZO9kmkZL2MCEL2_z9d2TJ6Ow5+fKYPw@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=axboe@fb.com \
--cc=daniel.lezcano@linaro.org \
--cc=dvhart@infradead.org \
--cc=edubezval@gmail.com \
--cc=hch@lst.de \
--cc=jdelvare@suse.com \
--cc=kbusch@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rui.zhang@intel.com \
--cc=sagi@grimberg.me \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).