From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1491EC32792 for ; Mon, 30 Sep 2019 16:36:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E50B22168B for ; Mon, 30 Sep 2019 16:36:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732340AbfI3Qg2 (ORCPT ); Mon, 30 Sep 2019 12:36:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50466 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731459AbfI3QgZ (ORCPT ); Mon, 30 Sep 2019 12:36:25 -0400 Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E95FC04B302 for ; Mon, 30 Sep 2019 16:36:24 +0000 (UTC) Received: by mail-io1-f69.google.com with SMTP id q18so31228036ios.8 for ; Mon, 30 Sep 2019 09:36:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n6TZwGZ6BwH01Gtc+GZbV82I7jDbXiJPW011pcYuI0Q=; b=QU4a3l10iJS6xJQOTNZWZs/FLfGuHzQKSsUqrWeUk75dK5I3NQwPpV8LQFuWot55EU eGeUyme9w3fe4PJXI+Xso5xceZJpHiMkoaJlKaNMJGYAwAEGh9XyDIAttATwj3DpGtWl n1hxahBzw+fWQsB3ZVHSvN3gh+KiWYTDnV7H8xIOpWO1A3ZDJC2WAEmGUFVXxiuLXvh7 Frlhnyf4YAEzTITrsD67uZ0aGlGezruOUugCrE/fFbp66vscCip1tFGoNcav6XTofSrp IEJrL4Li9HQlETDQeZMTC+A9iZJmfXDkvbi8Rpy0xEm10Z5ULkQ7L7yXM33uzKTDjEtB 950w== X-Gm-Message-State: APjAAAXew8MbnXlZZSQPgWyypxxafqwjYQU/EVR/SbGL3GTYWgeYV572 VUX6QYJVvJn9cm+bvdENLyhFsPtI/Q1YoAzP6QTpIrb2KR0ErZrcS1rhkZGW+aqOYvcdOPAoxKM KIM4f5aT36WRHA39u9bUyXvZodMVIDIDdwTQ= X-Received: by 2002:a6b:3804:: with SMTP id f4mr7902605ioa.166.1569861384019; Mon, 30 Sep 2019 09:36:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxTi7C+3z1z5gBDBQSyyub19LVPhCynfHDYm5iNSEA04yROLKW+AsLuHu877bWM07L3lw3ItDdT4w5mzyKMATY= X-Received: by 2002:a6b:3804:: with SMTP id f4mr7902576ioa.166.1569861383788; Mon, 30 Sep 2019 09:36:23 -0700 (PDT) MIME-Version: 1.0 References: <20190927144421.22608-1-kherbst@redhat.com> <20190927214252.GA65801@google.com> <20190930080534.GS2714@lahna.fi.intel.com> <20190930092934.GT2714@lahna.fi.intel.com> <20190930163001.GX2714@lahna.fi.intel.com> In-Reply-To: <20190930163001.GX2714@lahna.fi.intel.com> From: Karol Herbst Date: Mon, 30 Sep 2019 18:36:12 +0200 Message-ID: Subject: Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges To: Mika Westerberg Cc: Bjorn Helgaas , LKML , Lyude Paul , Linux PCI , dri-devel , nouveau , "Rafael J. Wysocki" , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg wrote: > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > still happens with your patch applied. The machine simply gets shut down. > > > > dmesg can be found here: > > https://gist.githubusercontent.com/karolherbst/40eb091c7b7b33ef993525de660f1a3b/raw/2380e31f566e93e5ba7c87ef545420965d4c492c/gistfile1.txt > > Looking your dmesg: > > Sep 30 17:24:27 kernel: nouveau 0000:01:00.0: DRM: DCB version 4.1 > Sep 30 17:24:27 kernel: nouveau 0000:01:00.0: DRM: MM: using COPY for buffer copies > Sep 30 17:24:27 kernel: [drm] Initialized nouveau 1.3.1 20120801 for 0000:01:00.0 on minor 1 > > I would assume it runtime suspends here. Then it wakes up because of PCI > access from userspace: > > Sep 30 17:24:42 kernel: pci_raw_set_power_state: 56 callbacks suppressed > > and for some reason it does not get resumed properly. There are also few > warnings from ACPI that might be relevant: > > Sep 30 17:24:27 kernel: ACPI Warning: \_SB.PCI0.GFX0._DSM: Argument #4 type mismatch - Found [Buffer], ACPI requires [Package] (20190509/nsarguments-59) > Sep 30 17:24:27 kernel: ACPI Warning: \_SB.PCI0.PEG0.PEGP._DSM: Argument #4 type mismatch - Found [Buffer], ACPI requires [Package] (20190509/nsarguments-59) > afaik this is the case for essentially every laptop out there. > This seems to be Dell XPS 9560 which I think has been around some time > already so I wonder why we only see issues now. Has it ever worked for > you or maybe there is a regression that causes it to happen now? oh, it's broken since forever, we just tried to get more information from Nvidia if they know what this is all about, but we got nothing useful. We were also hoping to find a reliable fix or workaround we could have inside nouveau to fix that as I think nouveau is the only driver actually hit by this issue, but nothing turned out to be reliable enough.