From: Linus Walleij <linus.walleij@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Linux PM list <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT 1/3] power: supply: ab8500: Cleanup probe in reverse order
Date: Wed, 16 Oct 2019 10:33:12 +0200 [thread overview]
Message-ID: <CACRpkdYSnnOJomJi=Db2nkrrdNQmBnNKny1c7ZpDj6KdmKD9Mg@mail.gmail.com> (raw)
In-Reply-To: <20191004150738.6542-1-krzk@kernel.org>
On Fri, Oct 4, 2019 at 5:07 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> It is logical to cleanup in probe's error path in reverse order to
> previous actions. It also makes easier to add additional goto labels
> within this error path.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
For all 3 patches:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
The battery charging code is currently disabled on ux500 simply
because no platforms with batteries were available for testing
or supported by any device trees.
This is getting fix: PostmarketOS is brewing patches for enabling
all Ux500-based Samsung phones, all with batteries. So we will
soon be able to test and turn this on.
The patches are fine to merge, however notice that we are
refactoring all drivers using ADC through the IIO tree:
https://lore.kernel.org/linux-iio/20191011071805.5554-4-linus.walleij@linaro.org/
https://lore.kernel.org/linux-iio/20191011071805.5554-2-linus.walleij@linaro.org/
https://lore.kernel.org/linux-iio/20191011071805.5554-3-linus.walleij@linaro.org/
It would be nice if we could avoid colissions.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-10-16 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:07 [RFT 1/3] power: supply: ab8500: Cleanup probe in reverse order Krzysztof Kozlowski
2019-10-04 15:07 ` [RFT 2/3] power: supply: ab8500_fg: Do not free non-requested IRQs in probe's error path Krzysztof Kozlowski
2019-10-04 15:07 ` [RFT 3/3] power: supply: ab8500: Handle invalid IRQ from platform_get_irq_byname() Krzysztof Kozlowski
2019-10-16 8:33 ` Linus Walleij [this message]
2019-10-20 13:23 ` [RFT 1/3] power: supply: ab8500: Cleanup probe in reverse order Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYSnnOJomJi=Db2nkrrdNQmBnNKny1c7ZpDj6KdmKD9Mg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=gustavo@embeddedor.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).