From: Linus Walleij <linus.walleij@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] thermal: db8500: Finalize device tree conversion
Date: Wed, 28 Aug 2019 10:57:47 +0200 [thread overview]
Message-ID: <CACRpkdZ6rnV8isO4SF86jiY2E2pbR9f2OBKYQBbML53A90WCig@mail.gmail.com> (raw)
In-Reply-To: <f683466b-a554-87c4-0bfd-4d56bd1142fe@linaro.org>
On Tue, Aug 27, 2019 at 3:54 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> On 27/08/2019 15:07, Linus Walleij wrote:
> > I think this is something that should be done inside the
> > driver, not by abusing the trip points, so I try to rewrite the logic
> > so that the driver fires these IRQs internally without using any
> > trip points from the thermal subsystem.
>
> In the comments, it is mentioned something is missing with the PRCMU but
> when the interface will be available, the get_temp won't have to
> interpolate. Wouldn't make sense to add the PRCMU interface instead ?
Yes. But this is a firmware that I cannot rewrite or control,
and which is preinstalled on a lot of shipped devices, so we
cannot fix it that way. It was more a suggestion for internal
development in later generations at the time :(
I have made a new 3-part patch set that fixes this up as
good as I can, will send it out!
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-08-28 8:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 6:32 [PATCH 1/2] thermal: db8500: Finalize device tree conversion Linus Walleij
2019-07-17 6:32 ` [PATCH 2/2] thermal: db8500: Use dev helper variable Linus Walleij
2019-07-25 12:21 ` [PATCH 1/2] thermal: db8500: Finalize device tree conversion Lee Jones
2019-08-03 13:58 ` Linus Walleij
2019-08-11 22:21 ` Linus Walleij
2019-08-22 6:16 ` Daniel Lezcano
2019-08-27 11:21 ` Linus Walleij
2019-08-27 13:24 ` Daniel Lezcano
2019-08-27 13:07 ` Linus Walleij
2019-08-27 13:54 ` Daniel Lezcano
2019-08-28 8:57 ` Linus Walleij [this message]
2019-08-28 9:04 ` Daniel Lezcano
2019-08-28 12:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ6rnV8isO4SF86jiY2E2pbR9f2OBKYQBbML53A90WCig@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).