From: Prashant Malani <pmalani@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Guenter Roeck <groeck@chromium.org>,
Benson Leung <bleung@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS"
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH v8 3/4] mfd: cros_ec: Check DT node for usbpd-notify add
Date: Mon, 10 Feb 2020 10:59:54 -0800 [thread overview]
Message-ID: <CACeCKacwg2gapH7MjByg76qrbh0CvQJ9tftr+ot+NzrMUjXGKA@mail.gmail.com> (raw)
In-Reply-To: <60312890-cd5e-840e-8c71-2d7876542650@collabora.com>
Hi Enric,
On Mon, Feb 10, 2020 at 8:38 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Prashant,
>
> On 10/2/20 17:32, Prashant Malani wrote:
> > Hi Enric,
> >
> > On Mon, Feb 10, 2020, 02:11 Enric Balletbo i Serra <enric.balletbo@collabora.com
> > <mailto:enric.balletbo@collabora.com>> wrote:
> >
> > Hi Prashant,
> >
> > On 27/1/20 15:50, Enric Balletbo i Serra wrote:
> > > Hi Prashant,
> > >
> > > On 25/1/20 0:18, Prashant Malani wrote:
> > >> Add a check to ensure there is indeed an EC device tree entry before
> > >> adding the cros-usbpd-notify device. This covers configs where both
> > >> CONFIG_ACPI and CONFIG_OF are defined, but the EC device is defined
> > >> using device tree and not in ACPI.
> > >>
> > >> Signed-off-by: Prashant Malani <pmalani@chromium.org
> > <mailto:pmalani@chromium.org>>
> > >
> > > With this change, an playing with different CONFIG_ACPI + CONFIG_OF
> > combinations
> > > I don't see anymore the problem where the driver is registered twice on
> > > CONFIG_ACPI side. So,
> > >
> > > Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com
> > <mailto:enric.balletbo@collabora.com>>
> > >
> > > Maybe it requires a fixes tag if Lee already picked the other patch?
> > >
> > > Fixes: 4602dce0361e ("mfd: cros_ec: Add cros-usbpd-notify subdevice")
> > >
> >
> > Now that v7 from mfd side was merged and v8 from platform side was merged, could
> > you resend this specific patch alone collecting all the fixes and tested tags. I
> > guess will be more clear for mfd people.
> >
> >
> > Sounds good. Should I maintain the same versioning and series info i.e v9 3/4?
> > Or just v9?
> >
>
> I'd do "[PATCH RESEND] mfd: cros_ec: Check DT node for usbpd-notify add" and
> then after the "---" explain that you are resending this alone because the other
> patches are already applied, and reference this patch series.
Got it. Will re-send across the patch now.
Thanks!
>
> > Thanks,
> >
> > Thanks,
> > Enric
> >
> > >> ---
> > >>
> > >> Changes in v8:
> > >> - Patch first introduced in v8 of the series.
> > >>
> > >> drivers/mfd/cros_ec_dev.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > >> index d0c28a4c10ad0..411e80fc9a066 100644
> > >> --- a/drivers/mfd/cros_ec_dev.c
> > >> +++ b/drivers/mfd/cros_ec_dev.c
> > >> @@ -212,7 +212,7 @@ static int ec_device_probe(struct platform_device *pdev)
> > >> * explicitly added on platforms that don't have the PD notifier ACPI
> > >> * device entry defined.
> > >> */
> > >> - if (IS_ENABLED(CONFIG_OF)) {
> > >> + if (IS_ENABLED(CONFIG_OF) && ec->ec_dev->dev->of_node) {
> > >> if (cros_ec_check_features(ec, EC_FEATURE_USB_PD)) {
> > >> retval = mfd_add_hotplug_devices(ec->dev,
> > >> cros_usbpd_notify_cells,
> > >>
> >
next prev parent reply other threads:[~2020-02-10 19:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 23:18 [PATCH v8 1/4] platform: chrome: Add cros-usbpd-notify driver Prashant Malani
2020-01-24 23:18 ` [PATCH v8 2/4] mfd: cros_ec: Add cros-usbpd-notify subdevice Prashant Malani
2020-01-24 23:18 ` [PATCH v8 3/4] mfd: cros_ec: Check DT node for usbpd-notify add Prashant Malani
2020-01-27 14:50 ` Enric Balletbo i Serra
2020-02-10 10:11 ` Enric Balletbo i Serra
[not found] ` <CACeCKadtoAA0z88dYy3O-tQE=KLpR5Rx=ZXkkEKyhnAsKyqzjw@mail.gmail.com>
2020-02-10 16:38 ` Enric Balletbo i Serra
2020-02-10 18:59 ` Prashant Malani [this message]
2020-02-24 10:27 ` Lee Jones
2020-01-24 23:18 ` [PATCH v8 4/4] power: supply: cros-ec-usbpd-charger: Fix host events Prashant Malani
2020-01-27 14:58 ` [PATCH v8 1/4] platform: chrome: Add cros-usbpd-notify driver Enric Balletbo i Serra
2020-01-27 17:19 ` Prashant Malani
2020-01-27 18:44 ` Benson Leung
2020-01-29 1:11 ` Prashant Malani
2020-01-29 8:37 ` Enric Balletbo i Serra
2020-02-03 23:42 ` Benson Leung
2020-02-04 0:40 ` Prashant Malani
2020-02-10 1:24 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACeCKacwg2gapH7MjByg76qrbh0CvQJ9tftr+ot+NzrMUjXGKA@mail.gmail.com \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).