From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A3BC43215 for ; Mon, 18 Nov 2019 08:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CC8020727 for ; Mon, 18 Nov 2019 08:52:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=endlessm-com.20150623.gappssmtp.com header.i=@endlessm-com.20150623.gappssmtp.com header.b="h+DlLwIY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726403AbfKRIwQ (ORCPT ); Mon, 18 Nov 2019 03:52:16 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:37950 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbfKRIwQ (ORCPT ); Mon, 18 Nov 2019 03:52:16 -0500 Received: by mail-qv1-f68.google.com with SMTP id q19so6187571qvs.5 for ; Mon, 18 Nov 2019 00:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=90C7hPp0jjaPYLe8/qhSTZ7vmNH4K6cF3RIbxB4NlI8=; b=h+DlLwIYPwkEGm7ZwxM9QJLnJfsunRWIedIWJ9B3S7ojb1/F7YdnBvGfpCWtt2P6eE ZHN9kG3Fa8IBk9MopizRa68GDkKaxUIODQul193ZJ4n95myJmTqCaab7imPgHrruhtwh c9xP7YeXINGmtqGVaMBieRXt4fgzVhPTaibcqilhjpTPndqwFNazKjFwVxX2wOCTRcN4 k4CIUGjRLoQcM9SWQCl3r7Y5GAGb1LKWQmg7KTAtR4LW9kQ8Du0hgbXlcEkgtxP7Uqam KZ73heL7JguFUx9b73bmSdJkrJk1ceY85PzJZsMP0X49WMs5mAeG57IFT9mRkLgv9awm LGFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=90C7hPp0jjaPYLe8/qhSTZ7vmNH4K6cF3RIbxB4NlI8=; b=pZfQRXUP6qBMKwiV745V4RmsUMPn28/Fhk1z4mRqv59GVrFL4SojYsWxQztSzJAyVs HcVF/+8JydJogVukVxifTqV3s4pYK9Uc6kgKz/01nJfhYQBqqmzgxAUK8YW6yasCIK3B /y4IqO+nyI+U1CIoWdZK7sxH3fbEELeUurjjUsoXlV3oTe5njiKmcQaM79S0flMrlM9T gmZn1/RY78xTj74797UyB580yOp49wiMKAnUgIygyb3kwUyE1NDT7Cq/4mgBHQAvVyfe IGXaxCUk/YxdsUxOuv5ZC6S/zwyC93n7BrwoqZzdYxP3+a7OrfrTvEus00J8SHJtnuCp 73YQ== X-Gm-Message-State: APjAAAV24Tm5Mg+dEvnBAUK2lzb8wsH4WvABzr6Yd4oTma1NrDGgDEaX O9PQ1NhYaloRvc6VzgrXmFQJsoYV8Ad+YoS00Q2HWA== X-Google-Smtp-Source: APXvYqx4wlDkliAAM0cS02/2UUhvIK8zKh6KQrQBhzlkEtuIsELYprvnD3s0HH+9QRTRcCKli2zottiLXVwM9jiUuoI= X-Received: by 2002:a0c:bf4d:: with SMTP id b13mr3703586qvj.115.1574067134850; Mon, 18 Nov 2019 00:52:14 -0800 (PST) MIME-Version: 1.0 References: <20191025162814.GA130180@google.com> In-Reply-To: From: Daniel Drake Date: Mon, 18 Nov 2019 16:52:04 +0800 Message-ID: Subject: Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers To: Bjorn Helgaas Cc: Mika Westerberg , Linux PCI , "Wysocki, Rafael J" , Linux Upstreaming Team , Linux PM , Linux USB Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Bjorn, Any further ideas here? Do we go ahead with the quirk or try to find a more generic approach? On Mon, Oct 28, 2019 at 2:32 PM Daniel Drake wrote: > It looks like we can detect that the reset has failed (or more > precisely, not quite completed) by reading PCI_COMMAND (value not yet > 0) or PCI_PM_CTRL (doesn't yet indicate D0 state, we already log a > warning for this case). > > From that angle, another workaround possibility is to catch that case > and then retry the PCI_PM_CTRL write and delay once more. Thanks Daniel