From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18360C433E2 for ; Fri, 28 Aug 2020 15:06:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA926208C9 for ; Fri, 28 Aug 2020 15:06:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="G8e1hSdW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbgH1PGX (ORCPT ); Fri, 28 Aug 2020 11:06:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbgH1PGR (ORCPT ); Fri, 28 Aug 2020 11:06:17 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A3EEC061264 for ; Fri, 28 Aug 2020 08:06:17 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id h19so464224ual.10 for ; Fri, 28 Aug 2020 08:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XP81KhbFfFMLjt/9HZBr2wWZSwrB3/aa9mKjEXE/AKE=; b=G8e1hSdWLuYEJPV3B0RaF3rvGxxGkCTIF80d31pPr9iF136sww25RkRnSUV+j1AcVv H9OJX1KXsDnaVLCtVvW7DPjEh69HZSR8Wupn9bRJ83yTG9C9qa0dn2v0dqy+eonTsPmp MohmqV0MA4Mfl9vG7cBkhQAXWLoMyULgQUxkw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XP81KhbFfFMLjt/9HZBr2wWZSwrB3/aa9mKjEXE/AKE=; b=ipZXVF/z1SOc4J0bxnQ1EK6TWT00cG8QIJMUxvBifwy+on7qcYkajiuVE40a1zsV/i 4Kdj+j7xIvlviDxtiCtcGVibVFS7LKdTS+xLoR5oOvBi4dKbPd38pZUTlqKz81jnarE7 NB9L+H7sminMTwZfvJO8tiwvTapfTLo8XMzqTsgdIco74tjaGeygJOVSAHMgvOETebJ1 LfFqS0v0DawkeWWXn48x2tkbZsE4wcOK3nXFPq/PYjk3yxIKkunnnj3qRwAluUoQeim6 SLTdUes5eew8t3sR3bFJtCShgniCH3ipRG6CjtXDPqqJnt9OvxmvKJa1QBUTg2YUNGkV 6CZg== X-Gm-Message-State: AOAM533/j+z99+ce2gZTTKlG1ZBNwZtVBUscsQJZqye6jDnIpJRi3q9X DWfGSXH51Q1lDhzHewewffzgl6WKQAQjyQ== X-Google-Smtp-Source: ABdhPJys0PPLY9jZbfACZBrBavj3xPjFYCddAf7HHluDmyEJtDLIJe7YzLHxmlBmNxZMEaocQ8xZXA== X-Received: by 2002:ab0:40a6:: with SMTP id i35mr1470447uad.105.1598627176308; Fri, 28 Aug 2020 08:06:16 -0700 (PDT) Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com. [209.85.217.42]) by smtp.gmail.com with ESMTPSA id 23sm156449vkw.25.2020.08.28.08.06.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2020 08:06:15 -0700 (PDT) Received: by mail-vs1-f42.google.com with SMTP id y140so429663vsc.3 for ; Fri, 28 Aug 2020 08:06:15 -0700 (PDT) X-Received: by 2002:a05:6102:10de:: with SMTP id t30mr1312397vsr.13.1598627175058; Fri, 28 Aug 2020 08:06:15 -0700 (PDT) MIME-Version: 1.0 References: <1d7c97524b9e1fbc60271d9c246c5461ca8a106c.1598594714.git.viresh.kumar@linaro.org> In-Reply-To: From: Doug Anderson Date: Fri, 28 Aug 2020 08:06:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table() To: Ulf Hansson Cc: Viresh Kumar , Rajendra Nayak , Adrian Hunter , Andy Gross , Bjorn Andersson , Linux PM , Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Naresh Kamboju , linux-arm-msm , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On Fri, Aug 28, 2020 at 1:44 AM Ulf Hansson wrote: > > On Fri, 28 Aug 2020 at 08:08, Viresh Kumar wrote: > > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > the device). And we can call dev_pm_opp_of_remove_table() > > unconditionally here. > > > > Signed-off-by: Viresh Kumar > > Replaced v1 with v2 on my next branch, thanks! Actually, I don't see it on there yet, but at least the old broken v1 isn't there anymore. ;-) I picked v2 and tried it on my sc7180-based device (which does have OPP tables). It worked fine. Thus: Tested-by: Douglas Anderson I looked at the code and it looks right to me. Thus: Reviewed-by: Douglas Anderson > Just to be sure, this patch doesn't depend on any changes for the opp > core that are queued for v5.10? Running atop mmc-next, I see the check for -ENODEV, so I'm gonna assume that the required change is there. $ git grep -A10 'void _dev_pm_opp_find_and_remove_table' -- drivers/opp/core.c drivers/opp/core.c:void _dev_pm_opp_find_and_remove_table(struct device *dev) drivers/opp/core.c-{ drivers/opp/core.c- struct opp_table *opp_table; drivers/opp/core.c- drivers/opp/core.c- /* Check for existing table for 'dev' */ drivers/opp/core.c- opp_table = _find_opp_table(dev); drivers/opp/core.c- if (IS_ERR(opp_table)) { drivers/opp/core.c- int error = PTR_ERR(opp_table); drivers/opp/core.c- drivers/opp/core.c- if (error != -ENODEV) drivers/opp/core.c- WARN(1, "%s: opp_table: %d\n",