From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9046AC433FE for ; Wed, 16 Feb 2022 17:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237128AbiBPReR (ORCPT ); Wed, 16 Feb 2022 12:34:17 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237125AbiBPReR (ORCPT ); Wed, 16 Feb 2022 12:34:17 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EBD5222182 for ; Wed, 16 Feb 2022 09:34:04 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id h16so520598iol.11 for ; Wed, 16 Feb 2022 09:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NabgQQsJH6X4TlMYnFn6QKKl4Vhu4efuUjjjXfJ7lgQ=; b=dsj9GnWa++50RRrfwADJFF/o/2xUy5SXce8mZRDSEslyWwm7KHBXT56e43oz/709yQ v6saAUnzbVJhjV866YrKpAvUNAqwFYjn+5AgFFwx9D58EMUeHX/g43j3II9/r5rQUbF6 V8RdxhwLOzhhmc3RRL6JvuABsDiRaVSPwjpYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NabgQQsJH6X4TlMYnFn6QKKl4Vhu4efuUjjjXfJ7lgQ=; b=sk6wpu8A/Z3Ixzn+nTodcqPLQwaxScBQRtbgQuQOj5hS9WUdJVii59Dd1EFOR2EoYK bAOOhGeuJeMLV852vvhyx7aKHlSzGhqTO4Qt1vxykr5mbl6eyeOEGBRM0t0h5Lxj0EWg RLbL/m/u9I67bpT7R0a9WAP3Pgsuvbmpyp8jEViginTzEwGsiOhdy9mHl+NP4IRP0WiV O7grcAnia6r5ghJQKbYS+3YHCwKI+pFXUOfWk9T8/Up3w7r4+4rbkUtaXjlg6SvxGtAI 80bwepr5ZDyAT8ih1K4uabPSfAbMIj8DfAiEpPbtCzlSRK9x9foGXwOde3bsGRBJwOK4 Mxzg== X-Gm-Message-State: AOAM533v0vk4qqxpi+nkhlL+CuSNWFHNH8SRh8HqjPACvGTxLidByPuh aGGC50akVVg6aACn1e6TPz9EdQ+lJRP8zw== X-Google-Smtp-Source: ABdhPJzaH+Co8T/pVjiMsuMpHNrFocP9LK3clj40BB1+ECnKiT0SMs975siTgRS3PE0oXB/izfoLJA== X-Received: by 2002:a05:6638:2102:b0:313:e481:6fef with SMTP id n2-20020a056638210200b00313e4816fefmr2308601jaj.231.1645032843805; Wed, 16 Feb 2022 09:34:03 -0800 (PST) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com. [209.85.166.43]) by smtp.gmail.com with ESMTPSA id j15sm210578ile.6.2022.02.16.09.34.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 09:34:03 -0800 (PST) Received: by mail-io1-f43.google.com with SMTP id c18so102230ioh.0 for ; Wed, 16 Feb 2022 09:34:02 -0800 (PST) X-Received: by 2002:a6b:ed01:0:b0:635:2020:c11 with SMTP id n1-20020a6bed01000000b0063520200c11mr2514847iog.136.1645032842511; Wed, 16 Feb 2022 09:34:02 -0800 (PST) MIME-Version: 1.0 References: <20220207073036.14901-1-lukasz.luba@arm.com> <20220207073036.14901-2-lukasz.luba@arm.com> <4a7d4e94-1461-5bac-5798-29998af9793a@arm.com> In-Reply-To: From: Doug Anderson Date: Wed, 16 Feb 2022 09:33:50 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling To: Lukasz Luba Cc: Matthias Kaehlcke , LKML , Linux PM , amit daniel kachhap , Daniel Lezcano , Viresh Kumar , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Dietmar Eggemann , Pierre.Gondois@arm.com, Stephen Boyd , Rajendra Nayak , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On Wed, Feb 16, 2022 at 7:35 AM Lukasz Luba wrote: > > Hi Matthias, > > On 2/9/22 10:17 PM, Matthias Kaehlcke wrote: > > On Wed, Feb 09, 2022 at 11:16:36AM +0000, Lukasz Luba wrote: > >> > >> > >> On 2/8/22 5:25 PM, Matthias Kaehlcke wrote: > >>> On Tue, Feb 08, 2022 at 09:32:28AM +0000, Lukasz Luba wrote: > >>>> > >>>> > > [snip] > > >>>> Could you point me to those devices please? > >>> > >>> arch/arm64/boot/dts/qcom/sc7180-trogdor-* > >>> > >>> Though as per above they shouldn't be impacted by your change, since the > >>> CPUs always pretend to use milli-Watts. > >>> > >>> [skipped some questions/answers since sc7180 isn't actually impacted by > >>> the change] > >> > >> Thank you Matthias. I will investigate your setup to get better > >> understanding. > > > > Thanks! > > > > I've checked those DT files and related code. > As you already said, this patch is safe for them. > So we can apply it IMO. > > > -------------Off-topic------------------ > Not in $subject comments: > > AFAICS based on two files which define thermal zones: > sc7180-trogdor-homestar.dtsi > sc7180-trogdor-coachz.dtsi > > only the 'big' cores are used as cooling devices in the > 'skin_temp_thermal' - the CPU6 and CPU7. > > I assume you don't want to model at all the power usage > from the Little cluster (which is quite big: 6 CPUs), do you? > I can see that the Little CPUs have small dyn-power-coeff > ~30% of the big and lower max freq, but still might be worth > to add them to IPA. You might give them more 'weight', to > make sure they receive more power during power split. > > You also don't have GPU cooling device in that thermal zone. > Based on my experience if your GPU is a power hungry one, > e.g. 2-4Watts, you might get better results when you model > this 'hot' device (which impacts your temp sensor reported value). I think the two boards you point at (homestar and coachz) are just the two that override the default defined in the SoC dtsi file. If you look in sc7180.dtsi you'll see 'gpuss1-thermal' which has a cooling map. You can also see the cooling maps for the littles. I guess we don't have a `dynamic-power-coefficient` for the GPU, though? Seems like we should, but I haven't dug through all the code here... -Doug