From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A9CC76186 for ; Tue, 23 Jul 2019 16:57:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 378FE22543 for ; Tue, 23 Jul 2019 16:57:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="m/AmoBeO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730952AbfGWQ5H (ORCPT ); Tue, 23 Jul 2019 12:57:07 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:45677 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730322AbfGWQ5H (ORCPT ); Tue, 23 Jul 2019 12:57:07 -0400 Received: by mail-qt1-f195.google.com with SMTP id x22so37684305qtp.12 for ; Tue, 23 Jul 2019 09:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bctZIRJmF0Tt66epBoIW8Nv3zbBghWNg0cSJA3lvz58=; b=m/AmoBeOCFr0QaZjltESdsZE4fOROqUL06GHXh0L+7fh+af27xkAW20v/yQphJ2PRI 6VjowW5mw+hZQYU1tset+mrRNA/vq5KMxhiR3MJetGBuySXEu80cNuztkUafdZ1Fr5uI Ow1mCKVOl7XYDOObd5P0WXvNLA6IvVjUBX8vw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bctZIRJmF0Tt66epBoIW8Nv3zbBghWNg0cSJA3lvz58=; b=VbltzEDl6mM5ScoLTWo6gwStmsNfQj+zebQCsBTckJY9BFND2rGe61MB+OUSg4OXBN rKIxgLXBTJyWSrjAMz0lQ5zaNIUDFLuIsvSuTL+X0MTGORkH6j1YKGB65ygwllxZeA/j CZRWOLB521vxv7tC2RqSOpy1Y/xICSJWOd/MN4m59QbTUWDGXiQUhw57zC80ISWxoVXz Dxb+pqSIBidD9aayWZWNmbaMjzcqT3helBwmK2G7ah2feKe21BdK+UW9Z14ZiFbcOeOg pDC+pnNcikY8bPjGxKWla2ThxLtjHxZbwSj4VxqTWmfQqRw2aNwcO9iwcIVUVOwmMpZp NVbg== X-Gm-Message-State: APjAAAU6gA+gVKhuSJqfOmr0Eq7BQqjtSySQ+bBuwHdVXan//eToTskJ 4P+oLbgj5vztrG48oZcqs9zNIn2G7O0atM3mC2sbRw== X-Google-Smtp-Source: APXvYqx7dnBZ7AYtOXCbCEB1ql70DdqBWrp5Cp3QwgfTdYFMK1cTaFd7Gg8L91xqsBe3NjLBTDRcue8FC5XAS9tIjrM= X-Received: by 2002:aed:3742:: with SMTP id i60mr53528186qtb.376.1563901026650; Tue, 23 Jul 2019 09:57:06 -0700 (PDT) MIME-Version: 1.0 References: <20190722182451.GB24412@kroah.com> <20190722223337.36199-1-ravisadineni@chromium.org> In-Reply-To: From: Ravi Chandra Sadineni Date: Tue, 23 Jul 2019 09:56:55 -0700 Message-ID: Subject: Re: [PATCH 0/2] power: Refactor device level sysfs. To: "Rafael J. Wysocki" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Baoquan He , Dave Young , Linux Kernel Mailing List , Linux PM , Todd Broch Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Greg, https://patchwork.kernel.org/patch/11045069/ seems to create a virtual device under wakeup class with the same name as the actual device. I don't see a way to reliably map these virtual devices to the actual device sysfs node. For example if we have to know if a particular input device has triggered a wake event, we have to look for a virtual device under /sys/class/wakeup with the same name. I am afraid that depending just on the name might be too risky as there can be multiple devices under different buses with the same name. Am I missing something? Thanks, Ravi On Tue, Jul 23, 2019 at 12:44 AM Rafael J. Wysocki wrote: > > On Tue, Jul 23, 2019 at 12:33 AM Ravi Chandra Sadineni > wrote: > > > > wakeup_abort_count and wakeup_count attributes print the > > same (wakeup_count) variable. Thus this patchset removes the > > duplicate wakeup_abort_count sysfs attribute. This patchset also > > exposes event_count as a sysfs attribute. > > > > Ravi Chandra Sadineni (2): > > power: sysfs: Remove wakeup_abort_count attribute. > > power:sysfs: Expose device wakeup_event_count. > > I don't think you need this at all, because > https://patchwork.kernel.org/patch/11045069/ is exposing what you need > already. > > Thanks!