From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B6EC433E6 for ; Thu, 25 Feb 2021 16:22:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F404364ED3 for ; Thu, 25 Feb 2021 16:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233207AbhBYQWx (ORCPT ); Thu, 25 Feb 2021 11:22:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233671AbhBYQWh (ORCPT ); Thu, 25 Feb 2021 11:22:37 -0500 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87426C06174A for ; Thu, 25 Feb 2021 08:21:56 -0800 (PST) Received: by mail-yb1-xb34.google.com with SMTP id d9so5973406ybq.1 for ; Thu, 25 Feb 2021 08:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/cP36naQj3qpC5i/IheYs6HlbPebR0MpDFfVJ183xi8=; b=KeDpl/ntLDJO0xHlFgkxocqJLerEAuvIJ2EY3GHp0W3hUj+P/H80wjBdRtEMG9I6mk mOgnF2arVx72Klh9ceuX9/gZrNp086hN7VWSm2CdPxWGVLlv/d3ygeohIOvkZz5l7Cyx ZhFxLDCDeov/Avb6rWbqVkBHPzx5KAcHND5L3Oyd1ikRLLXkV4M2h1M2rxeBlmXO1FzC h6wigFdFrnCmS2Ta1BenFcqq3z1TeWEZYayefvy101cUxA4uZ/76DzbLiVB0QDg4ef1t RT0ZhWM3jjPl7MNJayNpq84oFbz/wj7Vm1HMTE9TGejYbOcy+PrX9l5mI0z5Sz0KgvLo ksGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/cP36naQj3qpC5i/IheYs6HlbPebR0MpDFfVJ183xi8=; b=Nj6KxAFSmo5x/3pG0wLMAeU26den+Pi/H8T92YsWMOvHWKtN7KNan/Rs3NXRDMjZR4 Fnj6Xfz/CZ/2VisA0g6Rt1asHBPxNVtA5rs2+29RBoy7OWOWEN01tf4z4Hh4ePxIBOT9 uo25nJ8q13ZNR5AS5ls7N694pGCueuBb5D4lHMf4gZfh0tuB24uCrXzjeF8pR9z1ejga nTxRf1WMNTyOapts4oL0aOuTivs/5SFTp8b7k3HjZutgnFhSo1ZEFaXHKndmE8G5jzat iPunwV6rXJJR4eIvdmWf4bgmTLP/cYSE1EmAdzDyAnoLXztTAV7QkGBgV1K+HnIfM1iG QH+w== X-Gm-Message-State: AOAM530ObAAWB0V2L/V1qtlPYV1d1CX/CYRjqc8LxR2EtDku2+GaASTs kKm1KbhoC5f2uLH/ZDLt8G1pL1hc2XkuTG4gOydgMA== X-Google-Smtp-Source: ABdhPJwM8YNyUIdNGpLL8VN5EQjunqmqzPDS5sX6h/EAdG7KRABzywLAjcwqJL7G07M7ZbMubkIt94W1wIhCADUnp+I= X-Received: by 2002:a25:aa43:: with SMTP id s61mr5354227ybi.32.1614270115514; Thu, 25 Feb 2021 08:21:55 -0800 (PST) MIME-Version: 1.0 References: <20210215151405.2551143-1-geert+renesas@glider.be> In-Reply-To: From: Saravana Kannan Date: Thu, 25 Feb 2021 08:21:19 -0800 Message-ID: Subject: Re: [PATCH] staging: board: Fix uninitialized spinlock when attaching genpd To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Bartosz Golaszewski , "Rafael J . Wysocki" , Kevin Hilman , Ulf Hansson , Magnus Damm , Linux-Renesas , Linux PM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Feb 25, 2021 at 1:25 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Mon, Feb 15, 2021 at 10:03 PM Saravana Kannan wrote: > > On Mon, Feb 15, 2021 at 11:10 AM Geert Uytterhoeven > > wrote: > > > On Mon, Feb 15, 2021 at 7:37 PM Saravana Kannan wrote: > > > > On Mon, Feb 15, 2021 at 7:14 AM Geert Uytterhoeven > > > > > @@ -148,7 +149,11 @@ static int board_staging_add_dev_domain(struct platform_device *pdev, > > > > > pd_args.np = np; > > > > > pd_args.args_count = 0; > > > > > > > > > > - return of_genpd_add_device(&pd_args, &pdev->dev); > > > > > + /* Cfr. device_pm_init_common() */ > > > > > > > > What's Cfr? > > > > > > "compare to" (from Latin "confer"). > > > > Can you please change this to "refer to" or "similar to"? Also, not > > sure if this comment is even adding anything useful even if you switch > > the words. > > I changed it to "Initialization similar to device_pm_init_common()" > > > Also, device_pm_init_common() is used in two places outside of > > drivers/base/ with this change. Maybe better to move it to > > linux/device.h? > > arch/sh/drivers/platform_early.c has a separate definition, and this > is intentional, cfr. commit 507fd01d53333387 ("drivers: move the early > platform device support to arch/sh"): > > In order not to export internal drivers/base functions to arch code for > this temporary solution - copy the two needed routines for driver > matching from drivers/base/platform.c to arch/sh/drivers/platform_early.c. > Thanks. The comments and decision to copy the code sounds okay to me. But I'll still leave the Ack/Review to Rafael or someone else as I'm not too familiar with the intent of this flag. -Saravana