From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F14C3A59C for ; Fri, 16 Aug 2019 01:54:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EEE82089E for ; Fri, 16 Aug 2019 01:54:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="c1eMypNZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726441AbfHPBy5 (ORCPT ); Thu, 15 Aug 2019 21:54:57 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:45689 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbfHPBy5 (ORCPT ); Thu, 15 Aug 2019 21:54:57 -0400 Received: by mail-ot1-f66.google.com with SMTP id m24so8170679otp.12 for ; Thu, 15 Aug 2019 18:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eTBLiXSIuUXd+8NGvTkyeSPJUrRK2Bbf1LlrvKYe2Bs=; b=c1eMypNZciY3A2RHemaEo3MmOwfU81fQPf4Ro35MWp58GOMiksnAuGWsDOvT0vTD+J Pm152McXNZ+R6kJnBaQIfMXt/hqzfaC/RbQpbN39NVCIZxh8bdHEbKRicdwbMZc0HBHk 17wMxwDScDGZzYn/fQGKtBfPD1xtCA+DNNQKHetV/Xe0APpTarYVOx7uaAUsuuvDUuXo HqwjEouJ87uP1+nOMyVs/nVupjeWmscIqx71esKyhyQ+T9GBYzR3wuGetPH0IdSO57Ia BihlodiAuEXo3zgM6pulsz5sM70nnEVS9t5y9L9GT2Kkygo9ae24fU9+aKKnGmSQL7g4 siCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eTBLiXSIuUXd+8NGvTkyeSPJUrRK2Bbf1LlrvKYe2Bs=; b=en3uUcpzlglrVXjYix8NdRWVdzDGqn6wfCOSeZzICzgU8SGepxldlRE9CJf1NbdHBy 64mgIz4qAhMNyg2dc9kh0Tvuxg4POfKSb4n/ugrxTzgRDXquRGSnTgzEArrK06w2IGIN jAbzsGF1nyaOLh2m7fHZgrQ/P8CV391KCDU+lOf5vyRPJR/uexCOWt5oxmWBDGtRRhZz rBwXIkPgRxx+Oh/TWjE9pQpwB6QuNAd/+Q5HMN+uJYOYlsmshMZakwwq32kQ8och8aO/ aUqxMmt8xGmqC+i2iLvwxDXy4FcrZaq3+yHGFqb6dY7XrA5SOqAQuXkDlmP9ICLj3wn7 zweg== X-Gm-Message-State: APjAAAUPG6GtuFVGyDJRmjtkJtwyzY4aELA5y032Pym5ebxK6S2anv0U h4Qqwv7IWf4xjl+Tr5+DtU14jxT0e9YkOiITJbmEzA== X-Google-Smtp-Source: APXvYqyIhzjv/mzlBeEGYrBrvhv6vf4+oF36WPPG9u45hKnTlVMFItiKqprxNUbwc41ChxrtOG+Tn0kFOtTd7SBW3Zc= X-Received: by 2002:a05:6830:1e0f:: with SMTP id s15mr6147817otr.231.1565920495218; Thu, 15 Aug 2019 18:54:55 -0700 (PDT) MIME-Version: 1.0 References: <20190807223111.230846-1-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Thu, 15 Aug 2019 18:54:19 -0700 Message-ID: Subject: Re: [PATCH v5 0/3] Introduce Bandwidth OPPs for interconnects To: Georgi Djakov Cc: Rob Herring , Mark Rutland , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Vincent Guittot , "Sweeney, Sean" , David Dai , adharmap@codeaurora.org, Rajendra Nayak , Sibi Sankar , Bjorn Andersson , Evan Green , Android Kernel Team , Linux PM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Aug 15, 2019 at 9:19 AM Georgi Djakov wrote: > > Hi, > > On 8/8/19 01:31, Saravana Kannan wrote: > > Interconnects and interconnect paths quantify their performance levels in > > terms of bandwidth and not in terms of frequency. So similar to how we have > > frequency based OPP tables in DT and in the OPP framework, we need > > bandwidth OPP table support in DT and in the OPP framework. > > > > So with the DT bindings added in this patch series, the DT for a GPU > > that does bandwidth voting from GPU to Cache and GPU to DDR would look > > something like this: > > > > gpu_cache_opp_table: gpu_cache_opp_table { > > compatible = "operating-points-v2"; > > > > gpu_cache_3000: opp-3000 { > > opp-peak-KBps = <3000000>; > > opp-avg-KBps = <1000000>; > > }; > > gpu_cache_6000: opp-6000 { > > opp-peak-KBps = <6000000>; > > opp-avg-KBps = <2000000>; > > }; > > gpu_cache_9000: opp-9000 { > > opp-peak-KBps = <9000000>; > > opp-avg-KBps = <9000000>; > > }; > > }; > > > > gpu_ddr_opp_table: gpu_ddr_opp_table { > > compatible = "operating-points-v2"; > > > > gpu_ddr_1525: opp-1525 { > > opp-peak-KBps = <1525000>; > > opp-avg-KBps = <452000>; > > }; > > gpu_ddr_3051: opp-3051 { > > opp-peak-KBps = <3051000>; > > opp-avg-KBps = <915000>; > > }; > > gpu_ddr_7500: opp-7500 { > > opp-peak-KBps = <7500000>; > > opp-avg-KBps = <3000000>; > > }; > > }; > > > > gpu_opp_table: gpu_opp_table { > > compatible = "operating-points-v2"; > > opp-shared; > > > > opp-200000000 { > > opp-hz = /bits/ 64 <200000000>; > > }; > > opp-400000000 { > > opp-hz = /bits/ 64 <400000000>; > > }; > > }; > > > > gpu@7864000 { > > ... > > operating-points-v2 = <&gpu_opp_table>, <&gpu_cache_opp_table>, <&gpu_ddr_opp_table>; > > ... > > }; > > > > v1 -> v3: > > - Lots of patch additions that were later dropped > > v3 -> v4: > > - Fixed typo bugs pointed out by Sibi. > > - Fixed bug that incorrectly reset rate to 0 all the time > > - Added units documentation > > - Dropped interconnect-opp-table property and related changes > > v4->v5: > > - Replaced KBps with kBps > > - Minor documentation fix > > > > Cheers, > > Saravana > > > > Saravana Kannan (3): > > dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings > > OPP: Add support for bandwidth OPP tables > > OPP: Add helper function for bandwidth OPP tables > > > > Documentation/devicetree/bindings/opp/opp.txt | 15 ++++-- > > .../devicetree/bindings/property-units.txt | 4 ++ > > drivers/opp/core.c | 51 +++++++++++++++++++ > > drivers/opp/of.c | 41 +++++++++++---- > > drivers/opp/opp.h | 4 +- > > include/linux/pm_opp.h | 19 +++++++ > > 6 files changed, 121 insertions(+), 13 deletions(-) > > > > For the series: > Acked-by: Georgi Djakov Thanks Georgi. Rob and Viresh, We've settled on one format. Can you pull this series in please? Do you need me to resent the series with the Ack? Or can you put that in if you pull in this series? Thanks, Saravana