From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E555CC32750 for ; Tue, 30 Jul 2019 23:06:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFFC420679 for ; Tue, 30 Jul 2019 23:06:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WrAabiJo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbfG3XGU (ORCPT ); Tue, 30 Jul 2019 19:06:20 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:38580 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727318AbfG3XGT (ORCPT ); Tue, 30 Jul 2019 19:06:19 -0400 Received: by mail-ot1-f66.google.com with SMTP id d17so68176936oth.5 for ; Tue, 30 Jul 2019 16:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GWk710+kd17q1OMPpu/V4kqYNuYX+KuVsErBpC5nLIk=; b=WrAabiJo3Dd0TtRAdJPNb1JBiYkFvBRm3vSWFQpJ+gwuoytfTPfI3f8PTELhhVKlyD Rhp07QkokIAzB6efv9wY6sdxtKIkuJTwvqZULuS9AfQ1pK3jcRPLwP5gxssPI/Ugw1H3 tBK4pFecWaDN42C5f8c1CnMEoWW0vrwdcxuHjvtXSAvbkbAKwVQhmLFLECySRswMmtCs iJftiD9zxs5YSMoAkdp/M78U764JOqBiJhvvhAplQjacULBgh1O+teQhg2blsWFp540R 8ZQSCjurivZoKK0qnm1XrlEo+kzJzeohTGG8uFoxO5TFALHfsShQTJ6Ae71NzRVe9gon H+xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GWk710+kd17q1OMPpu/V4kqYNuYX+KuVsErBpC5nLIk=; b=IxpGnvJEcSVXX1feLyiy7pRAei0fqb+08xFhJjPeIDSuYDlvGv1/c4RZuxtfv2cp7f eq6iSmjpPA6VHLhg0z1MJKcxf6GlyDYfijWWz95GVqvC/F8BTZrHN8i9mp3evPiD42bN PMFqTGlf3TF7VAtSV0a9nGeeGoGlE4FJz4/J3b45vzuF5jzL0J8w8WxzVothrTPRQvEV y2ZN2gFexkOnDBiIPCmxZrmBlyJxQLnFhz7gumO7S6qt3lsWaseoCkBMS0LDTz2oWc+N JdxB3LD+E+juvWx3L/yypl9JdVajLeEQ49a5ROq8j8P4Y1OQd+d6SdbBjmF21KJUS7UG KQkQ== X-Gm-Message-State: APjAAAX5LjLg5wO2nNmJXQ4dc7uBt2Ynujdt4gFOLePRjAAdOHvz/wvn LE2P04NeQUoFfEFBt4pIzi7AWAbStYNS9+GqafoaXg== X-Google-Smtp-Source: APXvYqwRZBGclW0RsoKetYGEdOPnQk2VEPJBoWqPKFhs6YkunF2OBOxQev4HLUxITQUhOPKxNUn5nu5CyC5NSPsHFsA= X-Received: by 2002:a05:6830:160c:: with SMTP id g12mr33175342otr.231.1564527978919; Tue, 30 Jul 2019 16:06:18 -0700 (PDT) MIME-Version: 1.0 References: <20190717222340.137578-1-saravanak@google.com> <20190717222340.137578-4-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Tue, 30 Jul 2019 16:05:43 -0700 Message-ID: Subject: Re: [PATCH v3 3/5] OPP: Improve require-opps linking To: Hsin-Yi Wang Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Sibi Sankar , Android Kernel Team , Linux PM , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 30, 2019 at 4:03 PM Hsin-Yi Wang wrote: > > On Wed, Jul 17, 2019 at 10:23 PM Saravana Kannan wrote: > > > -free_required_tables: > > - _opp_table_free_required_tables(opp_table); > > -put_np: > > - of_node_put(np); > > + for (i = 0; i < src->required_opp_count; i++) { > > + if (src->required_opp_tables[i]) > > + continue; > > + > > + req_np = of_parse_required_opp(src_opp->np, i); > > + if (!req_np) > > + continue; > > + > > + req_table = _find_table_of_opp_np(req_np); > Not yet tested in v4, but in v3: > In _find_table_of_opp_np(), there's a lockdep check: > lockdep_assert_held(&opp_table_lock); > which would lead to lockdep warnings. > > Call trace: > _find_table_of_opp_np > _of_lazy_link_required_tables > dev_pm_opp_xlate_opp Thanks for testing. I'll keep this in mind based on where the rest of the discussion goes. -Saravana