linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guilhem Lettron <guilhem@barpilot.io>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Len Brown <lenb@kernel.org>, Linux PM <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] intel_idle: Add ICL support
Date: Wed, 26 Aug 2020 15:03:52 +0200	[thread overview]
Message-ID: <CAGX5Wg2OOgY6d1RH514Kh9D6b+siga+jzH7qubcmE+ukq+6KKA@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0i8XUF39Vv=EM4TgyXgK6zHniZW3tGYFPweO3kg+BrxOQ@mail.gmail.com>

On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron <guilhem@barpilot.io> wrote:
> >
> > Use the same C-states as SKL
>
> Why is this change needed?

On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only
report "C1_ACPI", "C2_ACPI" and "C3_ACPI".
After this patch I have "C1", "C1E", "C6", "C7s", "C8", "C9" and "C10".

I tested for some time on idle (without any application launched) and
battery consumption drop ~1W/2W.

But it can be a measurement problem or different context. So don't
hesitate to tell me if I look wrong or if ACPI is a better option for
this specific processor family.

> > Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>
> > ---
> >  drivers/idle/intel_idle.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> > index 8e0fb1a5bdbd..1bb539f09a4f 100644
> > --- a/drivers/idle/intel_idle.c
> > +++ b/drivers/idle/intel_idle.c
> > @@ -1145,6 +1145,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
> >         X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L,          &idle_cpu_skl),
> >         X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE,            &idle_cpu_skl),
> >         X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X,           &idle_cpu_skx),
> > +       X86_MATCH_INTEL_FAM6_MODEL(ICELAKE,             &idle_cpu_skl),
> > +       X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_L,           &idle_cpu_skl),
> >         X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X,           &idle_cpu_icx),
> >         X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNL,        &idle_cpu_knl),
> >         X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNM,        &idle_cpu_knl),
> > --
> > 2.27.0
> >

  reply	other threads:[~2020-08-26 13:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 12:04 [PATCH] intel_idle: Add ICL support Guilhem Lettron
2020-08-26 12:43 ` Rafael J. Wysocki
2020-08-26 13:03   ` Guilhem Lettron [this message]
2020-08-26 13:09     ` Artem Bityutskiy
2020-08-26 13:19       ` Guilhem Lettron
2020-08-26 13:20       ` Rafael J. Wysocki
2020-08-26 13:16     ` Artem Bityutskiy
2020-08-26 13:18       ` Artem Bityutskiy
2020-08-26 13:21         ` Rafael J. Wysocki
2020-08-26 13:32         ` Guilhem Lettron
2020-08-26 13:41           ` Zhang Rui
2020-08-26 14:04             ` Guilhem Lettron
2020-08-26 16:02               ` Rafael J. Wysocki
2020-08-26 16:21                 ` Rafael J. Wysocki
2020-08-26 16:39                 ` Artem Bityutskiy
2020-08-26 16:43                   ` Rafael J. Wysocki
2020-08-26 16:46                     ` Guilhem Lettron
2020-08-26 17:00                       ` Rafael J. Wysocki
2020-08-26 17:47                         ` Zhang Rui
2020-08-26 16:52                     ` Artem Bityutskiy
2020-08-26 16:19               ` Artem Bityutskiy
2020-08-26 16:25                 ` Artem Bityutskiy
2020-08-26 16:28                   ` Artem Bityutskiy
2020-08-26 16:41                 ` Rafael J. Wysocki
     [not found]   ` <CAGX5Wg0655U71nFcaAJXmj1XMA3MjnCVn=q1Pf=7LLyryHhroQ@mail.gmail.com>
2020-08-26 13:17     ` Rafael J. Wysocki
2020-08-26 13:34       ` Guilhem Lettron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGX5Wg2OOgY6d1RH514Kh9D6b+siga+jzH7qubcmE+ukq+6KKA@mail.gmail.com \
    --to=guilhem@barpilot.io \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).