From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7567EC433E1 for ; Wed, 26 Aug 2020 13:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FA2520738 for ; Wed, 26 Aug 2020 13:04:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=barpilot-io.20150623.gappssmtp.com header.i=@barpilot-io.20150623.gappssmtp.com header.b="0PVwqfMp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730177AbgHZNEF (ORCPT ); Wed, 26 Aug 2020 09:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730172AbgHZNEE (ORCPT ); Wed, 26 Aug 2020 09:04:04 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62022C061756 for ; Wed, 26 Aug 2020 06:04:04 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id h4so2005661ioe.5 for ; Wed, 26 Aug 2020 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=barpilot-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sMxeFJHei2gYrYNqMG5h+XFJh32oQngK7oPyThCi2kc=; b=0PVwqfMpdny/+RG8OH5TGfK+xa3Fh9UNrAE35wFkj1RgEJq8nUxeGQ1UPdMYXiZ54H G+IWINHXPR35nb/I1HPbPOdTgyfBj7fsMhpuWSxVqaDRs4Kg3NmHiKuo4JJDkLSOyud4 9ahSCrH9regrNBhJNAJXLbejjgvVVDrNu7gE0XVICASPX2Gnj2k/qbRIIVDuraxCbaIV tQXvCT6ODVpsvmrSwVLR2BmA1G2x2ck/VZ+ft8eGLTzBd1ksYKdXR/czf9WCXsvHFQVR A00jCfbQUhEJktjUyXuXQlfjzqA1jivjvxGyQaV5DZyuZ8JkYdm38/CPlDCiofmZ33RE c2Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sMxeFJHei2gYrYNqMG5h+XFJh32oQngK7oPyThCi2kc=; b=ba0Pq8BhOkZdH+3FeyxbLdXLgl+DZ+fAype9We5ZXIOv32YEtwesoSiTsSFY/jQs86 BVdYYXTpoMWA22ngGb2c2PgpWZe9H33gGGL9d+/cWXFJzp+C7qbSdvaxCiS0gCEoYXTX BLvL5PkgaxcJZwoEBmpTWud3Mg+R/6dU98Ex26efPlPKabUUirLWD1yOqL2sbqk9+Ou8 KiANGQTgHTdhOchG2ooDzeETlZ/+gDVdszwYF6lFdYCrbByZUXlpuFtI5jffnEAd8dam 6UBosQlAV/Pu7P2m77BarnRvqDQBMmJSKDvy5lJIKFH5plLZxAKX85zerNr60JDb8Wr+ OfhQ== X-Gm-Message-State: AOAM53058shveoQCYpC+aeTz8FJLodsapIK6ox+884bQvhfvqJlZx5dZ MF8FEJGEcpWqoIphikddyPUsa8Is/XKAf5Z8ra5Whbc/0xwflD5z X-Google-Smtp-Source: ABdhPJziGcwZmYjXLUNH5+qDsoSHPELg0P9dzg6N2Tx/7MipE0ZmkH1freiHSR4cCbl2IriCsj0FkUeBMHnImwgA+vQ= X-Received: by 2002:a6b:2c1:: with SMTP id 184mr3045269ioc.137.1598447042854; Wed, 26 Aug 2020 06:04:02 -0700 (PDT) MIME-Version: 1.0 References: <20200826120421.44356-1-guilhem@barpilot.io> In-Reply-To: From: Guilhem Lettron Date: Wed, 26 Aug 2020 15:03:52 +0200 Message-ID: Subject: Re: [PATCH] intel_idle: Add ICL support To: "Rafael J. Wysocki" Cc: Jacob Pan , Len Brown , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > > > Use the same C-states as SKL > > Why is this change needed? On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only report "C1_ACPI", "C2_ACPI" and "C3_ACPI". After this patch I have "C1", "C1E", "C6", "C7s", "C8", "C9" and "C10". I tested for some time on idle (without any application launched) and battery consumption drop ~1W/2W. But it can be a measurement problem or different context. So don't hesitate to tell me if I look wrong or if ACPI is a better option for this specific processor family. > > Signed-off-by: Guilhem Lettron > > --- > > drivers/idle/intel_idle.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > > index 8e0fb1a5bdbd..1bb539f09a4f 100644 > > --- a/drivers/idle/intel_idle.c > > +++ b/drivers/idle/intel_idle.c > > @@ -1145,6 +1145,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = { > > X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L, &idle_cpu_skl), > > X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE, &idle_cpu_skl), > > X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, &idle_cpu_skx), > > + X86_MATCH_INTEL_FAM6_MODEL(ICELAKE, &idle_cpu_skl), > > + X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_L, &idle_cpu_skl), > > X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, &idle_cpu_icx), > > X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNL, &idle_cpu_knl), > > X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNM, &idle_cpu_knl), > > -- > > 2.27.0 > >