From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D6DC4740A for ; Mon, 9 Sep 2019 13:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26A7421924 for ; Mon, 9 Sep 2019 13:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kNHXD6JF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727007AbfIINcT (ORCPT ); Mon, 9 Sep 2019 09:32:19 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:41669 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbfIINcT (ORCPT ); Mon, 9 Sep 2019 09:32:19 -0400 Received: by mail-io1-f65.google.com with SMTP id r26so28566609ioh.8; Mon, 09 Sep 2019 06:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uNPO18E9u4VFHR5eE6QVM48gJTzLZL8W/Knzhp286xk=; b=kNHXD6JFZgQUAAdrzrOtXDHAaJeBL1xnN3iwN3mKbai6Q7jKlJxgRu39o/iTAD3TeH JvQH/prFlc7xMpZHQ9hPTCS7xrImCip45XKaKwayev6LJ0XxQdwiKuVS0NJTbQ/fdCA9 FV5FpGnJrjYoTzpr0PQYsYAjo493bmJpXO1qNDuiO8dV24MeTQyQ2wDdU+Q3ktLeMGYq lVYJ1vjR88/KtWt7zyDM1lxQFksTFp/6BgwKcTxAtl0ynEemsN44g/skL+sppOLiNvIc o4KmNbsK9gPlf0bt9xe3YyJ9Li4sQdRhj52vGN3VgAfRIXbIyO54otGYNOjHIJMEcr0N RivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uNPO18E9u4VFHR5eE6QVM48gJTzLZL8W/Knzhp286xk=; b=byFJoyiyhf/siJL9lvyV3xc7oIa1WhP3/UFd47yYW1MQCi7yd11t3BIDgwjX+W0wNN aF2ooUlaGCJynwvdvyM7wADxSVBVn/Wm5TY0wu/fAfxNh5ojHiF7EAHaiJjLDgNoWIN/ KQ8A1QkoLltCy/ae1/E7btRYtpFxbvFeP/Kh9Carvnq+jaZrKakWX9WMicF6dwTh4BhK TddS/A+z6vp0nkuGX/hqCqA8rZd+xPFInc0R3vJ9PvDtnMgSWf48l9dsy0lPw0IBdV3u jvInAZzH41eXb0/RKg38IVPeshAknpIqxcfxiAuQq6h1jG1g64Pnz/c+bVhG7uHk8NEt xIWw== X-Gm-Message-State: APjAAAWbQpFZw+kfn/IuUJtAuBdvgHiXqCo1L+tq7gX5Reh0iPFWl5QO AIJ+gkO6tQqAQ9ZvY2sIOCQ//Ns2DtY0ci8YJYw= X-Google-Smtp-Source: APXvYqwLFSwDFF4ktapBCBuY9u/0Yh7kqig52d6DQ/Kmcw1NR1FMw1oGhVlizUKzQqVuwAUlzoNX4hC9NZnYBHbbLbg= X-Received: by 2002:a02:b395:: with SMTP id p21mr26999521jan.52.1568035937967; Mon, 09 Sep 2019 06:32:17 -0700 (PDT) MIME-Version: 1.0 References: <20190814214319.24087-1-andreas@kemnade.info> In-Reply-To: From: Adam Ford Date: Mon, 9 Sep 2019 08:32:06 -0500 Message-ID: Subject: Re: [PATCH v2] regulator: twl: voltage lists for vdd1/2 on twl4030 To: Andreas Kemnade Cc: Tony Lindgren , Liam Girdwood , Mark Brown , Linux-OMAP , Linux Kernel Mailing List , linux-pm@vger.kernel.org, Stephen Boyd , Nishanth Menon , vireshk@kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Aug 15, 2019 at 5:47 AM Adam Ford wrote: > > On Wed, Aug 14, 2019 at 5:18 PM Andreas Kemnade wrote: > > > > _opp_supported_by_regulators() wrongly ignored errors from > > regulator_is_supported_voltage(), so it considered errors as > > success. Since > > commit 498209445124 ("regulator: core: simplify return value on suported_voltage") > > regulator_is_supported_voltage() returns a real boolean, so > > errors make _opp_supported_by_regulators() return false. > > > > That reveals a problem with the declaration of the VDD1/2 > > regulators on twl4030. > > The VDD1/VDD2 regulators on twl4030 are neither defined with > > voltage lists nor with the continuous flag set, so > > regulator_is_supported_voltage() returns false and an error > > before above mentioned commit (which was considered success) > > The result is that after the above mentioned commit cpufreq > > does not work properly e.g. dm3730. > > > > [ 2.490997] core: _opp_supported_by_regulators: OPP minuV: 1012500 maxuV: 1012500, not supported by regulator > > [ 2.501617] cpu cpu0: _opp_add: OPP not supported by regulators (300000000) > > [ 2.509246] core: _opp_supported_by_regulators: OPP minuV: 1200000 maxuV: 1200000, not supported by regulator > > [ 2.519775] cpu cpu0: _opp_add: OPP not supported by regulators (600000000) > > [ 2.527313] core: _opp_supported_by_regulators: OPP minuV: 1325000 maxuV: 1325000, not supported by regulator > > [ 2.537750] cpu cpu0: _opp_add: OPP not supported by regulators (800000000) > > > > The patch fixes declaration of VDD1/2 regulators by > > adding proper voltage lists. > > > > Fixes: 498209445124 ("regulator: core: simplify return value on suported_voltage") > > Cc: stable@vger.kernel.org > > Signed-off-by: Andreas Kemnade > > Tested-by: Adam Ford #logicpd-torpedo-37xx-devkit > I am not sure who the right maintainer is, but as of today, cpufreq for users of twl4030 on 5.3-RC8 is still broken without this patch. Is there any way it can be applied before the final release? thank you, adam > > --- > > resent because it was rejected by mailing lists, due to technical > > issues, sorry for the noise. > > changes in v2: > > using a proper voltage list instead of misusing the continuous flag > > subject was regulator: twl: mark vdd1/2 as continuous on twl4030 > > > > drivers/regulator/twl-regulator.c | 23 ++++++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c > > index 6fa15b2d6fb3..866b4dd01da9 100644 > > --- a/drivers/regulator/twl-regulator.c > > +++ b/drivers/regulator/twl-regulator.c > > @@ -359,6 +359,17 @@ static const u16 VINTANA2_VSEL_table[] = { > > 2500, 2750, > > }; > > > > +/* 600mV to 1450mV in 12.5 mV steps */ > > +static const struct regulator_linear_range VDD1_ranges[] = { > > + REGULATOR_LINEAR_RANGE(600000, 0, 68, 12500) > > +}; > > + > > +/* 600mV to 1450mV in 12.5 mV steps, everything above = 1500mV */ > > +static const struct regulator_linear_range VDD2_ranges[] = { > > + REGULATOR_LINEAR_RANGE(600000, 0, 68, 12500), > > + REGULATOR_LINEAR_RANGE(1500000, 69, 69, 12500) > > +}; > > + > > static int twl4030ldo_list_voltage(struct regulator_dev *rdev, unsigned index) > > { > > struct twlreg_info *info = rdev_get_drvdata(rdev); > > @@ -427,6 +438,8 @@ static int twl4030smps_get_voltage(struct regulator_dev *rdev) > > } > > > > static const struct regulator_ops twl4030smps_ops = { > > + .list_voltage = regulator_list_voltage_linear_range, > > + > > .set_voltage = twl4030smps_set_voltage, > > .get_voltage = twl4030smps_get_voltage, > > }; > > @@ -466,7 +479,8 @@ static const struct twlreg_info TWL4030_INFO_##label = { \ > > }, \ > > } > > > > -#define TWL4030_ADJUSTABLE_SMPS(label, offset, num, turnon_delay, remap_conf) \ > > +#define TWL4030_ADJUSTABLE_SMPS(label, offset, num, turnon_delay, remap_conf, \ > > + n_volt) \ > > static const struct twlreg_info TWL4030_INFO_##label = { \ > > .base = offset, \ > > .id = num, \ > > @@ -479,6 +493,9 @@ static const struct twlreg_info TWL4030_INFO_##label = { \ > > .owner = THIS_MODULE, \ > > .enable_time = turnon_delay, \ > > .of_map_mode = twl4030reg_map_mode, \ > > + .n_voltages = n_volt, \ > > + .n_linear_ranges = ARRAY_SIZE(label ## _ranges), \ > > + .linear_ranges = label ## _ranges, \ > > }, \ > > } > > > > @@ -518,8 +535,8 @@ TWL4030_ADJUSTABLE_LDO(VSIM, 0x37, 9, 100, 0x00); > > TWL4030_ADJUSTABLE_LDO(VDAC, 0x3b, 10, 100, 0x08); > > TWL4030_ADJUSTABLE_LDO(VINTANA2, 0x43, 12, 100, 0x08); > > TWL4030_ADJUSTABLE_LDO(VIO, 0x4b, 14, 1000, 0x08); > > -TWL4030_ADJUSTABLE_SMPS(VDD1, 0x55, 15, 1000, 0x08); > > -TWL4030_ADJUSTABLE_SMPS(VDD2, 0x63, 16, 1000, 0x08); > > +TWL4030_ADJUSTABLE_SMPS(VDD1, 0x55, 15, 1000, 0x08, 68); > > +TWL4030_ADJUSTABLE_SMPS(VDD2, 0x63, 16, 1000, 0x08, 69); > > /* VUSBCP is managed *only* by the USB subchip */ > > TWL4030_FIXED_LDO(VINTANA1, 0x3f, 1500, 11, 100, 0x08); > > TWL4030_FIXED_LDO(VINTDIG, 0x47, 1500, 13, 100, 0x08); > > -- > > 2.20.1 > >