From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBADC3A5A2 for ; Fri, 20 Sep 2019 21:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 903D92067B for ; Fri, 20 Sep 2019 21:43:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y41UWNhX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392783AbfITVnK (ORCPT ); Fri, 20 Sep 2019 17:43:10 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:45459 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392617AbfITVnJ (ORCPT ); Fri, 20 Sep 2019 17:43:09 -0400 Received: by mail-vs1-f66.google.com with SMTP id d204so5647387vsc.12 for ; Fri, 20 Sep 2019 14:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DsLE449MYN0lijunGmoaJH+J0lh52Nq00qDntzefXoo=; b=Y41UWNhXfoaLvFvHT2mK5PnQUDu2rsLdZVpGTzNyuAkQMu8tbTrR/zLCcF2rY4aTZ6 lfszb21KlSm+f2/ZQ2WXSn4tmBCbqbPo5kf1qEnnT9gmxwoD6WodV6ekHlj96UWiacrp QpugkSZICRkCQLCUiQ8BP6ekjlj0AwYL0agn5KeiOA9Sf0/VH0SEHoZb/21l1Eqt5pub cJ43PMl4W4FFT+vJAJoO17u9IuNKgx6aK1PZW8jBhWEtXMnzyW2Q68TfpS4BW2BmGFrz BJWz3H0Z7zaAtUvsUf7dwPr3Qvjyxlvt+OYmKzb7Qb1aCzpyDMrW66M2LKk4wZAOWMQ4 3Aug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DsLE449MYN0lijunGmoaJH+J0lh52Nq00qDntzefXoo=; b=APz0PC+KcnBGS6okiBRVTb1AaHV+KQRvA04ziQjLGq2zHPzfsmG0r/AEL8oLzON2Nz P3xj5FcnQI7LFgIBXQDyvk4mPbBpTCbbyfNpk2VSM41bH0VzkePF1hlKpyU4cFlkGYQa CN7CcFF/yjQ9youcZe7QgkvtBQS+pgJxCvVWPi5v0qEqcB6WnKB4lKvg1xBsv8dx5Oma aBCAxr6tt5WpylcCaNkJ6fc52aOEkrKtVZQJ/ujb3lUTtgYxOG99xg/SYuyGsJG0UBAT ONUjP8UG0RZ15IHLVEITO47H+FCDau9Tr3WS+agWl/FHijsUnKQMa9tdfsQKClnNjm8+ +Dng== X-Gm-Message-State: APjAAAVHAZTrh79Wv2Yp9rP02sJ9D9mMuNIDxp6VZ4lCIiV/GXx5N2sl QSdo8BmM2w3yTbDQWqekXDgWFdadz3YqdwPUnt92yQ== X-Google-Smtp-Source: APXvYqxqwvjtfbTFvURwOAkGiT1FsWywrL0zaIpbPwm+wwJzPOW+clQhLp9/KxIWk3c8VeHdjYcFDVe6vOxn0tYw7GQ= X-Received: by 2002:a67:6044:: with SMTP id u65mr3810616vsb.95.1569015788245; Fri, 20 Sep 2019 14:43:08 -0700 (PDT) MIME-Version: 1.0 References: <933f033298cbd7726a6c0b4b3b6cc7adc81784ba.1568185732.git.amit.kucheria@linaro.org> <20190917190619.GA9311@bogus> In-Reply-To: <20190917190619.GA9311@bogus> From: Amit Kucheria Date: Fri, 20 Sep 2019 14:42:57 -0700 Message-ID: Subject: Re: [PATCH v3 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema To: Rob Herring Cc: LKML , linux-arm-msm , Bjorn Andersson , Eduardo Valentin , Andy Gross , Brian Masney , Stephen Boyd , Daniel Lezcano , Mark Rutland , Zhang Rui , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Sep 17, 2019 at 12:06 PM Rob Herring wrote: > > On Wed, Sep 11, 2019 at 12:46:24PM +0530, Amit Kucheria wrote: > > Document interrupt support in the tsens driver by converting over to a > > YAML schema. > > > > Suggested-by: Stephen Boyd > > Signed-off-by: Amit Kucheria > > --- > > .../bindings/thermal/qcom-tsens.txt | 55 ------ > > .../bindings/thermal/qcom-tsens.yaml | 174 ++++++++++++++++++ > > MAINTAINERS | 1 + > > 3 files changed, 175 insertions(+), 55 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > create mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > new file mode 100644 > > index 000000000000..6784766fe58f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > @@ -0,0 +1,174 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +# Copyright 2019 Linaro Ltd. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: QCOM SoC Temperature Sensor (TSENS) > > + > > +maintainers: > > + - Amit Kucheria > > + > > +description: | > > + QCOM SoCs have TSENS IP to allow temperature measurement. There are currently > > + three distinct major versions of the IP that is supported by a single driver. > > + The IP versions are named v0.1, v1 and v2 in the driver, where v0.1 captures > > + everything before v1 when there was no versioning information. > > + > > +properties: > > + compatible: > > + oneOf: > > + - description: v0.1 of TSENS > > + items: > > + - enum: > > + - qcom,msm8916-tsens > > + - qcom,msm8974-tsens > > + - const: qcom,tsens-v0_1 > > + > > + - description: v1 of TSENS > > + items: > > + - enum: > > + - qcom,qcs404-tsens > > + - const: qcom,tsens-v1 > > + > > + - description: v2 of TSENS > > + items: > > + - enum: > > + - qcom,msm8996-tsens > > + - qcom,msm8998-tsens > > + - qcom,sdm845-tsens > > + - const: qcom,tsens-v2 > > + > > + reg: > > + maxItems: 2 > > + items: > > + - description: TM registers > > + - description: SROT registers > > + > > + nvmem-cells: > > + minItems: 1 > > + maxItems: 2 > > + description: > > + Reference to an nvmem node for the calibration data > > + > > + nvmem-cells-names: > > This is going to require 2 items, so you need an explicit minItems and > maxItems. Will fix. > > + items: > > + - enum: > > + - caldata > > + - calsel > > + > > + "#qcom,sensors": > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + - minimum: 1 > > + - maximum: 16 > > + description: > > + Number of sensors enabled on this platform > > + > > + "#thermal-sensor-cells": > > + const: 1 > > + description: > > + Number of cells required to uniquely identify the thermal sensors. Since > > + we have multiple sensors this is set to 1 > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - qcom,msm8916-tsens > > + - qcom,msm8974-tsens > > + - qcom,qcs404-tsens > > + - qcom,tsens-v0_1 > > + - qcom,tsens-v1 > > + then: > > + properties: > > + interrupts: > > > + minItems: 1 > > + maxItems: 1 > > These can be implicit. Will remove all of these. > > + items: > > + - description: Combined interrupt if upper or lower threshold crossed > > + interrupt-names: > > + minItems: 1 > > + maxItems: 1 > > ditto. > > > + items: > > + - const: uplow > > + > > + else: > > + properties: > > + interrupts: > > + minItems: 2 > > + maxItems: 2 > > ditto. > > > + items: > > + - description: Combined interrupt if upper or lower threshold crossed > > + - description: Interrupt if critical threshold crossed > > + interrupt-names: > > + minItems: 2 > > + maxItems: 2 > > ditto. > > > + items: > > + - const: uplow > > + - const: critical > > + > > +required: > > + - compatible > > + - reg > > + - "#qcom,sensors" > > + - interrupts > > + - interrupt-names > > + - "#thermal-sensor-cells" > > + > > +examples: > > + - | > > + #include > > + // Example 1 (legacy: for pre v1 IP): > > + tsens1: thermal-sensor@900000 { > > + compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1"; > > + reg = <0x4a9000 0x1000>, /* TM */ > > + <0x4a8000 0x1000>; /* SROT */ > > + > > + nvmem-cells = <&tsens_caldata>, <&tsens_calsel>; > > + nvmem-cell-names = "caldata", "calsel"; > > + > > + interrupts = ; > > + interrupt-names = "uplow"; > > + > > + #qcom,sensors = <5>; > > + #thermal-sensor-cells = <1>; > > + }; > > + > > + - | > > + #include > > + // Example 2 (for any platform containing v1 of the TSENS IP): > > + tsens2: thermal-sensor@4a9000 { > > + compatible = "qcom,qcs404-tsens", "qcom,tsens-v1"; > > + reg = <0x004a9000 0x1000>, /* TM */ > > + <0x004a8000 0x1000>; /* SROT */ > > + > > + nvmem-cells = <&tsens_caldata>; > > + nvmem-cell-names = "calib"; > > + > > + interrupts = ; > > + interrupt-names = "uplow"; > > + > > + #qcom,sensors = <10>; > > + #thermal-sensor-cells = <1>; > > + }; > > + > > + - | > > + #include > > + // Example 3 (for any platform containing v2 of the TSENS IP): > > + tsens3: thermal-sensor@c263000 { > > + compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; > > + reg = <0xc263000 0x1ff>, > > + <0xc222000 0x1ff>; > > + > > + interrupts = , > > + ; > > + interrupt-names = "uplow", "critical"; > > + > > + #qcom,sensors = <13>; > > + #thermal-sensor-cells = <1>; > > + }; > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index e7a47b5210fd..ff757a4a060c 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -13360,6 +13360,7 @@ L: linux-pm@vger.kernel.org > > L: linux-arm-msm@vger.kernel.org > > S: Maintained > > F: drivers/thermal/qcom/ > > +F: Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > > QUALCOMM VENUS VIDEO ACCELERATOR DRIVER > > M: Stanimir Varbanov > > -- > > 2.17.1 > >