From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE08BC433E3 for ; Mon, 29 Jun 2020 18:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC63E2225F for ; Mon, 29 Jun 2020 18:38:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=verdurent-com.20150623.gappssmtp.com header.i=@verdurent-com.20150623.gappssmtp.com header.b="OQH0L9cB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727955AbgF2SiA (ORCPT ); Mon, 29 Jun 2020 14:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727921AbgF2Sh5 (ORCPT ); Mon, 29 Jun 2020 14:37:57 -0400 Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8F32C02A546 for ; Mon, 29 Jun 2020 05:51:33 -0700 (PDT) Received: by mail-vk1-xa44.google.com with SMTP id t23so3689564vkt.5 for ; Mon, 29 Jun 2020 05:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verdurent-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xHEvnwaXIaI22DXPizYpJcrsTL4/AwhMEQ6IhYTQKlQ=; b=OQH0L9cBVHLRgTVZhw1jd+9UWSypZQN30gG3yvEpHJvc2VXIoNz+hyJGcfUcBU+7e4 oCc7XEKBqBQPleKnUVnLbIp6WsDfC+WCcVQhpW8dNcfHdlE37M0unZrcRr+0gg3/aEvf PMdPFYwgtQ+R9ZtNcXAgyQyPNtpr4cbByuURBHAnjcHM+1N71I+sWI1yfCbGzQcEdiAN yY4uALwvM8jRmBCwqjPgXEIl4AGsHRadzBeA2q8DcqrH+lwiFBEB3A6DNV046uaF3RHg gXgPPRlYEZ8ZU+Sn3QHjIt7k5b5qK/HGOI6FP26Yjc3r+mq7qoc4ZOwpVuG+VUgxyPPT 2jyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xHEvnwaXIaI22DXPizYpJcrsTL4/AwhMEQ6IhYTQKlQ=; b=iki4NdksYCg6erm0SAg7I4akykSN6r/jREis2RYmc+8AArdZonQC/PkbN8xkvzGcHi 1dUNJdx9pYMi46e+Ipp4rX3DfMkM/pWEn/gTcpQK2AFLemzvaEQFVqQmlsEtt+PaU9p4 a7fSy6UHRNc12hCQlt0+/mJEeGqqY0ASHX88PzmjmBDHFBNuN0HKEJIy0Oj+FjTxIxWq cD2ibid8vQtWbJ7DREFuPuKayE8Noe4ndzXoidvq/G/sicVW97lVaHq3V1iZqwVTKkiS DPhREo1RhfaZSeTXj+29/mScP65HeNzoWXAvyNqy3MJ4/JYqp9+5lNticUrEZu3EkwIC ayPg== X-Gm-Message-State: AOAM531gEKjM3WuUTh4sIKc9R3mfGHDXs7kSBE9ZNYztVzU+Igmq1wzG yx85xPTo5bOccCqwi2gPSimmRq5o45xhie9PmO9keg== X-Google-Smtp-Source: ABdhPJxV2IA2m9d5l16yBy3n1SZ0g7UHEZV6/cJ+b6V/XLPjujs0azTgjgMwltUJn2YBO0p0U04OWasRwsCDgvXmOEE= X-Received: by 2002:ac5:c189:: with SMTP id z9mr9880244vkb.79.1593435092807; Mon, 29 Jun 2020 05:51:32 -0700 (PDT) MIME-Version: 1.0 References: <20200619151541.15069-1-geert+renesas@glider.be> In-Reply-To: <20200619151541.15069-1-geert+renesas@glider.be> From: Amit Kucheria Date: Mon, 29 Jun 2020 18:21:21 +0530 Message-ID: Subject: Re: [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation To: Geert Uytterhoeven Cc: Zhang Rui , Daniel Lezcano , Rob Herring , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-renesas-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Jun 19, 2020 at 8:45 PM Geert Uytterhoeven wrote: > > - Document missing "#thermal-sensor-cells", > - Factor out common required properties, > - "interrupts", "clocks", and "power-domains" are required on R-Mobile > APE6, too, > - Invert logic to simplify descriptions, > - Add "additionalProperties: false". > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Amit Kucheria > --- > .../bindings/thermal/rcar-thermal.yaml | 53 ++++++++++++------- > 1 file changed, 34 insertions(+), 19 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml > index 0994693d240f9ff4..88787b98992fe7c9 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml > @@ -59,25 +59,40 @@ properties: > resets: > maxItems: 1 > > -if: > - properties: > - compatible: > - contains: > - enum: > - - renesas,thermal-r8a73a4 # R-Mobile APE6 > - - renesas,thermal-r8a7779 # R-Car H1 > -then: > - required: > - - compatible > - - reg > -else: > - required: > - - compatible > - - reg > - - interrupts > - - clocks > - - power-domains > - - resets > + '#thermal-sensor-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + > +allOf: > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - renesas,thermal-r8a73a4 # R-Mobile APE6 > + - renesas,thermal-r8a7779 # R-Car H1 > + then: > + required: > + - resets > + - '#thermal-sensor-cells' > + > + - if: > + not: > + properties: > + compatible: > + contains: > + const: renesas,thermal-r8a7779 # R-Car H1 > + then: > + required: > + - interrupts > + - clocks > + - power-domains > + > +additionalProperties: false > > examples: > # Example (non interrupt support) > -- > 2.17.1 >