From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F135C3A5A0 for ; Mon, 19 Aug 2019 20:51:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 111FF2087E for ; Mon, 19 Aug 2019 20:51:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZihfdZck" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbfHSUvl (ORCPT ); Mon, 19 Aug 2019 16:51:41 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:39099 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728018AbfHSUvl (ORCPT ); Mon, 19 Aug 2019 16:51:41 -0400 Received: by mail-vs1-f66.google.com with SMTP id y62so2094516vsb.6 for ; Mon, 19 Aug 2019 13:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+KzCPfliyJhvJ1c0iMQplTZBNeAA1mxUAJd/xcjNV38=; b=ZihfdZckUcDLIFJ3PBKZNuHrFkrg+kl8Q6esH4q1/HG09NGkQVfscJhS9miTcnmWs9 hceJ+fMwhxQGzS0Dy9BDD+njDCPCL+AijCDXvK7SmVsHl+YoMxmceVUYrKOcgGznl2yS OZjTRZi60IVwsHNDqxCqC/BCb48qPqWzB6cOmQCpoS+nSoynsxYXKC1v67kB7oEOMjUx d4qS6L6FJPzQsjexyx1rl4fX21XNUBdvlwjtv2AFsPKyatA11Da4oAkHVQD+iG7UVRBp s7RFnzAncWiSWDYWZEWm/VOXRHf3po8HA7y0L2/spCPNggZ+yUTZKNoz3vCGQ9w0mM53 VYCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+KzCPfliyJhvJ1c0iMQplTZBNeAA1mxUAJd/xcjNV38=; b=YtuVCmOpgllo4yqPJ5w6ArmqWK1lJJehPESajaXpYScjceoTVVjf2oEAkXZyNcQEx/ b8XKgDpPAGVl9VKVWrsxwKFmyvZEwF+gQ9GW+KdhbI7rFhD+9kFABBxXHOLPu7S3N3ah y3dxq6GaBsnPWda68vNXWM0PFKCGPIKwwmfz/1zW6dATPVbk7lL+i+/mkQJoBemqCRC8 Ycjzzp+aQavgYzyaZttX1mkwEAt8W2Sa21JILEdI9fzf8CLe5c1fXzy1/AlVkkPJbNyD q6yfqg7G1dkV2Tzv83ffSA44ZI9ZEhgNX7PhTmJWYHXl4vwXl+tsLm2ECiE4kKn8NOCw SDmw== X-Gm-Message-State: APjAAAXYqeg4dqiNRPPNWa7QuYV5IeBpkAXju7kErgb9GWBOs3ckb5aY D3Qe4z4CQxQ7pj4hYOXrNzSn9tsZj8ntPYW7nEhBzQ== X-Google-Smtp-Source: APXvYqwMeMBbIPB8ft3bcughnTjtU/edJ5Dpzo878P9xKkEJ1gCCS8aAJV2Gg+izjIwwMP3lPY6yhB4o44HWe21dUZU= X-Received: by 2002:a67:df07:: with SMTP id s7mr11007757vsk.27.1566247899971; Mon, 19 Aug 2019 13:51:39 -0700 (PDT) MIME-Version: 1.0 References: <07de61a57cf2362169d3b128405d7305eb20785f.1564091601.git.amit.kucheria@linaro.org> <5d577f95.1c69fb81.6c07e.44da@mx.google.com> In-Reply-To: <5d577f95.1c69fb81.6c07e.44da@mx.google.com> From: Amit Kucheria Date: Tue, 20 Aug 2019 02:21:28 +0530 Message-ID: Subject: Re: [PATCH 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature To: Stephen Boyd Cc: Andy Gross , Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui , Andy Gross , Bjorn Andersson , Eduardo Valentin , linux-arm-msm , LKML , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sat, Aug 17, 2019 at 9:46 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-07-25 15:18:49) > > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c > > index 7ab2e740a1da..13a875b99094 100644 > > --- a/drivers/thermal/qcom/tsens-common.c > > +++ b/drivers/thermal/qcom/tsens-common.c > > @@ -84,13 +84,35 @@ static inline int code_to_degc(u32 adc_code, const struct tsens_sensor *s) > > return degc; > > } > > > > +/** > > + * tsens_hw_to_mC - Return properly sign extended temperature in mCelsius, > > Can you make this proper kernel-doc? Describe the arguments and have a > "Return:" section. Will fix. > > + * whether in ADC code or deciCelsius depending on IP version. > > + * This function handles the different widths of the signed integer across IPs. > > + */ > > +static int tsens_hw_to_mC(char *str, struct tsens_sensor *s, int field, int temp) > > +{ > > + struct tsens_priv *priv = s->priv; > > + u32 mask; > > + > > + if (priv->feat->adc) { > > + /* Convert temperature from ADC code to milliCelsius */ > > + return code_to_degc(temp, s) * 1000; > > + } else { > > Please deindent and drop the else because there's a return above. Will fix. > > + mask = GENMASK(priv->fields[field].msb, > > + priv->fields[field].lsb) >> priv->fields[field].lsb; > > Why is the mask generated, shifted right, sent into fls(), and then > passed to sign_extend32? Shoudln't it be something like > > sign_extend32(temp, priv->fields[field].msg - priv->fiels[field].lsb - 1) Yes, that should work and greatly simply the function. Will fix. > > + dev_dbg(priv->dev, "%s: mask: %d\n", str, fls(mask)); > > + /* Convert temperature from deciCelsius to milliCelsius */ > > + return sign_extend32(temp, fls(mask) - 1) * 100; > > + } > > +} > > + > > @@ -112,15 +134,7 @@ int get_temp_tsens_valid(struct tsens_sensor *s, int *temp) > > if (ret) > > return ret; > > > > - if (priv->feat->adc) { > > - /* Convert temperature from ADC code to milliCelsius */ > > - *temp = code_to_degc(last_temp, s) * 1000; > > - } else { > > - mask = GENMASK(priv->fields[LAST_TEMP_0].msb, > > - priv->fields[LAST_TEMP_0].lsb); > > - /* Convert temperature from deciCelsius to milliCelsius */ > > - *temp = sign_extend32(last_temp, fls(mask) - 1) * 100; > > Oh the code is copied. Seems really complicated still. > > > - } > > + *temp = tsens_hw_to_mC("get_temp", s, LAST_TEMP_0, last_temp);