From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82677C54FCF for ; Wed, 25 Mar 2020 06:37:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5875120775 for ; Wed, 25 Mar 2020 06:37:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jDm+gCbr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727262AbgCYGhS (ORCPT ); Wed, 25 Mar 2020 02:37:18 -0400 Received: from mail-vk1-f196.google.com ([209.85.221.196]:39561 "EHLO mail-vk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbgCYGhR (ORCPT ); Wed, 25 Mar 2020 02:37:17 -0400 Received: by mail-vk1-f196.google.com with SMTP id r129so378339vkr.6 for ; Tue, 24 Mar 2020 23:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9jSH6IwIzcHxO1dEAdKynoMSu3DuDL5sjpp02Uv2TK0=; b=jDm+gCbrABJRyKRkp6gI9YwPYuCeyHlXluAEXOh4yEMKoB+Tdx9T0+7noW1hpUNKzZ Kx/ZghXAAOW1qwMTlbHcf7Cig7EJ1MkmptqzUsnzhGfuytVbR6W5/tZy0c9w68S09hEb GoXhEGlfEndrcxqymIz5E4AK/TERQhQBmuoYIdgtF2ZaqtXRhVe8H86H7NSD7Jjg04nA STKax034sKWZzH1CevSpC8khjbcZcVVxIAJfS5r9pkeDk5lT61cLr+mNuU+KGm22qLTf YAMJokPA29sN9sDPIx7mSxT1/xoMMrPUqC9d3wBKZ8Siulb2zK8uHy0mqdOxj8FTcBaV P+dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9jSH6IwIzcHxO1dEAdKynoMSu3DuDL5sjpp02Uv2TK0=; b=SyCv6lO45JkJmJIJdFsGEgl2b54LDfd80ZZp3kpFh5sjCpHdYzbju8S+wiSQLfL3pa J2ucqdaKF0jWeQV5ifJIqP1HNnAte4WPrhVsfGVojC1fTABC91qx9YBi23uWlJXA+Xyq lzB3z7IG1FRb3UwibdHMfkQFuGS58xyfp7FwEaHMQ5h3p1q+M/oTQfD/BbBF+X6ULRJh XcaB04kvn1stiX28flvH+zC8fUYxFvrQrLNiwp8IQQ6cSlxQ8hWLgcWf4CU8ANDC0up+ jPoEf3RVM18KDatjCGaBEvgrurzVV1jPcH831YHDplgztYOpCoY5FRL8fUvt1Bv9STrQ yT8w== X-Gm-Message-State: ANhLgQ06DuIdpOUab7r24VSiPc4i6Qp+lk4rGU/zeOyO6eL4JVAsLAxZ yUGuyB6yIfsWhN7Qs+gXqYDvZt2A6H5ccaHBClbaIg== X-Google-Smtp-Source: ADFU+vsYq8yJ59LPZqkr3eoifR7LDoo0CMncce0p+aNIhNSb+G7C4aTfiUP1oZ5YrcCWtKdvlXN7vBWm52sQhYicOGo= X-Received: by 2002:a1f:ee05:: with SMTP id m5mr1056922vkh.9.1585118235539; Tue, 24 Mar 2020 23:37:15 -0700 (PDT) MIME-Version: 1.0 References: <20200309045411.21859-1-andy.tang@nxp.com> <18c58e1b-583c-2308-ee60-a8923c2027ee@linaro.org> In-Reply-To: From: Amit Kucheria Date: Wed, 25 Mar 2020 12:07:04 +0530 Message-ID: Subject: Re: [PATCH] dt-bindings: thermal: make cooling-maps property optional To: Daniel Lezcano Cc: Yuantian Tang , Zhang Rui , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Mar 16, 2020 at 9:43 PM Amit Kucheria wrote: > > On Mon, Mar 16, 2020 at 8:22 PM Daniel Lezcano > wrote: > > > > On 09/03/2020 05:54, andy.tang@nxp.com wrote: > > > From: Yuantian Tang > > > > > > Cooling-maps doesn't have to be a required property because there may > > > be no cooling device on system, or there are no enough cooling devices for > > > each thermal zone in multiple thermal zone cases since cooling devices > > > can't be shared. > > > So make this property optional to remove such limitations. > > > > > > For thermal zones with no cooling-maps, there could be critic trips > > > that can trigger CPU reset or shutdown. So they still can take actions. > > > > > > Signed-off-by: Yuantian Tang > > Reviewed-by: Amit Kucheria > > > > > Amit, I'm about to pick this patch, it will collide with the yaml > > conversion changes. > > Thanks for the headsup. I can fixup v3 when I respin. > > However, I've always interpreted this binding as follows: > - cooling-maps should be mandatory for active and passive trip types > otherwise there will be no cooling > - cooling-maps make no sense for critical trip type since we're > invoking system shutdown > - cooling-maps are optional for hot trip types. > > Is this your understanding too? > > We should be able to enforce this in YAML. Rui, Daniel, What do you think about the above interpretation of the cooling-maps bindings? Regards, Amit