From: Amit Kucheria <amit.kucheria@verdurent.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] thermal: exynos: Silence warning during deferred probe
Date: Fri, 28 Feb 2020 15:36:20 +0530 [thread overview]
Message-ID: <CAHLCerN7aV82NTAoPT-ukNBJifySqSxfRogXP6ByMmJiV6nuCA@mail.gmail.com> (raw)
In-Reply-To: <20200228092331.21548-1-m.szyprowski@samsung.com>
On Fri, Feb 28, 2020 at 2:53 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fd4a17812f33..e9a90bc23b11 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1094,7 +1094,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)
> &exynos_sensor_ops);
> if (IS_ERR(data->tzd)) {
> ret = PTR_ERR(data->tzd);
> - dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to register sensor: %d\n",
> + ret);
> goto err_sclk;
> }
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-02-28 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200228092342eucas1p1ead44fbfd9ab57c02ffa588ca9acb97a@eucas1p1.samsung.com>
2020-02-28 9:23 ` [PATCH] thermal: exynos: Silence warning during deferred probe Marek Szyprowski
2020-02-28 10:06 ` Amit Kucheria [this message]
2020-02-28 10:29 ` Bartlomiej Zolnierkiewicz
2020-02-28 11:30 ` Krzysztof Kozlowski
2020-03-12 10:57 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerN7aV82NTAoPT-ukNBJifySqSxfRogXP6ByMmJiV6nuCA@mail.gmail.com \
--to=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).