From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FCEC76191 for ; Fri, 26 Jul 2019 11:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D73DB22ADA for ; Fri, 26 Jul 2019 11:10:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h6ymUR/W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbfGZLK3 (ORCPT ); Fri, 26 Jul 2019 07:10:29 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:41718 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbfGZLK2 (ORCPT ); Fri, 26 Jul 2019 07:10:28 -0400 Received: by mail-vk1-f194.google.com with SMTP id u64so10673731vku.8 for ; Fri, 26 Jul 2019 04:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+Y4qgFTam8jDltpvXuikpB8NUvS6TICI4gc9Km9/9k=; b=h6ymUR/Wdkaz6QZ4Um19bcsrvjqfet3lOXOatySMUhcMsrmEKhWpAQeHUddOjCUNG3 8WeP22kIavryy39NJwXKRvLKJ4vVKpMDEwh2N0XjjWNcFCgvidhJPjVQt0FzUNE/JMIQ yjLzh+5CdkEL9g3pA66wOLstWpNlcVMw7ByhMinQ3f0dGplCAFW29WoxF1qJRmvtks+z icKmRjT4r+Ny+PNs/ATAEP29tMcRIq8dHAJRDgkPcmyC0DI42VdXfqKcuQzdMAbJUAEz tycKTPE4UR3UJmQCszlSYhFC6yqR6bMEE0o5kVcW4yOFVAF2YeM8b2bbmNqh40JfB80y tBFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+Y4qgFTam8jDltpvXuikpB8NUvS6TICI4gc9Km9/9k=; b=Pht1dJbLnMydkeQXSd9rYKg/8Zy3/578rKjoh7IdYM2KnhCPIxxX6x7JYHPWCShHfi jlcNzCWIl0ic/VTVVKox8EaA/seFaJsvxOc+KkBDouUgxVzghKHsknYhhkSHW3gV2Err Atlpg1aiWVTG/6oy6m9gFwiq8dgMJGNBr+MbpNgIVsRO6n55yma3VB8bXn8CtT2N175o 9/N+IM/IlOycDr8Q092sm4rHXIaoXdZzZ/+QaWaM/ArWNJ0HaQH3qJeiFWPzm9JF8XUB Tx9MGTiPYJpDoz6NTDGx69Zdn32Yi+E4Q1nTzB1AanS0KPzbaZGLkgUsIsGAM5SLMXgF Bk/g== X-Gm-Message-State: APjAAAXcJOgKh66okfusKww4TyRCpEjcWUYIjSlk0UKmH2sVSntKgAzl iyQuhAtfh/VKsFb+73jEX0F4tbStkZZ3t03B9rs= X-Google-Smtp-Source: APXvYqyEsPXdjlXDvRHyswcdqr7QLVWVINq/KpziiOOUpNZiXxfeIAhCZiR3dfWmbEtxVpwZXJ65KmcjHMQWEQ8HGPM= X-Received: by 2002:a1f:62c3:: with SMTP id w186mr17914153vkb.82.1564139427268; Fri, 26 Jul 2019 04:10:27 -0700 (PDT) MIME-Version: 1.0 References: <20190726103605.GB3327@onstation.org> In-Reply-To: <20190726103605.GB3327@onstation.org> From: Amit Kucheria Date: Fri, 26 Jul 2019 16:40:16 +0530 Message-ID: Subject: Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support To: Brian Masney Cc: LKML , linux-arm-msm , Bjorn Andersson , Eduardo Valentin , Andy Gross , Andy Gross , Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui , Marc Gonzalez , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org (Resending from a desktop client because mobile gmail apparently sends html that gets rejected by all lists) On Fri, Jul 26, 2019 at 4:06 PM Brian Masney wrote: > > Hi Amit, > > On Fri, Jul 26, 2019 at 03:48:35AM +0530, Amit Kucheria wrote: > > Add interrupt support to TSENS. The first 6 patches are general fixes and > > cleanups to the driver before interrupt support is introduced. > > > > This series has been developed against qcs404 and sdm845 and then tested on > > msm8916. Testing on msm8998 and msm8974 would be appreciated since I don't > > have hardware handy. Further, I plan to test on msm8996 and also submit to > > kernelci. > > > > I'm sending this out for more review to get help with testing. > > I can test this on msm8974 for you using a Nexus 5. Here's what I've > done so far: Thanks. I was hoping that would be the case given all your effort getting Nexus 5 supported. :-) > The device tree nodes appear in sysfs: > > / # ls -1 /sys/class/thermal/ > cooling_device0 > cooling_device1 > thermal_zone0 > thermal_zone1 > thermal_zone2 > thermal_zone3 > thermal_zone4 > thermal_zone5 > thermal_zone6 > thermal_zone7 > thermal_zone8 > thermal_zone9 Looks good. What are the contents of the files inside the two cooling_device directories? The output of the following command would be nice: $ grep "" cooling_device?/* > The various temperatures were in the upper 40s and I threw some work at > all four CPU cores to warm up the phone and watched the various > temperatures rise: > > / # for i in $(seq 0 9) ; do > > TYPE=$(cat /sys/class/thermal/thermal_zone$i/type) > > TEMP=$(cat /sys/class/thermal/thermal_zone$i/temp) > > echo "$TYPE = $TEMP" > > done > cpu-thermal0 = 66000 > cpu-thermal1 = 66000 > cpu-thermal2 = 66000 > cpu-thermal3 = 66000 > q6-dsp-thermal = 60000 > modemtx-thermal = 57000 > video-thermal = 61000 > wlan-thermal = 65000 > gpu-thermal-top = 61000 > gpu-thermal-bottom = 59000 > > To test the interrupt support, I lowered all of the temperature trips to > 51C but I'm not sure where to read that notification. I assume one of > the cooling devices or a governor should be started? Sorry but I haven't > done any work in the thermal subsystem yet and I'm short on time this > morning to investigate right now. For now, just checking if the tsens interrupt in /proc/interrupts fires should be fine. I have another patch to add some information to debugs that I'll send at some point. How well does cpufreq work on 8974? I haven't looked at it yet but we'll need it for thermal throttling. > Brian