From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Chris Healy <cphealy@gmail.com>, Cory Tusar <cory.tusar@zii.aero>,
Lucas Stach <l.stach@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/1] power: supply: Add HWMON compatibility layer
Date: Tue, 9 Jul 2019 00:27:40 -0700 [thread overview]
Message-ID: <CAHQ1cqEWpczFb4B2UOfx0qSJd2Nh9HkTfAvkiLVeRT1hpxBPmw@mail.gmail.com> (raw)
In-Reply-To: <20190627182725.v3mgmy35fxoogofe@earth.universe>
On Thu, Jun 27, 2019 at 11:27 AM Sebastian Reichel <sre@kernel.org> wrote:
>
> Hi,
>
> On Wed, Jun 12, 2019 at 01:44:04AM -0700, Andrey Smirnov wrote:
> > Add code implementing HWMON adapter/compatibility layer to allow
> > expositing various sensors present on power supply devices via HWMON
> > subsystem. This is done in order to allow userspace to use single
> > ABI/library(libsensors) to access/manipulate all of the sensors of the
> > system.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > Tested-by: Chris Healy <cphealy@gmail.com>
> > ---
>
> Thanks, queued.
>
Hmm, I just realized that power supply exposing POWER_SUPPLY_PROP_TEMP
will have a thermal zone created for it by default, which will expose
said reading via thermal/HWMON integration layer. Do we want to do
anything about this duplication of functionality? Maybe hide it here
if desc->no_thermal is true? Or just drop reporting temperature from
this patch?
Thanks,
Andrey Smirnov
prev parent reply other threads:[~2019-07-09 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 8:44 [PATCH v4 0/1] HWMON compatibility layer for power supplies Andrey Smirnov
2019-06-12 8:44 ` [PATCH v4 1/1] power: supply: Add HWMON compatibility layer Andrey Smirnov
2019-06-27 18:27 ` Sebastian Reichel
2019-07-09 7:27 ` Andrey Smirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQ1cqEWpczFb4B2UOfx0qSJd2Nh9HkTfAvkiLVeRT1hpxBPmw@mail.gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=cory.tusar@zii.aero \
--cc=cphealy@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).